Coder Social home page Coder Social logo

Comments (12)

justinedelson avatar justinedelson commented on May 23, 2024

Is this on 5.6.0 or 5.6.1?

from acs-aem-commons.

davidjgonzalez avatar davidjgonzalez commented on May 23, 2024

5.6.0 .. Didn't have 5.6.1 on that box to check that yet

from acs-aem-commons.

justinedelson avatar justinedelson commented on May 23, 2024

This is a known issue in 5.6.0 related to custom Cloud Services. The same would be true of TypeKit.

from acs-aem-commons.

justinedelson avatar justinedelson commented on May 23, 2024

closed and marked as a known issue

from acs-aem-commons.

davidjgonzalez avatar davidjgonzalez commented on May 23, 2024

We should add this to the feature docs for these noting they are not 5.6.0 compatible; while this is a "known issue" it is known by very few :)

from acs-aem-commons.

justinedelson avatar justinedelson commented on May 23, 2024

Right, but the whole library is targetted at 5.6.1, not 5.6.0

from acs-aem-commons.

davidjgonzalez avatar davidjgonzalez commented on May 23, 2024

Which whole library? ACS AEM Commons?

from acs-aem-commons.

justinedelson avatar justinedelson commented on May 23, 2024

That's what the README says ;)

from acs-aem-commons.

davidjgonzalez avatar davidjgonzalez commented on May 23, 2024

README says Target AEM 5.6. If it works on 5.5, super. But don't go out of your way. .. not 5.6.1

5.6 means 5.6.x - no?

Now that i think about it - we should probably call out 5.6 support on a the Homepage too since no one reads READMEs.

from acs-aem-commons.

justinedelson avatar justinedelson commented on May 23, 2024

Hmmm. My bad. I thought we changed that. 😖

Then I guess we should fix this.

from acs-aem-commons.

davidjgonzalez avatar davidjgonzalez commented on May 23, 2024

Since its a product issue, i wouldn't be opposed to marking these as working on 5.6.1+ only (and citing the Product issue).

Course, if there is a clean, future-proof way of handling it now - then even better!

from acs-aem-commons.

justinedelson avatar justinedelson commented on May 23, 2024

reclosing... I don't think we need to deal with this.

from acs-aem-commons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.