adlerzei / old-wiki Goto Github PK

Hi,

Very neat extension, but here is a (very anecdotal) problem:

The purpose of https://nostalgia.wikipedia.org is, among other things, to offer a very old layout of Wikipedia, as a snapshot of what it was in 2001. Its layout predates even the legacy vector skin.

However, this extension overrides the original layout, which may be unfortunate, as it contradicts the purpose of the wiki (to be honest, I'm not entirely sure why this wiki allows the skin system).

Shouldn't the extension make an exception for this version of Wikipedia, even if I guess it has very few readers? (not a rhetorical question, I'm not sure if the answer should be 'yes it should').

Not entirely sure of how complicated it is to add an exception with the declarative_net_request method you use, even if I guess it might be trivial.

It'd be like Vector skin is still the default, as it should be!

All jokes aside, I've forked this and added the functionality via a document_end content script (torma616@05e12a8). Happy to submit a PR if you want to incorporate this into the extension!

I haven't done any work to make this toggleable in the popup because to be totally honest I'm not sure exactly how to do that, but in my head, it doesn't seem that difficult in theory.

When I restart the Brave browser the extension stops working. I would have to reinstall it for it to start working again. This doesn't happen on Chrome.
I tested it using the latest versions from installing from the Chrome extension store and loading an unpacked version manually on brave://extensions (both v1.3.0 6th Feb).
I can still manually add "?useskin=vector" on the end of a en.wikipedia.org URL.