Coder Social home page Coder Social logo

Comments (7)

b0rje avatar b0rje commented on August 12, 2024 1

Hi @uerceg,
In the MenuItems its perfectly fine to use #if. But for everthing thats is executed during a buildprocess (especially when running unity in batchmode for creating a build as we do on our buildservers) you should use the BuildTarget (which is passed as a parameter in the OnPostProcess methods). This is the source as it worked for us:

AdjustEditor.cs.zip

from unity_sdk.

aphexyuri avatar aphexyuri commented on August 12, 2024

This is true - we ran into the same issue and I had to change to using 'target'. I should also add that I'm only seeing this with Adjust (we integrate with many other SDK). I to currentplatform checks any numerous places, and values are always iOS, but the #if UNITY_IPHONE never gets executed - very weird behaviour

from unity_sdk.

wellle avatar wellle commented on August 12, 2024

Thanks for the suggestion, we'll do that in the upcoming update 👍

from unity_sdk.

uerceg avatar uerceg commented on August 12, 2024

@b0rje @aphexyuri Sorry for delay in solving this issue, planning to add it to next release. I see what you mean, but do you have advice how to detect platform for MenuItem entries in AdjustEditor.cs?

from unity_sdk.

uerceg avatar uerceg commented on August 12, 2024

Hi @b0rje

And thank you very much for this example, we'll probably add it to our next release. Will ping in here once it's live.

Cheers!

from unity_sdk.

uerceg avatar uerceg commented on August 12, 2024

Added to current PR, will be live soon.

For reference: e6cbd18

from unity_sdk.

uerceg avatar uerceg commented on August 12, 2024

Included in latest v4.7.0: https://github.com/adjust/unity_sdk/releases/tag/v4.7.0

Thank you one more time for suggestion.

Cheers!

from unity_sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.