adiaddons / adibuttonauras Goto Github PK

While there is a rule in LibPlayerSpells (under druid's COOLDOWN AURA PERSONAL SURVIVAL) and ABA's config confirms it being set up, there is no highlighting whatsoever. The spell has 3 charges and does not show a highlight border or a flashing animation.

62606, -- Savage Defense

Not sure what might be causing it, but my brew (Nimble Brew, Fortifying Brew, etc.) spells are always highlighted on my monk.

Currently the "readme" is very technical minded and doesn't properly introduce brand new users to how the addon works. So I'm proposing the creation of a "Quick start guide", I'll be willing to write it but before I start I'd like input on if there would be a preferred format or any incoming changes that would change the content of said guide.

When opening AdiButtonAuras options for the first time a blank panel will appear, closing and re-opening the options panel will then show the options panel and sub panels.

Tested with only AdiButtonAuras loaded.

Some spells cast a area effect that has a duration but no aura to track it. Would having a BuffTimer sort of helper were one could specify a time to count down from button press something beyond the scope of this addon?

En tank moine, le passif "Mesures désespérées" permet à "Extraction du mal" de ne pas déclencher de CD quand la vie est inférieur à 35% des pv totaux.

Proposition : faire flasher "Extraction du mal" quand la vie du personnage est en dessous de 35% et que "Extraction du mal" ne déclenchera donc pas de CD.

PWS needs to be updated with key and description

1x Invalid value type, expected string, got function
[C]: ?
AdiButtonAuras\RuleDSL.lua:108: in function <AdiButtonAuras\RuleDSL.lua:94>
AdiButtonAuras\RuleDSL.lua:115: in function <AdiButtonAuras\RuleDSL.lua:112>
AdiButtonAuras\RuleDSL.lua:214: in function <AdiButtonAuras\RuleDSL.lua:211>
AdiButtonAuras\RuleDSL.lua:243: in function <AdiButtonAuras\RuleDSL.lua:237>
(tail call): ?
AdiButtonAuras\rules\Priest.lua:49: in function <AdiButtonAuras\rules\Priest.lua:33>
(tail call): ?
[C]: ?
AdiButtonAuras\RuleDSL.lua:693: in function `BuildRules'
AdiButtonAuras\RuleDSL.lua:708: in function `?'
...nos\libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:147: in function <...nos\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147>
[string "safecall Dispatcher[1]"]:4: in function <[string "safecall Dispatcher[1]"]:4>
[C]: ?
[string "safecall Dispatcher[1]"]:13: in function `?'
...nos\libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:92: in function `Fire'
...ttonAuras\libs\LibSpellbook-1.0\LibSpellbook-1.0-8.lua:247: in function <...ttonAuras\libs\LibSpellbook-1.0\LibSpellbook-1.0.lua:208>
(tail call): ?

Locals:
nil

Hi, how can i ADD this SPELL to get it work on the Actionbar?
http://www.wowhead.com/spell=6229

I cant click it on the Config Buttons, using German Client.

cya

What do you think about adding additional highlight texture support?

Due to my set up some buttons have the blizz flash and the adi highlight and a timer and omnicc timer. I created a a stylish 'pointy arrow' alternative texture to mitigate overlapping elements. (Colossus Smash is Blizz flashing in the shot)

Normal res:

Zoomed view:

Perhaps adding different overlay textures in general could be a thing? It might make the mod more noticeable too. Just something I came up with tonight after thinking about the recent 'spell hint' config option.

Hey,
it's me again, that person with annoying lag issues ;) I've noticed today that ABA might be part of my lag issue, too :(

To be explicit, what I noticed was an increase in used memory from 1MB at load to 2-3MB on bosses. This wouldn't be too worrying, except memory usage increases every couple of seconds by 100-200KB. The other thing is that after throwing in ResourceTools again (which of course messes up timings by its nature) it seems overlayPrototype:RegisterMessage and overlayPrototype:UnregisterMessage are called quite frequently and are rather slow. Couldn't something like this within overlayPrototype:UpdateDynamicUnits lighten the amount of function calls somewhat?

    if listenMouseover and not self.listenMouseover then
        self:RegisterMessage(MOUSEOVER_TICK, 'ScheduleUpdate')
        self.listenMouseover = true
    elseif self.listenMouseover then
        self:UnregisterMessage(MOUSEOVER_TICK)
        self.listenMouseover = false
    end

What I also noticed is that whenever i mouseover a unit there are lots of calls caused by ActionButton_Update which probably relates to many of my macro'd spells with target=mouseover and mod conditions. This might explain why I encounter fps lag mainly on healer characters as I'm a hover-click/hover-cast healer (think Clique) and therefore hover units a lot.

Is there a way to add new Rules (rules/classname.lua) but have the default state be set as disabled?

i.e.. the player must inspect the spell and enable the rule.

Many effects like Clearcasting and Nature's Grasp show stacks, yet there is only ever 1 (so it's visual noise.) The same applies to Faerie Fire, which applies 3 stacks, but never less, so the 3 kind of pointless.

Possibly a rule type could be added:

HideStacks {
135700, -- Clearcasting
16689, -- Nature's Grasp
}

Additionally (I should probably make a separate ticket for this, but it's minor) Druid.lua, Feral Clearcasting spell ID should be "135700" not "16870".

Anyway, I miss InlineAura (mine was heavily modified) but I like this new addon. I look forward to using it in WoD. Thanks!

Personally I feel Friz Quadrata TT is a much more readable font, however to change it I need to edit the code, so it would be nice to see an option for it.

Heart of the Wild http://www.wowhead.com/spell=108288 is a temporary DPS or Defensive cd depending on spec as such it should have an aura tracking it's duration.

Would it be possible to add Beast Cleave for beastmastery hunters? It's a 4 second buff that activates after you cast multishot.

Does AdiButtonAuras support auras from other units? If yes, it would be nice to show a timer on multishot :)

http://www.wowhead.com/spell=118455

The following code:

-- Map aura to modified spell(s)
[114050] = { 114074, 51505 }, -- Ascendance (Elemental): Chain Lightning, Lava Burst
[114051] = 17364, -- Ascendance (Enhancement): Stormstrike
[114052] = { 61295, 73920, 1064, 8004, 77472, 331 }, -- Ascendance (Restoration): Riptide, Healing Rain, Chain Heal, Healing Surge, Greater Healing Wave, Healing Wave

Breaks display of aura cd for shaman's ascendance. Putting it here since i can't see anything obviously wrong in the libplayerspell file.

Not going to open one per spell on this one since they're practically all missing from LibPlayerSpell so here's a more complete list:

Interrupts:

• 6554, Pummel
• 102060, Disrupting Shout (removed in 6.0)
• 57755, Heroic Throw with glyph of Gag Order (debuff: "Silenced - Gag Order")

Buffs:

• 6673, Battle Shout, RAID AP
• 469, Commanding Shout, RAID HP
• 13046, Enrage (probably can't be displayed in an ability but needed for other stuff to display)
• 34428, Victory Rush
• 103840, Impending Victory (talent, should also lightup on victory rush proc)
• 3411, Intervene (applied on target)
• 114029, Safeguard (talent, applied on target)
• 7384, Overpower, Shine on Sudden Execute buff (removed in 6.0)
• 78, Heroic Strike and 845, Cleave should show Stack when under the effect of Glyph of Incite

Debuffs:

• 20243, Devastate (weakened armor)
• 6343, Thunder Clap (weakened blows)
• 5246, Intimidating Shout (fear)
• 1715, Hamstring (slow)
• 12323, Piercing howl (slow, removed in 6.0)
• 107570, Storm Bolt (stun)
• 46968, Shockwave (stun)
• 107566, Staggering Shout (root, removed in 6.0)
• 676, Disarm (disarm, removed in 6.0)
• 64382, Shattering Throw (temporary armor debuff, removed in 6.0)
• 355, Taunt (taunt)
• 12294, Mortal Strike (healing debuff)
• 86346, Colossus Smash (personal armor ignore)

DPS Cooldowns:

• 1719, Recklessness
• 12292, Bloodbath (talent)
• 46924, Bladestorm (talent)
• 107574, Avatar (talent)
• 12328, Sweeping Strikes

Defensive CDS:

• 18499, berserker rage (fear breaker and causes enrage)
• 871, Shield Wall
• 12975, Last Stand
• 55694, enrage regeneration (talent, should shine on enrage aura at least until 6.0 is out)
• 1160, Demoralizing shout (self buff and mob debuff)
• 23920, Spell Reflection
• 114028, Mass Spell Reflection

Raid Cds:

• 114030, Vigilance (talent, tank cd)
• 97462, Rallying Cry
• 114192, Mocking Banner
• 114203, Demoralizing Banner (removed in 6.0)
• 114207, Skull Banner (removed in 6.0)

Active mitigation:

• 2565, Shield Block (the buff doesn't seem to connect to the button spell)
• 112948, Shield Barrier (could also shine when at 60 rage)

This should mostly cover Arms and Protection, Fury specific spells are still missing.

Using latest dev build. I don't know that much about warlocks but changing the offending GetPlayerAura to GetPlayerBuff seems to solve the issue.

8x AdiButtonAuras\rules\Warlock.lua:89: Unknown symbol 'GetPlayerAura'.
[C]: ?
AdiButtonAuras\core\SafeEnv.lua:87: in function <AdiButtonAuras\core\SafeEnv.lua:84>
AdiButtonAuras\rules\Warlock.lua:89: in function `handler'
AdiButtonAuras\core\Overlays.lua:438: in function <AdiButtonAuras\core\Overlays.lua:430>

Locals:
t = <table> {
 DescribeLPSSource = <function> defined @AdiButtonAuras\core\RuleDSL.lua:250
 BuildKey = <function> defined @AdiButtonAuras\core\Utils.lua:85
 BuildAuraHandler_FirstOf = <function> defined @AdiButtonAuras\core\RuleDSL.lua:302
 BuildDesc = <function> defined @AdiButtonAuras\core\RuleDSL.lua:238
 DescribeHighlight = <function> defined @AdiButtonAuras\core\RuleDSL.lua:217
 ShowPower = <function> defined @AdiButtonAuras\core\RuleDSL.lua:492
 UnitPowerMax = <function> defined =[C]:-1
 format = <function> defined =[C]:-1
 GetTime = <function> defined =[C]:-1
 UnitClass = <function> defined =[C]:-1
 SelfBuffAliases = <function> defined @AdiButtonAuras\core\RuleDSL.lua:564
 floor = <function> defined =[C]:-1
 UnitCastingInfo = <function> defined =[C]:-1
 IterateAuras = <function> defined @AdiButtonAuras\core\AuraTools.lua:275
 GetDebuff = <function> defined @AdiButtonAuras\core\AuraTools.lua:244
 PetBuffs = <function> defined @AdiButtonAuras\core\RuleDSL.lua:552
 GetTotemInfo = <function> defined =[C]:-1
 BuffAliases = <function> defined @AdiButtonAuras\core\RuleDSL.lua:556
 UnitPower = <function> defined =[C]:-1
 UnitHealth = <function> defined =[C]:-1
 SimpleDebuffs = <function> defined @AdiButtonAuras\core\RuleDSL.lua:526
 ImportPlayerSpells = <function> defined @AdiButtonAuras\core\RuleDSL.lua:492
 UnitIsDeadOrGhost = <function> defined =[C]:-1
 DescribeFilter = <function> defined @AdiButtonAuras\core\RuleDSL.lua:221
 SimpleBuffs = <function> defined @AdiButtonAuras\core\RuleDSL.lua:534
 Configure = <function> defined @AdiButtonAuras\core\RuleDSL.lua:492
 GetComboPoints = <function> defined =[C]:-1
 GetSpellInfo = <function> defined =[C]:-1
 UnitHealthMax = <function> defined =[C]:-1
 min = <function> defined =[C]:-1
 IteratePlayerBuffs = <function> defined @AdiButtonAuras\core\AuraTools.lua:252
 SafeGetGlobal = <function> defined @AdiButtonAuras\core\SafeEnv.lua:73
 IteratePlayerDebuffs = <function> defined @AdiButtonAuras\core\AuraTools.lua:252
 tinsert = <function> defined =[C]:-1
 SharedSimpleDebuffs = <function> defined @AdiButtonAuras\core\RuleDSL.lua:530
 string = <table> {
 }
 DescribeAllSpells = <function> defined @AdiButtonAuras\core\RuleDSL.lua:231
 bit = <table> {
 }
 print = <function> defined @FrameXML\RestrictedInfrastructure.lua:116
 IterateDebuffs = <function> defined @AdiButtonAuras\core\AuraTools.lua:252
 table = <table> {
 }
 IterateBuffs = <function> defined @AdiButtonAuras\core\AuraTools.lua:252
 GetLib = <function> defined @AdiButtonAuras\core\SafeEnv.lua:66
 ipairs = <function> defined =[C]:-1
 GetNumGroupMembers = <function> defined =[C]:-1
 PLAYER_CLASS = "WARLOCK"
 AddRuleFor = <function> defined @AdiButtonAuras\core\RuleDSL.lua:168
 STAGGER_YELLOW_TRANSITION = 0.3
 GetPlayerDebuff = <function> defined @AdiButtonAuras\core\AuraTools.lua:244
 UnitStagger = <function> defined =[C]:-1
 GetAura = <function> defined @AdiButtonAuras\core\AuraTools.lua:272
 BuildAuraHandler_Longest = <function> defined @AdiButtonAuras\core\RuleDSL.lua:279
 UnitChannelInfo = <function> defined =[C]:-1
 math = <table> {
 }
 L = <table> {
 }
 pairs = <function> defined =[C]:-1
 UnitCanAttack = <function> defined =[C]:-1
 DescribeAllTokens = <function> defined @AdiButtonAuras\core\RuleDSL.lua:225
 SelfBuffs = <function> defined @AdiButtonAuras\core\RuleDSL.lua:548
 Debug = <function> defined @AdiButtonAuras\core\RuleDSL.lua:73
 GetPlayerBuff = <function> defined @AdiButtonAuras\core\AuraTools.lua:244
 GetBuff = <function> defined @AdiButtonAuras\core\

There is no forum on Github, so I just leave this here, open for discussion.

User rule sharing

The rule Lua environment restriction and the user rule panel were just the beginning. I would like to allow people to easily share their custom rules:

• with hyperlinks: one button to put an hyperlink into the chatbox. One can then hover an rule hyperlink to see some information and click to import it.
• with opaque (base64-encoded) strings: one button would allow to export a opaque string (to share on forums, etc...), and another would allow to import such string.

The Lua environment restriction should prevent bad things to happen (like what happened with WeakAura some time ago) and imported rules would be disabled by default.

User-defined rule improvments

Right now, all rule definition are expected to return a list of rules (technically a list of maybe-nested tables containing functions). That means that user-defined rules should begin (or end) with a "return" statement. I will see if I can get ride of this requirement.

Disabling libraries

I am thinking about adding options to disable these libraries (and the associated rules), with a confirmation message : LibPlayerSpells-1.0, DRData-1.0, LibItemBuffs-1.0, LibDispellable-1.0.

LibPlayerSpells-1.0 usage improvements

I would like to automatically import class rules from LibPlayerSpells-1.0, but also to easily exclude some rules from them.

I am thinking about tracking spells related to custom rules (either built-in or user-defined) and then to automatically exclude LPS rules about them but I am not sure this would work in all cases. Maybe should it only track UNIT_AURA related rules for those these. Another solution would be a "DoNotImport" helper to manually exclude them.

Any thoughts ?

I have recently made the change to inline aura to AdiButtonAura and but there are a couple of things missing. I am not seeing the holy power gained on the abilities that I have seen before. My shield of the Righteous and my Eternal Flame used to show a number 1 - 5 based on the holy power I had. If this can once again be added, that would be wonderful. I am promoting this addon in guild and I am sure others who switch from inline will or may have other things missing. I believe Shadow priest had the orbs shown. Not sure if that is still working. I will keep you update on any enhance shaman things since my fiance plays that.

Thanks and looking forward in seeing the update soon.

This issue would be probably a mess as I'm not sure where to report and if I understand the internals of AdiButtonAuras (ABA) and LibPlayerSpells (LPS). As I test what I try to add to LPS through ABA I figured I'd post here.

Enslave Demon and Control Undead place a debuff on the controlled unit, so I suppose the right flags for both of them are PET and INVERT_AURA. Tested this on a Deathknight, because ABA seems to use LPS for that class but has it's own rules for Warlock. The result is no rule for Control Undead added. In ABA in the rule set for Warlock, Enslave Demon is listed under PetBuffs, which is wrong as it would query UnitAura with "HELPFUL PLAYER" set as filter and this won't get the debuff (that is an assumption, I didn't follow the code all the way through). There is no PetDebuffs category though. Btw Health Funnel is also listed there, but does not work either, so it might be a problem in PetBuffs implementation. The Hunter rule set in ABA uses LPS and Mend Pet works as intended there.

Is the intent behind LPS (with ABA) to be able to guess rules from it but for ABA not to be explicitly dependable on it? It seems a bit like a double effort, as the rule set for i.e. warlock in ABA and the data set in LPS are for the bigger part identical in their meaning.

Hey again,

I've added some rules for shaman's totems, i.e. display duration and activity of any totem of the button's totem type. While this is not the exact same behavior as in InlineAuras (where a totem spell only displays its own totem's duration, not that of any active totem of its type), I think it might be sensible to help players avoid unintentionally canceling/overwriting their totems.

Configure {
    "FireTotems",
    format(L["Show %s duration."], L["fire totems"]),
    {3599, 8190, 2894}, -- Searing, Magma, Fire Elemental Totem
    "player",
    "PLAYER_TOTEM_UPDATE",
    function(units, model)
        local haveTotem, name, startTime, duration, icon = GetTotemInfo(FIRE_TOTEM_SLOT)
        if haveTotem then
            model.highlight = "good"
            model.expiration = startTime + duration
        end
    end,
    {3599, 8190, 2894},
},
Configure {
    "EarthTotems",
    format(L["Show %s duration."], L["earth totems"]),
    {2484, 8143, 51485, 108270, 2062}, -- Earthbind, Tremor, Earthgrab, Stone Bulwark, Earth Elemental Totem
    "player",
    "PLAYER_TOTEM_UPDATE",
    function(units, model)
        local haveTotem, name, startTime, duration, icon = GetTotemInfo(EARTH_TOTEM_SLOT)
        if haveTotem then
            model.highlight = "good"
            model.expiration = startTime + duration
        end
    end,
    {2484, 8143, 51485, 108270, 2062},
},
Configure {
    "WaterTotems",
    format(L["Show %s duration."], L["water totems"]),
    {16190, 108280, 5394}, -- Mana Tide, Healing Tide, Healing Stream Totem
    "player",
    "PLAYER_TOTEM_UPDATE",
    function(units, model)
        local haveTotem, name, startTime, duration, icon = GetTotemInfo(WATER_TOTEM_SLOT)
        if haveTotem then
            model.highlight = "good"
            model.expiration = startTime + duration
        end
    end,
    {16190, 108280, 5394},
},
Configure {
    "AirTotems",
    format(L["Show %s duration."], L["air totems"]),
    {98008, 120668, 108269, 8177, 108273}, -- Spirit Link, Stormlash, Capacitator, Grounding, Windwalk Totem
    "player",
    "PLAYER_TOTEM_UPDATE",
    function(units, model)
        local haveTotem, name, startTime, duration, icon = GetTotemInfo(AIR_TOTEM_SLOT)
        if haveTotem then
            model.highlight = "good"
            model.expiration = startTime + duration
        end
    end,
    {98008, 120668, 108269, 8177, 108273},
},

Similar totem rules might be useful for Mistweaver Monks, Deathknights and Druids, too! Especially for a Restoration Druid, adding the mushroom's duration as well as its current charge might be incredibly useful? Considering "popping" mushrooms at maximum potency (which can most likely be calculated from player's max health and effective healing from hots - out of scope?) seems easier when knowing the current charge, maybe a 0-100 "rating" (in percent)?

Absolutely a side note, but probably not worth an extra ticket: There's a typo (enmey instead of enemy) in https://github.com/Adirelle/AdiButtonAuras/blob/master/RuleDSL.lua#L608

While burning Rush does change it's icon after activation it's not distinct enough to always be noticeable (both icons are completely red), since this ability will constantly consume HP until the user reaches 1% it's nice to have an aura for it.

Adding:
111400, -- Burning Rush (talent)

to line 86 of LibPlayerSpells-1.0\data\Warlock.lua will fix this issue.

The rule for it is added through LPS but seems to get deactivated because Thrash (feral) is unknown.

Buff Auras show number of party/raid members that do not have the buff as a stack count, this is not immediately obvious or explained thus causing confusing for the user, furthermore the addon counts dead people for it's "missing buff" count reducing it's usefulness.

Can be fixed by adding some short documentation on the feature, adding some textual distinction to the counter (like being "m1" instead of just number "1") and finally ignoring dead players for the total count.

Hey Adirelle, two issues on my elemental Shaman:

• Flame Shock debuff no longer shows the remaining duration. The red debuff-glow is still shown.
  • LPS-SHAMAN-5.4.1-1.5 is enabled
• Earth Shock no longer shows stack counts. Only the debuff applied + duration are shown.
  • 'Show the "bad" border when the debuff is found on your targetted enemey.' is enabled which also uses a different wording than the flame shock rule
  • 'Show Lightning Shield stacks.' is enabled

Tested on Destruction Warlock using Purified Bindings of Immerseus http://www.wowhead.com/item=104924 no other addon beside AdibuttonsAuras and Dominus was loaded the trinket did not show a proc Aura buff even though it's included on the item database and appears to be correct.

Currently Global and Theme options both affect the visual display of the auras, so for consistency it seems pertinent to just merge the two into a unified Display panel or just have most of global settings moved into theme.

Alternatively they can be split into graphical and textual theme panels.

Loading an enhancement shaman with the latest version produces this:

27x AdiButtonAuras\rules\Shaman.lua:84: 'WATER_TOTEM_SLOT' is forbidden in rule snippets.
[C]: ?
AdiButtonAuras\RuleDSL.lua:708: in function <AdiButtonAuras\RuleDSL.lua:707>
AdiButtonAuras\rules\Shaman.lua:84: in function `handler'
AdiButtonAuras\Overlays.lua:437: in function <AdiButtonAuras\Overlays.lua:429>

Locals:
_ = <table> {
 DescribeLPSSource = <function> defined @AdiButtonAuras\RuleDSL.lua:335
 BuildKey = <function> defined @AdiButtonAuras\RuleDSL.lua:146
 BuildAuraHandler_FirstOf = <function> defined @AdiButtonAuras\RuleDSL.lua:399
 BuildDesc = <function> defined @AdiButtonAuras\RuleDSL.lua:323
 DescribeHighlight = <function> defined @AdiButtonAuras\RuleDSL.lua:302
 ShowPower = <function> defined @AdiButtonAuras\RuleDSL.lua:602
 UnitPowerMax = <function> defined =[C]:-1
 format = <function> defined =[C]:-1
 UnitChannelInfo = <function> defined =[C]:-1
 UnitClass = <function> defined =[C]:-1
 SelfBuffAliases = <function> defined @AdiButtonAuras\RuleDSL.lua:688
 pairs = <function> defined =[C]:-1
 UnitCastingInfo = <function> defined =[C]:-1
 UnitBuff = <function> defined =[C]:-1
 PetBuffs = <function> defined @AdiButtonAuras\RuleDSL.lua:676
 GetTotemInfo = <function> defined =[C]:-1
 BuffAliases = <function> defined @AdiButtonAuras\RuleDSL.lua:680
 SPELL_POWER_MANA = 0
 UnitHealth = <function> defined =[C]:-1
 SimpleDebuffs = <function> defined @AdiButtonAuras\RuleDSL.lua:650
 ImportPlayerSpells = <function> defined @AdiButtonAuras\RuleDSL.lua:602
 UnitIsDeadOrGhost = <function> defined =[C]:-1
 DescribeFilter = <function> defined @AdiButtonAuras\RuleDSL.lua:306
 SimpleBuffs = <function> defined @AdiButtonAuras\RuleDSL.lua:658
 Configure = <function> defined @AdiButtonAuras\RuleDSL.lua:602
 GetComboPoints = <function> defined =[C]:-1
 GetSpellInfo = <function> defined =[C]:-1
 UnitHealthMax = <function> defined =[C]:-1
 min = <function> defined =[C]:-1
 tinsert = <function> defined =[C]:-1
 SharedSimpleDebuffs = <function> defined @AdiButtonAuras\RuleDSL.lua:654
 string = <table> {
 }
 DescribeAllSpells = <function> defined @AdiButtonAuras\RuleDSL.lua:316
 bit = <table> {
 }
 table = <table> {
 }
 GetLib = <function> defined @AdiButtonAuras\RuleDSL.lua:618
 ipairs = <function> defined =[C]:-1
 GetNumGroupMembers = <function> defined =[C]:-1
 PLAYER_CLASS = "SHAMAN"
 AddRuleFor = <function> defined @AdiButtonAuras\RuleDSL.lua:253
 UnitDebuff = <function> defined =[C]:-1
 UnitIsPlayer = <function> defined =[C]:-1
 UnitCanAttack = <function> defined =[C]:-1
 BuildAuraHandler_Longest = <function> defined @AdiButtonAuras\RuleDSL.lua:371
 STAGGER_YELLOW_TRANSITION = 0.3
 math = <table> {
 }
 L = <table> {
 }
 UnitStagger = <function> defined =[C]:-1
 DescribeAllTokens = <function> defined @AdiButtonAuras\RuleDSL.lua:310
 ceil = <function> defined =[C]:-1
 SelfBuffs = <function> defined @AdiButtonAuras\RuleDSL.lua:672
 Debug = <function> defined @AdiButtonAuras\RuleDSL.lua:58
 UnitPower = <function> defined =[C]:-1
 select = <function> defined =[C]:-1
 DebuffAliases = <function> defined @AdiButtonAuras\RuleDSL.lua:684
 SharedSimpleBuffs = <function> defined @AdiButtonAuras\RuleDSL.lua:662
 GetTime = <function> defined =[C]:-1
 UnitAura = <function> defined =[C]:-1
 floor = <function> defined =[C]:-1
 PassiveModifier = <function> defined @AdiButtonAuras\RuleDSL.lua:602
 BuildAuraHandler_Single = <function> defined @AdiButtonAuras\RuleDSL.lua:353
 GetSpellBonusHealing = <function> defined =[C]:-1
 GetShapeshiftFormID = <function> defined =[C]:-1
 GetEclipseDirection = <function> defined =[C]:-1
 LongestDebuffOf = <function> defined @AdiButtonAuras\RuleDSL.lua:666
}
name = "WATER_TOTEM_SLOT"
error = <function> defined =[C]:-1
format = <function> defined =[C]:-1

Would it be possible to add a configuration for Dire Beast? I keep forgetting to keep it up. Or is that out of the scope of this AddOn?

Hey,

as fury warrior it is important to know how many stacks of "Raging Blow" are remaining and the duration when they are expiring.

SpellID of Aura ("Raging Blow!"), which should be tracked(stacks and duration): 131116
SpellID of Skill ("Raging Blow"), which should contains these information: 85288

The same apply to to "Meatcleaver" / "Whirlwind". Fury Warriors can collect "Meatcleaver" stacks with "Whirlwinds", which they spend with "Raging Blow".

SpellID of Aura ("Meatcleaver"), which should be tracked(stacks and duration): 85739
SpellID of Skill ("Whirlwind"), which should contains these information: 1680

Both skills are modified by some glyphes, maybe you should look into this too.

I tried to implement that as user rule, but i failed. Maybe a template user rule for simple tasks like would be fine.

Good work so far! (I'm trying to switch from outdated Inline Aura to this Addon).

Greetings

Soul Reaper should shine at target 35% (or 45% if T15 4p bonus present) indicating that it will provide with the bonus shadow damage show the self haste buff gained if the target dies within the 5s window.

Currently it only shows the timing for the shadow damage tick.

http://www.wowhead.com/spell=130735

Proposition : faire flasher "Infusion insaisissable" quand le nombre de charge atteint 10.

NB : nb charge max à 15

Seems one of the latest aditions is causing World of Warcraft to hang.

Tested on WoW-64, ABA, Ampere and Bugsack as the only addon loaded, Lvl70 Shaman. Problem exhibited both in my current fork and latest alpha, my guess would be a loop that's not ending properly.

After switching target I see DoT timers for the old target. It updates only when I DoT the new target.

Hello,
I wanted to report that some Hunter spells aren't working:

Bestial Wrath: No border is shown when i use it.
I thought it could've been because of the 4pcs set bonus but doing it naked didn't do anything.
It would be nice to have the brutal kinship stacks on the button too

Intimidation: No border is shown when an enemy is already stunned.
I have noticed that the addon tracks the Intimidation debuff cast by myself on an enemy (which i think is wrong since the debuff is cast by my pet)...but i think it should just check if the enemy is already stunned since intimidation is a stun

Focus fire: Either it doesn't work or it does exaclty what the blizzard interface already does (since on the configuration it says it checks wheter my pet has a "frenzy" buff).
I think it would be more useful if it just showed a bad border whenever i had the focus fire buff going on

Explosive trap: no border is shown.
Mobs in the area of effect of the trap don't have any debuff, also i think it should be more useful if it showed a bad border for the duration of the effect once it triggers (i'm not sure if it's possible, though)

Freezing trap: No border is shown.

Also, if i activate trap launcher then go in the "spells" section in the AdiButtonAuras configuration, the traps are not taken in consideration as spells that can have an aura

Master's Call: no border is shown when i have the buff.
I think it should also track if my target has master's call buff already

Camouflage: no border is shown when i use it.

Like the title says it seems the count of people missing raid buffs is counting pets (which can't benefit or get raid buffs).

https://github.com/Rainrider/AdiButtonAuras/wiki/Rules

I did cost me some time, I hope I got it right 😅 Please review and feel free to use it as you please

Not sure if this was brought up yet but I do not see the DoT time for Living Bomb on my mage. I have also tested Nether Temptest which is also a tier 5 talent and that is not showing up either. Frost Bomb which is in that same tier however did show a timer. I am wondering if we can get the other 2 up as well?

Thanks

Unlike other classes Death Knight Auras don't have built in highlights or button icon change when enableling a presence, so if used as normal buttons there's no feedback to their active state unless AdiButtonAuras includes them as auras.

the following code in LibPlayerSpells-1.0\data\Rogue.lua:

[121471] = {  Shadow Blades =>
     1752,  Sinister Strike
    84617,  Revealing Strike
    51723,  Fan of Knives
     1833,  Cheap Shot
     8676,  Ambush
      703,  Garrote
},

overrides the aura already displayed on Revealing Strike, since the duration is already shown on the cd button duplicating it by hiding other debuff information is unneeded and unwanted. Commenting it out resolves the issue.

I assume that's just temporary, but I thought I'd say anyway.

Warlock Corruption debuff border/timer is not working (version 1.4).

From testing, spell Corruption (spellID172) applies a debuff (also called "Corruption") with spellID 146739.
Tested with Affliction, Demonolgy, and a new level 3 Warlock.

Rain of Fire provides a self buff marking it's duration to the user, due to the chaotic nature of spell effects this is needed to know when to reapply it.

Adding:
104232, -- Rain of Fire (destruction)

to line 86 of LibPlayerSpells-1.0\data\Warlock.lua will fix this issue.

121x [ADDON_ACTION_BLOCKED] AddOn 'AdiButtonAuras' tried to call the protected function 'OverrideActionBarButton5:Show()'.
!BugGrabber\BugGrabber.lua:581: in function <!BugGrabber\BugGrabber.lua:581>
C: in function `Show'
FrameXML\ActionButton.lua:268: in function <FrameXML\ActionButton.lua:253>

C: in function ActionButton_Update' FrameXML\ActionButton.lua:523: in functionActionButton_OnEvent'
FrameXML\ActionButton.lua:124: in function <FrameXML\ActionButton.lua:117>

Locals:
nil

I've added this to the Shaman setup, but as always its not 100% yet. My goal was to show the current stack count of Lightning Shield in addition to the Weakened Blows duration. I tried some of the other handlers you offer, but couldn't use the power preset because it's not an actual power type, however it's what's probably the most similar.

This should probably only activate when in Elemental spec. Also, it's discussable if the spell should flash or not, and if so, when. Blizzard shows the button's flash and it's power aura at 7 stacks (the maximum amount) and it only stays for a short while before the alerts are hidden again (even if not used).

        Configure {
            "Fulmination",
            format(L['Show %s stacks.'], L["lightning shield"]),
            8042, -- Earth Shock
            "player",
            { "UNIT_AURA", "PLAYER_REGEN_ENABLED", "PLAYER_REGEN_DISABLED" },
            (function()
                local lightningShield = GetSpellInfo(324)
                return function(units, model)
                    local _, _, _, count = UnitAura("player", lightningShield, nil, "HELPFUL PLAYER")
                    model.count = count
                    -- if InCombatLockdown() and count >= 6 then
                    --  model.highlight = "flash"
                    --  return true
                    -- end
                end
            end)(),
            324, -- Provided by: Lightning Shield
        },

Currently when opening AdiButtonAuras options buttons with macros will not be recognized as configurable spells, would it be possible to allow them to be detected as the spells? This is particularly relevant for healers who have everything on mouseover macros.

Some spells like Destruction Warlock Havoc or Restoration Druid heals like Rejuvenation will cause a star like shine aura. While some users might find this useful it can be extremely distracting. So a global disable would be nice.

Example screenshot on a druid: http://imgur.com/yj0GtR4

dafzor@53ec19b and dafzor@7080851 (and dafzor@03d4581 for grammar) allows to disable the shine wile keeping the other beneficial aspects of it.

PS: Feel free to give feedback if i'm doing anything wrong here (new to the github thing)