adguardteam / adguardforsafari Goto Github PK

Like it is in regular browser extension: https://uploads.adguard.com/AdGuard_Settings_2018-10-03_18-50-56.png

Figure out the following:

• How to prepare the app to be published to Mac AppStore
• Is it possible to have a beta tester's channel there? If not, what are the options for beta testers?
• What metadata do we need to supply in order to get the app published. Post the list here, we'll start preparing it.

1. Open Settings - Filters
2. scroll down (important!)
3. Open Language-specific or Other

Actual behaviour: it opens not from the top, so Search area and header are not vivsible
https://uploads.adguard.com/AdGuard_Settings_2018-10-04_16-51-51.png

Current appearance:
https://uploads.adguard.com/up04_00830_Monosnap.png

What it should be:
https://uploads.adguard.com/up04_t4i77_Ext.sketch.png

Here are the strings you should use:

• AdGuard is not running.
• Enabled on this website
• Block an element
• Report this website
• Pause AdGuard
• Run AdGuard

Plan:

# What is AdGuard for Safari

## How to build

## How to report an issue

Example of an issue template:
https://github.com/AdguardTeam/AdguardBrowserExtension/blob/master/issue_template.md

License: GPLv3

1. go to Settings - Filters - Custom - Add custom filter
2. add link to a custom filter, press Next

Actual behaviour: app hangs on Checking your filter

If you uncheck "Enabled on this site", it also will look unchecked for next opened website, but the site will be filtered.

https://uploads.adguard.com/screencast_2018-10-04_13-35-25_2018-10-04_13-57-52.mp4

Steps

1. Open any site (e.g. example.org)
2. Open Safari Extension in toolbar
3. Select area to block on site
4. Refresh page

Expected:
Selected area not visible

Actual:
Selected area on it's place

1. Add custom filter
2. Check filter updates

Actual behaviour: It shows 2 notifications - one about AG filters (were updated or not) and other about Custom filter was updated, even if there was no update for it.

@timirila1 please work with @aalpatkina and prepare a shortlist of languages we will have on the initial release (I suggest English, German, and Russian at least).

Also, we need to update the oneskyapp project and upload the app screenshots there.

Steps

1. Open User Filter section
2. Click on "Filter rules tutorial"

Screenshot: https://uploads.adguard.com/up04_d73e0_Ext.sketch.png

• Full info is in the Sketch file (the image must be updated accordingly with #12)
• You'll need @kaprielov's help with the markup.

Here's how it should work.

1. When the toolbar icon is disabled OR when the content blocker is disabled, you should show this onboarding screen instead of the main extension UI.
2. This is not just about the first install. Any time when any of the necessary extensions are disabled, we must react and show this screen.
3. Once both extensions are enabled, navigate to settings automatically, don't make the user wait.

Now in Custom Filter popup all phrases are hardcoded in English.
We need put all these phrases in translation file, and update markup in accordance with it.

https://uploads.adguard.com/TimSheninql3fl.png

See the screenshot:

Just open the main app window when it is clicked.

1. Add custom filter
2. Again open the form for adding custom filter

Actual result

Need to clear the form

If you turn the setting on or off in General, it should have the same state in Filters - Other. and vice versa.

Add such items as:

• About

• Preferences

• Hide AdGuard
• Hide Other
• Show All
  ....

Expected that Safari browser will be opened when user click on "Open preferences"

1. in Safari tap on AG icon
2. Tap 'Block an element'

Expected behaviour: AG menu hides, Assistant menu opens

Actual behaviour: AG menu stays on the screen

https://uploads.adguard.com/Novosti__Meduza_2018-10-04_17-11-45.png

Create a new project on adguard.oneskyapp.com:

• Project group=Adguard Browser Extensions

• Name="AdGuard for Safari".

• Also, add download/upload localization scripts

• Don't forget about the native part of the code

• Add a script that scans the extension code and searches for redundant strings there

in light mode Mojave; High Sierra

1. Open Whitelist, type some domains
2. Turn on Inverted whitelist
3. Type something
4. Press cmd+z several times until whitelist editor appears.

How Whitelist and Inverted whitelist editors connected?

Steps:

• Open any section with text input (e.g. Whitelist)
• Try to Paste some text from clipboard

The current logic is based on what filters are enabled. This is wrong, filter groups must have their own status.

Here's how it must work:

1. When the filter group is enabled for the first time, we must also enable all filters with the recommended tag and matching the lang tag (if it is specified).
2. We no more do it afterward, even when the user switches the filter group status on or off.

Sketch file is shared in Slack.

• Plug in ESLint with airbnb guidelines config https://github.com/airbnb/javascript for ES6
• Set git hooks to run linter (after)

Steps

1. Open Filters section
2. Click on Custom and Add custom filter
3. Add any valid url to filter or https://easylist-downloads.adblockplus.org/easylist.txt
4. Next -> (wait) -> Subscribe

Uncaught Exception:
TypeError: Cannot read property 'enabled' of undefined
    at Object.groupHasEnabledStatus (/Users/timshenin/adguard/safari-app-extension/ElectronMainApp/src/main/app/filters/subscriptions.js:414:29)
    at enableFilter (/Users/timshenin/adguard/safari-app-extension/ElectronMainApp/src/main/app/filters-manager.js:146:28)
    at /Users/timshenin/adguard/safari-app-extension/ElectronMainApp/src/main/app/filters-manager.js:205:25
    at onFilterLoaded (/Users/timshenin/adguard/safari-app-extension/ElectronMainApp/src/main/app/filters-manager.js:172:13)
    at addAntiBannerFilter (/Users/timshenin/adguard/safari-app-extension/ElectronMainApp/src/main/app/filters-manager.js:176:13)
    at loadNextFilter (/Users/timshenin/adguard/safari-app-extension/ElectronMainApp/src/main/app/filters-manager.js:203:17)
    at Object.addAndEnableFilters (/Users/timshenin/adguard/safari-app-extension/ElectronMainApp/src/main/app/filters-manager.js:213:9)
    at EventEmitter.<anonymous> (/Users/timshenin/adguard/safari-app-extension/ElectronMainApp/src/main/ui-event-handler.js:33:25)

1. Load a webpage
2. Tap on AG icon in Safari
3. Uncheck "Enable on this website

Actual behavior: Domain will be added to Whitelist with some alien symbols :)
Domain will be excluded from filtering though.

https://uploads.adguard.com/AdGuard_Settings_2018-10-04_15-27-20.png

1.Try to block some element with manual blocking tool (using preview button!)

Actual behaviour: Block button doesn't work, Rule won't be added to UF

https://uploads.adguard.com/Google_2018-10-04_14-50-00.png

It does start the Electron app, but the main window is not opened.

Expected behavior: always bring the main window on top.

1. go to Settings - Filters - Custom - Add custom filter
2. tap on Cancel

Actual result: Cancel button doesn't work

Is it possible to have a beta tester's channel there? If not, what are the options for beta testers?

Related issue
#10

Toolbar Icon

Name = AdGuard Safari Icon
Description = You can use this icon to manage AdGuard for Safari settings. For instance, pause blocking on a website, or block an ad manually.

Content Blocker

Name = AdGuard
Description = Fast and lightweight Safari content blocking extension.

https://uploads.adguard.com/Screenshot_2018-10-01_at_16.58.49.png

I noticed some performance issues when UI repaint. Also it can be difficult to maintain the project when it will become larger.

I suppose we may use React to break UI into components.

Instead of hardcoding exact URLs, we should use our central forwarder with named links (i.e. https://adguard.com/forward.html?app=adguard_safari&action=discuss&from=about).

TBD: a list of links

Steps to reproduce

1. Open Filters
2. Open Group (e.g Ad Blocking)
3. Move mouse over a tag in the last elem in list