adamheinrich / native-utils Goto Github PK

hi
What a good library the NativeUtils is!
NativeUtils works pretty nice.

By using code below,I can load different native library on different platform.
is that necessary to encapsulate System.mapLibraryName() into NativeUtils?

// mapLibraryName() return a platform-dependent native library name
// we get "libHelloJNI.dll" on windows
// we get "libHelloJNI.so" on linux
String libraryName = System.mapLibraryName("libHelloJNI");
NativeUtils.loadLibraryFromJar("/"+libraryName);

Hi,

Great tools!.

Any plan to support loading multiple DLL/SO?

In my app, I'm seeing loadLibraryFromJar called in multiple places such that I'm getting multiple instances of the temp file from the same process. I'm not sure if that's a problem, but I'd appreciate some advice.

Should I wrap code which calls loadLibraryFromJar in a synchronized method and/or have a check to avoid calling this repeatedly? Relatedly, is there a reason neither of these approaches are implemented in native-utils itself?

Currently we all have to copy the class into our source. This is unnecessary work & pollutes the codebase

Can u publish this into a maven central (m2) repository

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running cz.adamh.utils.NativeUtilsTest
Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.039 sec <<< FAILURE! - in cz.adamh.utils.NativeUtilsTest
testLoadLibraryNullPath(cz.adamh.utils.NativeUtilsTest)  Time elapsed: 0.005 sec  <<< ERROR!
java.lang.Exception: Unexpected exception, expected<java.lang.NullPointerException> but was<java.lang.IllegalArgumentException>
	at cz.adamh.utils.NativeUtils.loadLibraryFromJar(NativeUtils.java:78)
	at cz.adamh.utils.NativeUtilsTest.testLoadLibraryNullPath(NativeUtilsTest.java:27)


Results :

Tests in error: 
  NativeUtilsTest.testLoadLibraryNullPath »  Unexpected exception, expected<java...

Tests run: 4, Failures: 0, Errors: 1, Skipped: 0

Got this while running maven goal on your project. I guess the IllegalArgumentException is ok because of main sources, but the tests maybe need to be corrected.

You got a same idea, pls see mine:
https://github.com/WeJoy/JNIJar

Any interesting for combinning them?

Are they any benchmarks of the performance impacts of using this library rather than loading the library "normally", not from the .jar?

Has anyone got an intuition as to its performance impact?

If multiple process invoke 'NativeUtils.loadLibraryFromJar' at the same time, how to ensure the so file consistency?