adamgfraser / 0-to-100-with-zio-test Goto Github PK

Hello Adam,

thanks for the great example! I stumbled upon it by watching the corresponding YT video https://www.youtube.com/watch?v=qDFfVinjDPQ&t
While it was a nice talk I found it hard to understand the method topContributors*. I was actually expecting an artificial error that we would later discover when implementing tests - turned out I was wrong and the method just works fine. So I tried to make it more "readable" to myself by using for-comprehensions:

    for {
      repos <- Github.getRepos(language, limit)
      contributorsM <- ZIO.foreachPar(repos)(Github.getContributors)
      contributor <- contributorsM.flatten
      notScalaStewaredContributor <- notScalaSteward(contributor)
    } yield contributionsByUser(notScalaStewaredContributor)

Sadly this and some other variants that I tried out does not compile.
So my question would be: Is it possible to create a for-comprehension for this method? And if yes why did you not use the for-Comprehension? Concretly the .map(_flatten) part after a .flatMap operation was really hard to understand for me when reading the first time (opening the IDE made it alot easier)

Cheers

* Impl of topContributors:

  def topContributors(
      language: String,
      limit: Int
  ): ZIO[Github, Throwable, List[Contributor]] =
    Github
      .getRepos(language, limit)
      .flatMap(ZIO.foreachPar(_)(Github.getContributors))
      .map(_.flatten)
      .map(notScalaSteward)
      .map(contributionsByUser)