adalab / modulo-2-evaluacion-intermedia-miaor5 Goto Github PK

Some improvements

Really cool job @miaor5 !!!

Here you have some tips to improve the exercise:

JavaScript: basic

• If you call getRandomNumber function outside the event callback, you will be creating a new random number when the page loads. That makes the game really simple and the hints will have the same result. Let's generate the random number when the user clicks on "Jugar" button and starts the round. https://github.com/Adalab/modulo-2-evaluacion-intermedia-miaor5/blob/main/js/main.js#L19
• Extract the feedback painter to a function.

JavaScript: advanced

• Check if the <select> has the default option (with no value).
• Move the feedback logic to a function and execute it on each click.
• Move your bet logic into a function and execute it on each click.

Good practices

• Indent and avoid extra white spaces to improve readability and prevent bugs. Configurate code formatter in VS Code!!!

HTML

• Check this form https://github.com/Adalab/modulo-2-evaluacion-intermedia-miaor5/blob/main/index.html#L16
• Don't leave attributes with empty value.

CSS

• Avoid adding styles until the js code is solid as a rock.

Further challenges

Then you can improve the game as you please, here you have some ideas:

• Check if the player has enough money to bet and if the bet is greater than 0 and lower than the current amount of the player.
• Add a reset button that cleans the select, balance of money and writes the initial feedback.
• Show the restart game button when the game is over and hide the play button.
• Complete the code needed for the restart game button.
• Validates if the balance of money is available is less than the money bet and displays a message
• Whatever you want!

Call to action

Let me know if you have any doubts ;)

Go for it!!

Do not close this issue until your teacher asks you to