Coder Social home page Coder Social logo

code-reviews's Introduction

Code Reviews

Overview

This repository is designed to teach students the code review process. There are several pull requests, PRs, with sample code submissions. Students will practice reviewing these submissions and then discuss their comments for clarity, etiquette and correctness.

How This Will Work

Reviewing PRs

Each student will open 3 PRs in separate tabs in their browser. The PRs are assigned by table. They will review the code adding inline comments, questions and suggested changes. They will not submit the review. Instead, student will wait until all students are finished reviewing the PR.

Then students will submit their reviews and decide if they accept the PR, or want to request changes.

Students are asked to look for:

  • Do I understand what this code is doing? (Readability)
  • Are there things wrong with this code? (Correctness)
  • Are there changes (Improvements) I can suggest to make the code more:
    • Readable
    • Efficient
    • Flexible

Reviewing Code Reviews

After students are finished reviewing the PRs each table will examine the code comments and discuss.

As students review comments they are asked:

  • Is this comment correct?
  • Does the comment clearly communicate the point?
  • Is the comment kind and collaborative?

Wrap Up

At the end of the lesson the class will discuss group observations and unanswered questions.

Connected Lesson

Resources

code-reviews's People

Watchers

 avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.