Comments (11)
@JasonGross if it's causing problems there's also a way to disable the problem matcher.
https://github.com/actions/toolkit/blob/master/docs/commands.md#problem-matchers
We added that feature since the scope of a problem matcher is a job and scripts / steps downstream could get false hits.
from setup-go.
I think the solution is to have a much tighter regex for compile errors and then if there's things it misses, problem matchers supports having multiple matchers.
I'll have a PR soon for the v2-beta lineage.
from setup-go.
from setup-go.
I think this action does the right thing. Perhaps the issue is service side which turns output into warning and error annotations. @joshmgross to verify whether there's anything we can do action side.
from setup-go.
No, I'm pretty sure this is an issue with your matcher being overzealous:
Line 7 in 1c06f0e
This claims that every single output line containing two :
s separated by a number an followed by a space is an error in the file that comes before the first colon.
from setup-go.
Ahhh. OK. Thanks @JasonGross
@thboop has another issue on the matcher so maybe he can look at both together.
from setup-go.
@JasonGross if it's causing problems there's also a way to disable the problem matcher.
https://github.com/actions/toolkit/blob/master/docs/commands.md#problem-matchers
We added that feature since the scope of a problem matcher is a job and scripts / steps downstream could get false hits.
Oh, neat! Thanks! Do you know why this isn't documented at https://github.com/actions/toolkit/blob/master/docs/problem-matchers.md ?
from setup-go.
We can add there. In the meantime, I'm also working on a better solution.
from setup-go.
@JasonGross I have a PR that might help: #48
You can try it out with use: actions/setup-go@matcher
I added tests but it would be great to verify before merging.
from setup-go.
I'm running a test here: https://github.com/mit-plv/fiat-crypto/pull/703/checks?check_run_id=547046526
from setup-go.
Thanks for validating. This is now in setup-go@v2-beta
and soon to be v2
. If you're using the matcher ref from the PR, you may want to update to v2-beta
(that won't go away).
from setup-go.
Related Issues (20)
- Inaccurate description of version in go.mod HOT 2
- Please upgrade `go-actions` to 1.21.8 / 1.22.1 HOT 3
- Signing key has expired HOT 2
- Node16 deprecated HOT 1
- Support custom distribution location override HOT 1
- Can't cache dependencies from a composite action HOT 9
- Intermittent failures downloading go HOT 1
- I HOT 3
- I HOT 1
- Failure of "Validate 'setup-go'" on macos-latest HOT 3
- Annotation matcher can not match column ranges HOT 4
- Dependencies file is not found. Supported file pattern: go.sum HOT 9
- [Bug] CGO_ENABLED on macos amd64 is not correct HOT 8
- Caching should use go.mod, not go.sum HOT 3
- Why can't I re-use cache created by actions/setup-go for actions/cache? HOT 3
- Support using a later patch release than what's in go.mod HOT 1
- Ever time I try to set it up it cancels work flow HOT 3
- Cache `go install`-ed binaries HOT 18
- Help HOT 1
- Type in your language with Gboard HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from setup-go.