Coder Social home page Coder Social logo

Comments (4)

HarithaVattikuti avatar HarithaVattikuti commented on July 4, 2024

Hello @silverwind
Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.

from setup-go.

priyagupta108 avatar priyagupta108 commented on July 4, 2024

Hello @silverwind, thank you for your report. I understood your concern. Currently, the problem matcher in the setup-go action is designed to capture a single line and column number where an error originates, and it does not support ranges of line and column numbers. This is primarily due to how GitHub's UI displays these errors. For more details, you can refer to the Problem Matchers documentation. Please note that GitHub's UI may not be able to display a range of columns as a single problem.

from setup-go.

silverwind avatar silverwind commented on July 4, 2024

I think the intention of gopls is clear here, it reports the line range as an error.

The only thing that is a bit unconventional is that gopls check is not usually used as a CLI linter, it is usually used inside a editor extension like in VSCode where these line range errors also are recognized and highlighted as expected.

from setup-go.

priyagupta108 avatar priyagupta108 commented on July 4, 2024

Thank you for your valuable input, @silverwind. We will take your suggestion into consideration for future enhancement to our problem matcher.
In the meantime, here are potential workarounds you may consider:

  • Custom Parser Script: You could create a custom script that parses the gopls check output into a format that the problem matcher can recognize. This could be added as a step in your workflow before the setup-go action:
- name: Parse gopls check output
  run: ./custom-parser-script.sh
- name: Set up Go
  uses: actions/setup-go@v5
  with:
    go-version: '1.20'
  • Custom Problem Matcher: You could also consider creating a custom problem matcher. These are a way for GitHub Actions to interpret and highlight error messages in the console output. You could create a matcher to handle the gopls check output:
- name: Set up Go
  uses: actions/setup-go@v5
  with:
    go-version: '1.20'
- name: Add problem matchers for gopls check
  run: echo "::add-matcher::.github/problem-matcher.json"

For this, you'd need to create a .github/problem-matcher.json file in your repository with the appropriate patterns for gopls check.
For more information on how to create a custom problem matcher, please refer to the GitHub Documentation.

We sincerely appreciate your understanding and contribution to the community.

from setup-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.