Regex matching go-version pulls wrong version about setup-go

[bojan-embroker]

Isn't this correct behavior? ^1.13.1 means or newer minor or patch version.

[stmcginnis]

That should be documented if that is the expected behavior. It's really unfortunate that ^ was chosen then.

With the README referring to it being a "match", and ^ being a regex match for the start of a line, the expectation was that it would only match exactly a value of 1.13.1 with nothing somehow prepended to it.

If that is not treated as a regex, and it is a symbol used to mean "or greater", then I would expect something like + appended to the end or something that doesn't look like a regex matching string.

Since this has been in place for some time now and there may be folks that expect that behavior, maybe the best way to resolve this at this point is to explicitly call out in the README what it means.

[bojan-embroker]

^ symbol is coming form the Node.js's dependency management world. I would say authors took it as a universally known syntax, but since it is not standard in Go I agree it should be documented.

Here is the library implementing this version specification syntax that is used by setup-go:
https://www.npmjs.com/package/semver
Its documentation goes into details of ^.

Go's versioning does not work the same Node.js does so there is some mapping between the two done by setup-to which is also not documented, but can found in the code and code comments:

setup-go/src/installer.ts

Line 183 in 3b4dc6c

export async function findMatch(

[Sergey-Murtazin]

Hi @stmcginnis ! Sorry for the late response!
Could you please clarify if the issue is still actual for you?
Thanks!

[stmcginnis]

Thanks for checking @Sergey-Murtazin! I do think this is still confusing, though I understand now that it is an NPM thing. I still think it is really too bad they chose to use something that looks like a regex pattern for a value that performs a match, but it would probably be too disruptive to change at this point.

I read through the README again, and I don't see anything that mentions how this version match is supposed to work. Feel free to close this issue if others don't agree, but I think it would be very useful to update this repo's README to mention how this matching works and link to the explanation that Bojan pointed out.

Allows changes that do not modify the left-most non-zero element in the [major, minor, patch] tuple.

[Sergey-Murtazin]

Hi, @stmcginnis !

We've updated the documentation.
And as currently written in readme, we are using semver notation.

You can see how to use it here
The ^ sign means that the maximum minor version will be used.

It means that the action works correctly.

If you want to use the maximum 1.13 version, use 1.13.x or 1.13.*

Feel free to contact us if you have any questions.

[Sergey-Murtazin]

I close this issue because it is resolved