Coder Social home page Coder Social logo

acli / atutor Goto Github PK

View Code? Open in Web Editor NEW

This project forked from atutor/atutor

0.0 0.0 0.0 33.57 MB

ATutor is an Open Source Web-based Learning Management System (LMS) used to develop and deliver online courses. Administrators can install or update ATutor in minutes, develop custom themes to give ATutor a new look, and easily extend its functionality with feature modules. Educators can quickly assemble, package, and redistribute standardized Web-based instructional content, easily import prepackaged content, and conduct their courses online. Students learn in an accessible, adaptive, social learning environment.

Home Page: http://www.atutor.ca

PHP 95.72% Shell 0.06% JavaScript 4.22%

atutor's People

Contributors

abhinav-koppula avatar acli avatar anvk avatar atutorlangs avatar boondigo avatar cindyli avatar dhruvj avatar geetakshi avatar harriswong avatar heidiv avatar laurelwilliams avatar mirrisil avatar mrlal avatar radiocontrolled avatar shozub avatar

Watchers

 avatar  avatar

atutor's Issues

Installer output not UTF-8

Adding some UTF8 debug messages to install/install.inc.php reveals that the installer does not seem to be UTF8 safe.

Wrong documentation comments in some functions

For example, in include/install/config_template.php, write_config_file() has @param when @return should be used, and the syntax is wrong.

Although technically speaking there is no standard, but if the comments look like they are following PHPDoc then it should at least try to actually follow the conventions.

Wrong redirect in edit_post.php

In edit_post.php:

if (!$pid || !$fid || !valid_forum_user($fid)) {
$msg->addError('ITEM_NOT_FOUND');
header('Location: ../../../forum/list.php');
exit;
}

Running it in the browser without a pid or fid parameter gives (as expected):

Not Found
The requested URL /~ambrose/projects/forum/list.php was not found on this server.

Apache/2.2.22 (Unix) DAV/2 PHP/5.3.15 with Suhosin-Patch Server at localhost Port 80

Password with U+0027 not handled properly in step2

Step 2 in installation process, file include/install/install.inc.php called by install/include/step2.php

If the database password contains a neutral single quote (U+0027), the backend (which is step2.php itself) fails to handle it correctly and produces misleading error messages:

Error

  • Unable to connect to database server.
  • MySQL version was detected. ATutor requires version 4.1.10 or later.
  • Unable to select or create database .

Note that it fails to even detect the MySQL version.

Traceback: https://github.com/acli/ATutor/wiki/Fresh-installation-on-MacOSX

Punctuation error "Log-in"

In the final installation screen the button shows “Log-in!”

This is grammatically wrong; it should read “Log in!” (two words, no hyphen).

Could not add a second user

This was from a few days ago, but the creation of the user “Bob” (as in the standard “Alice” and “Bob” pair) failed. Need to investigate what’s going on.

MySQL version always blank in step 6

On the Anonymous Data Collection screen (step 6), the MySQL version is always blank.

Removing the @ operator from step6.php reveals that the error was “Warning: mysql_connect() [function.mysql-connect]: Access denied for user '…'@'localhost' (using password: YES) in …/ATutor/install/include/step6.php on line 157”

(This means if the password does not contain U+0027 then the MySQL version should probably be non-blank.)

Traceback: Trackback: https://github.com/acli/ATutor/wiki/Fresh-installation-on-Debian-stable

Path to forum module embedded in actual post body

If the user replies to a post, ATutor will insert an [op] tag with the actual relative URL of the original post (instead of, for example, embedding the necessary ID numbers so that we can reconstruct the URL). This means that a new module to replace forums is actually infeasible, because these URL’s will be pointing to the original module.

So, bug in the design stage.

Blank screen or empty response at login screen

Pressing the “Log-in!” [sic] button at step 7 produces a blank screen at URL login.php?submit=%BB+Log-in%21

If we manually change the URL to just login.php we get an empty response. The headers are still intact and is 200 OK, but there is no content.

$num_per_pages redefined everywhere

$num_per_page is not a configurable constant but is just hard-coded.

forum/view.php
html/forum.inc.php

This causes inconsistency if someone changes the definition of $num_per_page in one file but forgot to change it in the other.

Unhelpful error message and help text in step 5 of installation process

In install/include/step5.php, if config.inc.php does not already exist in the “include” directory (../include relative to install; i.e., the include directory from the ATutor root), the installation script generates the error message “../include/config.inc.php does not exist.”

The “help” text just asks people to change permissions, without telling people what file or in which directory.

It should instead either

  • tell people to create an empty file and then change the file’s permissions, or
  • check for writability in the include directory and attempt to create config.inc.php if it’s writable, and only say “does not exist” if it cannot actually write to the file

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.