Comments (5)
Comment by verretor
Tuesday Jan 23, 2018 at 16:36 GMT
It seems the Android app is escaping HTML which is good for security in my opinion although a bit ugly.
from eclair-mobile.
Comment by btcontract
Tuesday Jan 23, 2018 at 16:49 GMT
@verretor is this relevant inside of Android app? A far as I know escaping is done to prevent javascript execution on websites.
from eclair-mobile.
Comment by verretor
Tuesday Jan 23, 2018 at 17:16 GMT
Could be SQL injection. Eclair uses SQLite.
There are some characters that cause problems in some very specific situations. Imagine your app uses UTF-8 encoding and accepts 2 byte characters such as 뼢 but your database has an encoding that only accepts 1 byte characters.
뼢 is 0xbf22 (2 byte) but when translated into 1 byte, it becomes:
0xbf 0x22 = ¿"
Notice the double quote. That's just one of many examples and it requires a lot of tests to make sure it is really safe.
I think it's better to be too careful than not enough but that's just my opinion.
from eclair-mobile.
Comment by dpad85
Tuesday Apr 03, 2018 at 16:36 GMT
@btcontract By chance did you keep the payment request with the Elaine's Idle Mind
description ? I can't reproduce this issue, even with some exotic characters.
from eclair-mobile.
Comment by btcontract
Tuesday Apr 03, 2018 at 17:16 GMT
no, sorry, it's been a long time.
from eclair-mobile.
Related Issues (20)
- Build failed with errors in Payment.java HOT 1
- QR code display/scannability issue HOT 3
- Receive problem HOT 20
- Please show fees for force close, not just a warning that it might be more expensive. HOT 1
- Cannot open app on android....just shuts down when entering pin HOT 1
- ACINQ channel forced closed after wallet recovery
- Release 0.4.16 on playstore, but not on github?? HOT 1
- Remove android.enableJetifier line from gradle.properties
- Build fail with "Failed to transform shapeless" error on ubuntu 21.04
- Declare specific version for CMake
- [Feature] Build-in Tor support HOT 1
- Where can I find node URIs to paste or scan? HOT 7
- Price rate API returns 404 HOT 1
- Tor HOT 1
- iOS version? HOT 4
- Fund Recovery Help HOT 6
- Help?
- Channel can't be created HOT 2
- Missing git tag & github release for latest version 0.4.18
- [Support] Eclaire Wallet - Testnet
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eclair-mobile.