acifani / soccer-go Goto Github PK

https://www.npmjs.com/package/cli-table3

Identical blocks of code found in 2 locations. Consider refactoring.

https://codeclimate.com/github/acifani/soccer-go/src/commands/fixtures.ts#issue_5aa31950bda9a30001000029

First, thank you for the nice project.

Well, I have a issue with figlet dependency:

➜ fguedes@notebook  ~/Work/github.com/fernandoguedes/soccer-go git:(master) ✗ node lib/index.js 
? Choose a competition 1. Bundesliga
? Choose a function Matchday
(node:22503) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open '/home/fguedes/Work/github.com/fernandoguedes/soccer-go/node_modules/figlet/lib/../fonts/slant.flf'
    at Object.fs.openSync (fs.js:667:18)
    at Object.fs.readFileSync (fs.js:572:33)
    at Function.figlet.loadFontSync (/home/fguedes/Work/github.com/fernandoguedes/soccer-go/node_modules/figlet/lib/node-figlet.js:38:23)
    at Function.me.textSync (/home/fguedes/Work/github.com/fernandoguedes/soccer-go/node_modules/figlet/lib/figlet.js:732:43)
    at Object.<anonymous> (/home/fguedes/Work/github.com/fernandoguedes/soccer-go/lib/commands/fixtures.js:17:32)
    at Generator.next (<anonymous>)
    at /home/fguedes/Work/github.com/fernandoguedes/soccer-go/lib/commands/fixtures.js:7:71
    at new Promise (<anonymous>)
    at __awaiter (/home/fguedes/Work/github.com/fernandoguedes/soccer-go/lib/commands/fixtures.js:3:12)
    at Object.exports.printMatchday (/home/fguedes/Work/github.com/fernandoguedes/soccer-go/lib/commands/fixtures.js:15:41)
(node:22503) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:22503) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I removed the font param from the src/commands/fixtures.ts:9 and src/commands/standings.ts:7 and works nice. I can't found the related issue in figlet repository.

Similar blocks of code found in 3 locations. Consider refactoring.

https://codeclimate.com/github/acifani/soccer-go/src/commands/team.ts#issue_5aa31950bda9a3000100002d

Identical blocks of code found in 2 locations. Consider refactoring.

https://codeclimate.com/github/acifani/soccer-go/src/commands/team.ts#issue_5aa31950bda9a3000100002a

First off I'd just like to say that I absolutely love this thing.

Of late there seems to be a problem with the final scores, they are not reflecting correctly after the game has finished. The World Cup feed seems to be the biggest culprit.

Thanks.

Add a local caching layer that will store API responses. Ideally we would want different maximum age for each type of call (competition, team, fixutres, etc).

Benefits:

• Faster
• Make more requests per day, without asking for an API key

Possible issues:

• Stale data

The dependency ora was updated from 3.1.0 to 3.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ora is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

The devDependency ts-jest was updated from 23.1.4 to 23.10.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ts-jest is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

yarn is causing issues on type definition updates, like in #39, and npm ci is pretty fast these days

The devDependency @types/ora was updated from 3.1.0 to 3.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/ora is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Identical blocks of code found in 2 locations. Consider refactoring.

https://codeclimate.com/github/acifani/soccer-go/src/commands/team.ts#issue_5aa31950bda9a30001000028

Expected Behavior

Execute the CLI on macOS and maybe linux

Actual Behavior

prints out env: node\r: No such file or directory

Steps to Reproduce the Problem

1. npm i -g soccer-go
2. soccer-go

Specifications

• Version: 0.4.2
• Platform: macOS 10.13.6
• NodeJS Version: 8.9.0

There are a couple of unhandled exception here and there right now. Error handling should be streamlined and the user should be presented with clear error messages - what went wrong and why.

The devDependency ts-jest was updated from 24.0.0 to 24.0.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ts-jest is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Expected Behavior

as shown in README.md

Actual Behavior

all commands =
✖ Fetching competition...
✖ Fetching matchday...
undefined
410

Steps to Reproduce the Problem

1. install nodejs-soccer-go 0.4.0-2 from aur on fully updated Archlinux box
2. execute any soccer-go command

Specifications

• Version: 0.4.0-2
• Platform: Archlinux
• NodeJS Version: community/nodejs 11.6.0-1 [installed]

Is this a problem with the AUR pkg maintainer, should i flag his pkg out of date or is the problem from upstream?
Regards & thanks for the code :xd

Function get has 55 lines of code (exceeds 25 allowed). Consider refactoring.

https://codeclimate.com/github/acifani/soccer-go/src/commands/team.ts#issue_5aa3194cbda9a30001000023

The devDependency @types/node was updated from 11.12.1 to 11.12.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/node is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Identical blocks of code found in 2 locations. Consider refactoring.

https://codeclimate.com/github/acifani/soccer-go/src/commands/fixtures.ts#issue_5aa31950bda9a3000100002b

Expected behavior

When on an outdated version we should be prompted to run npm i -g soccer-go

Actual behavior

When on an outdated version we are prompted to run npm i soccer-go, missing the -g flag

The devDependency @types/node was updated from 11.11.1 to 11.11.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/node is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴