ASSERT [OpenCore] ImageLoader.c(986): ((BOOLEAN)(0==1)) about bugtracker

[mikebeaton]

@tijon1 - thanks for clear and helpful bug report

[vit9696]

@mhaeuser, @mikebeaton we assert here:

  //
  // Load the image ourselves in secure boot mode.
  //
  if (SecureBootStatus == EFI_SUCCESS) {
    if ((SourceBuffer != NULL) && (OcImageLoaderCaps == NULL)) {
      Status = OcImageLoaderLoad (
                 FALSE,
                 ParentImageHandle,
                 DevicePath,
                 SourceBuffer,
                 SourceSize,
                 ImageHandle
                 );
    } else {
      //
      // We verified the image, but contained garbage, or we are trying to secure boot a Fat slice.
      // This should not happen.
      //
      ASSERT (FALSE);
      Status = EFI_UNSUPPORTED;
    }
  }

• SecureBootStatus is EFI_SUCCESS due to (Policy == AppleImg4SbModeDisabled) && OcAppleSecureBootGetDmgLoading (NULL) policy.
• OcImageLoaderCaps is OC_KERN_CAPABILITY_K64_U64, thus not NULL.

[mikebeaton]

@tijon1 - Can you confirm what the behaviour is with FixupAppleEfiImages set to true in config.plist?

[tijon1]

@mikebeaton @vit9696 The result remains the same with FixupAppleEfiImages, not advancing anywhere past that assert

[mikebeaton]

@tijon1 - Can you confirm that the macOS XCODE5 Artifacts downloadable from here https://github.com/acidanthera/OpenCorePkg/actions/runs/9830476980 resolve the issue?

[tijon1]

@mikebeaton @vit9696 I can confirm that the recent PR and build has fixed my issue entirely, thank you a lot for the fast work! I recommend changing readme to also mention Lion as that's the earliest version I could get the assert on, anything past 10.8 doesn't have this issue.