acgessler / cpp.js Goto Github PK

E.g. the #error at https://github.com/tgstation/tgstation/blob/8b19b490d19cc63c694d95641527cb103108b425/code/_compile_options.dm#L76 is reported as being on line 72

Hi, first of all - thank you a lot for this awesome library. The second - could you do a favor and publish the library as a NPM module?

I could prepare the stuff required for that, if needed.

complex test like # if defined( _VALUE1) && defined(_VALUE2) are not handled correctly.

This is due to a wrong regexp, which replace only the first occurrence :

var defined_magic_sentinel_re = /defined_magic([a-zA-Z]\w*)_/;

should be

var defined_magic_sentinel_re = /defined_magic([a-zA-Z]\w*)_/g;

great library however...

E.g. "Witch's Scroll" is parsed the same as "Witch"s Scroll".

Needless to say, this subtly breaks a lot of things.

Example 1:

main.js:

pp.run(contentsOf('main.c'), 'main.c')

main.c:

#include "subdir/a.h"

subdir/a.h:

#include "b.h"  <---- attempts to access incorrect path;
                      include_func doesn't have enough context to resolve this on its own either

subdir/b.h:

(empty)

Example 2:

main.js:

pp.run(contentsOf('subdir/main.c'), 'subdir/main.c')

subdir/main.c:

#include "a.h"  <---- attempts to access incorrect path;
                      include_func doesn't have enough context to resolve this on its own either

subdir/a.h:

(empty)

Considering the prototype:

settings.include_func = function(file, is_global, resumer, error) {

However,