absolventa / emarsys-rb Goto Github PK

I verified that the credentials are correct, but am getting this error from Emarsys on every method call. Any ideas?

Hello,

It seems that the gem does not have a wrapper for deleting multiple contacts.
Would it be possible to add this feature?

Thanks

I noticed that the tested Rubies (https://github.com/Absolventa/emarsys-rb/blob/master/.travis.yml) all support keyword arguments, but they don't seem to be used.

While implementing #23, I thought it would be very handy to use as the list of required parameters for Emarsys::Email.export_responses is really long and the order is difficult to remember.

What do you think?

Received the following exception during Emarsys::Contact.update_batch

Emarsys::BadRequest
errorHTTP-Code: 500, Emarsys-Code: 1 - Database connection failed: timeout

Seems like it should be Emarsys::InternalServerError instead of Emarsys::BadRequest that should be raised right?

Gem version (0.3.3)

i couldn't find any reference pointing to this endpoint: http://documentation.emarsys.com/resource/developers/endpoints/email/unsubscribe-from-launch/

just wanted to check if it make sense to add this to the email data object, what do you think?

Right now the gem is configured via Emarsys.configure. That makes it impossible to use with different Emarsys accounts.

See e.g. http://www.justinweiss.com/articles/3-ways-to-configure-your-ruby-api-wrappers/ for a list of alternatives.

If we would go for an instance, I'd probably re-shuffle quite a bit and have an interface like this: emarsys_client.contact.create_batch().

Thoughts?

I noticed that there are no timeouts set so by default requests time out after 60s. It would be nice to configure this.

I thought about adding timeout options to the config, and then using the lower-level method RestClient::Request.execute(method: method, url: url, open_timeout: open_timeout, read_timeout: read_timeout).

Would you be willing to merge this? Then I'll wrap up a PR.

This commit: #9 breaks authorization for me.
I get Emarsys::Unauthorized: HTTP-Code: 401, Emarsys-Code: 1 - Unauthorized Time frame is invalid

Does it work for anyone? What's the point?

Hi

Is there any way to reduce the emarsys get and post call as it consume lots of time due to that application performance impacted even we put it into background?

When I call:

require 'emarsys'
Emarsys.configure do |c|
  c.api_username = ENV['EMARSYS_USERNAME']
  c.api_password = ENV['EMARSYS_PASSWORD']
  c.api_endpoint = ENV['EMARSYS_API_URL'] || 'https://api.emarsys.net/api/v2'
end

And then run a test command like Emarsys::Contact.search('3',['[email protected]']) it gives me an error saying Emarsys.api_username is not set. Am I missing something here?!?

In regards to #21, I was wondering how to expose the headers. Right now I see 2 issues:

1. I don't even get the headers from Emarsys as promised in http://documentation.emarsys.com/resource/developers/getting-started/rate-limiting/. response.headers is:

{:date=>"Wed, 01 Mar 2017 11:13:18 GMT",
 :server=>"Apache",
 :strict_transport_security=>"max-age=15552000; includeSubDomains; preload",
 :x_suite_response_time=>"53",
 :vary=>"Accept-Encoding",
 :content_encoding=>"gzip",
 :content_length=>"72",
 :content_type=>"text/html; charset=utf-8"}

2. Emarsys::Request always returns Emarsys::Response.new(response).result, so there is no way to access the response. I wonder if it would make sense to change this to return the response and not the data.

Any thoughts?