abridged / dao-help Goto Github PK

In the flow TRF ERC20 Token, node Contract Executor, the gas price is hard coded:

let overrides = {
    // The maximum units of gas for the transaction to use
    gasLimit: 800000,

    // The price (in wei) per unit of gas
    gasPrice: ethers.utils.parseUnits('8.0', 'gwei'),

};

As the average gas price on the network grew, I had to keep rewriting the value so that transactions for membership tokens would succeed relatively quickly. It would be easier if the gas price for this transaction (and perhaps other transactions?) was a global const. However, I'm not sure how this would interact with the other gas-related global constants, min_eth_for_gas_fee and gas_buffer

Ideally, the gas price would be determined by data from something like the Eth Gas Station API

In flow Contract Wallet Flow, function node Purchase Eth, the Wyre account ID is hardcoded on line 4:

wyreLink =  `${wyreLink}?destCurrency=ETH&dest=${msg.payload.user.account.fields.account_address}&accountId=AC_8MAWQ88LVEA`

Instead, it should use the global variable wyre_account_id:

wyreLink =  `${wyreLink}?destCurrency=ETH&dest=${msg.payload.user.account.fields.account_address}&accountId=${global.get('wyre_account_id')}`

In flow (Vote and New Proposal), function node Create Voting Proposal, the recipient of the transaction to start a new vote is hardcoded (to Collab19's TokenManager)

msg.payload.config = {
  "recipient" : "0x9231549259236b5A8C74A7B537308AcdC0d1fa3f",
  abi,
  "apiCall" : "forward",
  "args" : [_executtionScript],
  "value" : "0x0"
};

The address should be replaced with a new global param:

"recipient": global.get("address_token_manager"),

In the Mainnet/Kovan consts blocks the parameter queryProviderEndPoint is empty. It should either be set to a default provider in the code, or a step to fill this variable should be added to the documentation.

Have server running before Update functtionGlobalContext section