abostroem / code-review-aas241 Goto Github PK

allow for multi-line help in the --help. This will
be an argument in argparse.ArgumentParser() and you will likely need
to google around to see how you do multi-line.

allow for 3D FITS files. This should allow for a new -z option. The
default would be to pick a slice in Z and plot an image with imshow()
including a colorbar. Expanding on earlier options the vmin/vmax
allow you to pick a range to plot. It's also nice to think about
changing the colortable. Remember that now one can extract a profile
along X,Y,Z by picking two coordinates, or a plane, by picking one
coordinate. This option is involved, and could also involve splitting
up the work in parallel PR's after some initial design.

add more error reporting if the file is not a 2D image

allow a default screen output to be diverted to a plotfile (e.g. in
pdf,png,jpg etc.) so the script can be used in batch operations. We
used -plot to force that in an earlier example.

allow 1D plot for a non-orthogonal line (x0,y0) -> (x1,y0), instead of
the previously mentioned orthogonal. Either a new option could be
invented, or a trigger when both -x and -y are present with two
coordindate, eg. -x x0,x1 -y y0,y1 This is an example of overloading
options. Pro: fewer options Con: can be confusing, and harder to
program

report the name and shape of the file on the terminal output

to simplify the output, the new script should only allow one plot,
unlike the first demo, which allowed 3. See also #6 below for the
reason why. In batch use it's easier to call the script multiple times
instead of the complex way how multiple plots can be done from one
call.

add argparse to accept the fitsfile as a required, and a -x and -y
flags to trigger if a given column (-x) or row (-y), is to be
plotted. For now, just use one value, but one could also imagine
allowing multiple, i.e. -x 20,30,40, or even a range, -x 20:30. But
see below, as this may complicate other options.

allow the plotting range to be fixed via -vmin and -vmax. Either
can be supplied, or both.