abomb14c / game-time-bo Goto Github PK

• Game.blockCollision is pretty complex, consider making conditionals into their own variables
• Make the why (why are they doing array.splice here? What does that mean for the game?) of expressions (lines 144-147) more clear to a developer that does not know your codebase

The ball speed is funky when the level loads. The speed seems to be doubled on load, but not when the ball reloads after the user loses a life. Working on a few fixes will report back.

The paddle length that is removed upon the start of a new level doesn't erase until the user moves the paddle over it. Working on a fix will report back.

The block collision detection test isn't working how we think it should. Hope to discuss it during the eval.

• Test naming - be sure to include the action you're testing and the result
• Tests in Ball-test.js test more than one thing
• Test velocity explicitly in it should move test in Ball-test.js
• Nitpick: combine constructor parameter tests in Game-test.js into one test

Sad path testing, especially for the paddle to make sure it's not moving past the edges of the canvas.