aberonni / nightwatch-coverage

Coverage collection utility for nightwatch.js

Hi there, great to see you!

I'm Dom. Check out my resume to find out more about me.

nightwatch-coverage's Issues

error while running "execute" command

Nightwatch conf.js :

var browserstack = require('browserstack-local');

nightwatch_config = {
  src_folders : [ "tests/local" ],

  selenium : {
    "start_process" : false,
    "host" : "hub-cloud.browserstack.com",
    "port" : 80
  },
  custom_commands_path: [
    'node_modules/nightwatch-coverage/commands',
  ],
  globals_path: "globals.js",
  test_settings: {
    default: {
      desiredCapabilities: {
        'build': 'nightwatch-browserstack',
        'browserstack.user': process.env.BROWSERSTACK_USERNAME || 'BROWSERSTACK_USERNAME',
        'browserstack.key': process.env.BROWSERSTACK_ACCESS_KEY || 'BROWSERSTACK_ACCESS_KEY',
        'browserstack.debug': true,
        'browserstack.local': true,
        'browser': 'chrome'
      }
    }
  }
};

// Code to copy seleniumhost/port into test settings
for(var i in nightwatch_config.test_settings){
  var config = nightwatch_config.test_settings[i];
  config['selenium_host'] = nightwatch_config.selenium.host;
  config['selenium_port'] = nightwatch_config.selenium.port;
}

module.exports = nightwatch_config;

Test local

module.exports = {
  'BrowserStack Local Testing' : function (browser) {
    browser
      .url('http://bs-local.com:45691/check')
      .waitForElementVisible('body', 1000)
      .assert.containsText('body', 'Up and running')
      .collectCoverage()
      //.end();
  }
};

coverageMap is not an instance when using multiple test suites

Using nightwatch '1.5.1' or '1.7.13', I was getting timeouts errors due to crash in afterEach (browser.globals.coverageReporter.coverageMap.merge undefined)

It seemed that coverageMap was a POJO when calling browser.collectCoverage (either during tests or during global afterEach).

to work around that, I set persist_globals to true, which did nothing, and ended up using a global beforeEach to restore the instance

        beforeEach(browser, done) {
            // fixes coverageMap not being the expected class instance
            browser.globals.coverageReporter.coverageMap = coverageReporter.coverageMap;
            done();
        },

I'm not too sure if that was expected to work out of the box, or is broken by some context, or if some version of nightwatch broke it.