abeelen / astrolibpy Goto Github PK

Hi, I don't know if you use 'readcol' much in its current form, but if
you're interested I've found that this version of the code is pretty fast
and I believe it's robust:

http://casa.colorado.edu/~ginsbura/pyreadcol.htm

Adam

What steps will reproduce the problem?
1. Run mpfit.py

What is the expected output? What do you see instead?
Works at the moment but with 'FutureWarning'

What version of the product are you using? On what operating system?
Latest mpfit, AFAIK.  OS X 10.8.5 Enthought Canopy 64 bit Python (latest)

Please provide any additional information below.
Message says:

......./mpfit.py:1965: FutureWarning: Numpy has detected that you (may be) 
writing to an array returned
by numpy.diagonal or by selecting multiple fields in a record
array. This code will likely break in the next numpy release --
see numpy.diagonal or arrays.indexing reference docs for details.
The quick fix is to make an explicit copy (e.g., do
arr.diagonal().copy() or arr[['f0','f1']].copy()).

This line:
https://code.google.com/p/astrolibpy/source/browse/mpfit/mpfit.py#1206
should be 
whmax = (numpy.nonzero((qmax[ifree] != 0.) & (maxstep[ifree] > 0)))[0]


In current form, if any (but not all) parameters have a specified max step size 
and any are fixed, the wrong max step size will be used in the mrat check below.

It seems that using mpfit, with "autoderivative=0" keyword, is not possible to 
run mpfit  properly.  I get always an error:

1) if in my function (as suggested in the header comments of mpfit.py) I return 
"[status, (y-model)/err, pderiv]",  the function fdjac2 say "ValueError: too 
many values to unpack". This is right because in fdjac2 it is expected to get 2 
arrays (and not 3).

2) if in my function I return "[status, pderiv]",  fdjac2 say " ERROR: 
Derivative matrix was not computed properly."  This is also right because the 
fdjac2 condition: 
"if len(fjac) != m*nall:" 
cannot be never reached.

So my question is: how use properly mpfit with autoderivative=0 ?
Is there an (explicit) example on how to use it?