abdoafage / udemy-react-clone-2

To Run App :

first cmd

cd src/DATA
json-server --watch DATA.json

second cmd

npm start

udemy-react-clone-2's Issues

name more descriptive component names

Udemy-React-Clone-2/src/component/SingleCoursePage/PageComponent.js

Line 14 in 800808d

function PageComponent({ courseSelect, review_content }) {

why is every component surrounded with curly brackets

Udemy-React-Clone-2/src/component/SingleCoursePage/PageComponent.js

Lines 17 to 28 in 800808d

	<WhatLearn />
	{<CourseContent curriculum_context={review_content.curriculum_context} />}
	{<Requirements requirements={review_content.details.Requirements} />}
	{
	<Description
	description={review_content.details.description}
	forWho={review_content.details.for_who}
	/>
	}
	{<Instructors instructor={courseSelect.instructors} />}
	{<StudentFeedback />}
	{<Reviews reviews={review_content.reviews} />}

naming convention inconsistency

Udemy-React-Clone-2/src/component/SingleCoursePage/SingleCoursePage.js

Lines 19 to 22 in 800808d

	const [courseSelectInfo, setCourseSelectInfo] = useState(null);
	const [courseSelect_review_content, setCourseSelect_review_content] =
	useState();
	const { nameOfCourse, id } = useParams();

final rubric

• the courses data is fetched only once when the app start
• clicking on any course’s card opens the course’s page (infinite loading)
• the ui design looks exactly as the attached screenshots.
• loading spinner is shown while the courses are being fetched
• the search function works as described. (not working when I try to search)
• tabs bonus
• carousel bonus (it's stuck and won't slide)