abapgit / ci

Tool to run abapGit continuous integration tests, testing of abapGit itself

abapGit CI backend

Latest build: https://ci.abapgit.org

This repo provides basic continous intergration capabilities for abapGit.

For details, see the abapGit Development Documentation.

ci's Issues

add total execution time to result

run CI for open PRs

test/response.json

can file test/response.json be deleted?

Syntax error in zcl_abapgit_ci_repos

Refactoring in abapGit renamed method set_branch_name

PR on way, but I can't create a branch or assign myself. Will do via fork.

Implemented interface "ZIF_ABAPGIT_GUI_FUNCTIONS" not found(implement_methods)

error after abapGit/abapGit#5172 was merged to abapGit

Check leftovers after purge

After purge there shouldn't be any leftovers

no use of injectors

All abapGit APIs should at some point work without requiring GUI, if not it has to be changed/fixed.

So there should be no use of injectors in this project

links

was thinking to link these to their github repos,

Check objects after pull

After the pull we should somehow check whether the objects are deserialized and activated properly. Currently we do only a syntax check in the repo.

e.g. call for each object methods

• exists
• is_active

Add support for deserializing data tables

Case 1

https://github.com/abapGit-tests/TABU_custom_table

Requirements:

• Create customizing transport and pass to repo pull
• Bypass confirmation popup during deletion (zcl_abapgit_object_tabl->zif_abapgit_object~delete)

Case 2

https://github.com/abapGit-tests/TABU_sap_table

Requirements:

• Inject support for SAP tables (zcl_abapgit_user_exit->zif_abapgit_exit~change_supported_data_objects)

Clone and pull repos into transportable packages

Currently we clone and pull only in local $ packages. We should add a option to clone into transportable packages and then check the transport request. It should contain all deserialized objects. Maybe also releasing the transport and purge with a new one.

Handle LIMU <-> R3TR conversion in transport checks

Going from top to bottom the first error is that the transport only contains the LIMU REPS object ZAAAGIT_TEST, while the check expects R3TR PROG ZAAAGIT_TEST.

I would have expected that the first creation of an object uses the "full" object in the transport with R3TR and only subsequent transports use the subobjects with LIMU.

Easiest fix would probably be to just convert every LIMU object to its R3TR parent before comparing with abapGit items.

Add check for dumps

Check if any dumps occurred during runtime of CI job

Run unit tests after updating abapGit

Implement ZIF_ABAPGIT_CI_REPO_PROVIDER for https://dotabap.org/

in the SAP Community Q&A post SAP sponsored check of OpenSource ABAP Projects with Code Vulnerability Analyzer we've born the idea to get an automated security check for all projects listed in https://dotabap.org/. I've just checked how abapGit CI does currently get the projects in the Organization abapGit-tests. This is implemented in the class ZCL_ABAPGIT_CI_TEST_REPOS which implements the interface ZIF_ABAPGIT_CI_REPO_PROVIDER. And this class is then used in the report ZABAPGIT_CI to provide the list of repositories to zcl_abapgit_ci_controller.

Should I simply go ahead and do the following:

• implement a class ZCL_ABAPGIT_CI_DOTABAP_REPOS that reads the repositories from https://raw.githubusercontent.com/dotabap/dotabap-list/master/list.json and returns the repositories as needed.
• Adjust the report ZABAPGIT_CI to provide a select option where the implementation classes of ZIF_ABAPGIT_CI_REPO_PROVIDER can be provided. Fill that select option by default with ZCL_ABAPGIT_CI_TEST_REPOS so the current users of ZABAPGIT_CI don't see any difference.
• Use the input from the select option run zcl_abapgit_ci_controller multiple times if needed.

?

Add test repos for ABAP Language Version

Current tests at https://github.com/abapGit-tests use "ABAP Language Version = Any" which is the default

To-Dos:

• Add test repo for ABAP Language Version = Standard
• Add test repo for ABAP Language Version = Key User
• Add test repo for ABAP Language Version = Cloud Development
• Test CI process with above repos

move documentation to https://docs.abapgit.org/development/ ?

move documentation(the readme) to https://docs.abapgit.org/development/ ?

Add check for system- and user-specific data

CI should check for system- or user-specific data (sy-sysid, sy-mandt, sy-uname, ...) meaning serialized data shall not contain this type of metadata (in the xml).

add statistics to result (total, successful and failed)

Also consider syntax errors in the CI itself

if the abapGit API changes, it might break the CI

suggest:
1: pull the latest CI version
2: check the CI code for syntax errors
3: as is

visibility for skipped tests

can we somehow make it visible in the overview what tests are skipped, currently they are not shown on https://ci.abapgit.org

add links to github repo to result page(s)

Add support for repos using LXE

abapGit/abapGit#4470

Test repos:
https://github.com/abapGit-tests?q=lxe

ZABAPGIT_CI stalls with WP Status: "On Hold", Info: "RFC Response" in background mode

I've started the CI process using ZABAPGIT_CI_JOB_SCHEDULER. But ZABAPGIT_CI doesn't finish. In SM50 I see WP Status: "On Hold", Info: "RFC Response":

Running the ZABAPGIT_CI in foreground doesn't bring up any dialog boxes and returned this result:

Syntax error

Might be similar to abapGit/abapGit#5565

Report crashes, see

also run normal unit tests?

Push results to slack channel

Check for leftover enqueue locks

CI shall check after the pull and purge phases that no enqueue locks exist

Skip on higher version required

Something like https://github.com/abapGit-tests/BDEF will require SAP BASIS 773.
This will be specified in the .abapgit.xml, and as normal abapGit will check version requriements.
In case a higher version is required, the CI should skip the repo.

Parameter in ZABAPGIT_CI report to control the purge

Using ZABAPGIT_CI is a great way to install quickly all abapGit supported development artefacts. But as quickly as their installed, they are also deleted (purged). That is triggered in the RUN method of ZCL_ABAPGIT_CI_REPO.

What do you think about a parameter in the ZABAPGIT_CI report to control the purge. I.e.:

[ ] Don't purge the installed packages

Check abapGit latest build

Fetch the abapGit report and check syntax