aafanasev / kson Goto Github PK

Now generated code looks like this:

private val adapter by lazy { gson.getAdapter(...) }

Since the evaluation of the delegated properties is synchronized and it's redundant in TypeAdapter case, need to use LazyThreadSafetyMode.NONE mode, which doesn't incur any thread-safety guarantees and the related overhead.

@Kson
data class UserEntity(
    val firstname: String, 
    val lastname: String
)

// generated code
...
private val firstnameAdapter by lazy { gson.getAdapter(String::class.java) }  
private val lastnameAdapter by lazy { gson.getAdapter(String::class.java) }  
...

As you see, each property will have it's own adapter. I think better to have adapters grouped by types, f.ex:

private val stringAdapter by lazy { gson.getAdapter(String::class.java) } 

and use this adapter in both properties

Can't find import javax.annotation.Generated

gson-extras has such class: https://github.com/google/gson/blob/master/extras/src/main/java/com/google/gson/typeadapters/RuntimeTypeAdapterFactory.java which is helpful for polymorphic types serialization without reflection.

For example, it can be used to handle Kotlin sealed class serialization:

sealed class Shape {
        class Rectangle() : Shape()
        class Circle() : Shape()
}

val adapter: RuntimeTypeAdapterFactory<Shape> = RuntimeTypeAdapterFactory.of(Shape::class.java)
        .registerSubtype(Rectangle::class.java)
        .registerSubtype(Circle::class.java)

And then in your gson instance builder:

registerTypeAdapterFactory(adapter)

However, seems it is a boilerplate and not safe solution to write such factory for every sealed class in the project. Would be nice to handle it with annotations like kotlinx-serialization does with polymorphic serialization problems: https://medium.com/@andreclassen1337/goodbye-runtimetypeadapterfactory-polymorphic-serialization-using-kotlinx-serialization-46a8cec36fdc

@Polymorphic
sealed class Shape {
        @SerialName("Rectangle")
        class Rectangle() : Shape()
        @SerialName("Circle")
        class Circle() : Shape()
}

https://docs.gradle.org/nightly/userguide/java_plugin.html#sec:incremental_annotation_processing