aadsm / node-id3

Get music metadata from buffers and files.

This project is the work of Tim Smart and is a derivative work of JavaScript-ID3-Reader.

Tim Smart's repository doesn't have an issues section anymore and I have no intention to maintain or continue the work on this derivative project because I do not have the time to maintain a different fork.

I would like in the future to add node support to JavaScript-ID3-Reader but unfortunately time has been an issue, pull requests are more than welcomed though.

node-id3's Issues

Get picture for .mp3

I can get the picture for .m4a files. However it seems that getting picture for .mp3 doesn't work.

id3_3v2.get('picture')

returns null

Did I miss something?

Set Tags

I've only just landed on this and I need to be able to read tags but also set them. My use case is for an admin tool for a church to be able to upload their recordings (so no copyright issue) and I want to programatically set the tags based upon the details entered.

Is this:

1. currently possible?
2. possible with code change (I don't mind making changes via forks and pull requests)
3. not possible

Possible copyright infringement

[Since my original issue was closed and github issues were removed from the original project I repost this open issue here, this fork only exists as proof of the following statements]

I've noticed the huge similarities between your library and my JavaScript ID3 Reader library (https://github.com/aadsm/JavaScript-ID3-Reader).
In fact they are so similar that it leads me to believe that node-id3 is a copy of my repository with some name changes and no reference to the authors at all.

Take these two functions as examples:
readFrames:
Mine: https://github.com/aadsm/JavaScript-ID3-Reader/blob/master/src/id3v2.js :
Yours: https://github.com/Tim-Smart/node-id3/blob/master/lib/id3/id3v2.js

readUTF16String (this one even has the exact same variable names):
Mine: https://github.com/aadsm/JavaScript-ID3-Reader/blob/master/src/stringutils.js :
Yours: https://github.com/Tim-Smart/node-id3/blob/master/lib/id3/common.js

Another piece of evidence:

My shorcuts structure:
var _shortcuts = {
"title" : ["TIT2", "TT2"],
"artist" : ["TPE1", "TP1"],
"album" : ["TALB", "TAL"],
"year" : ["TYER", "TYE"],
"comment" : ["COMM", "COM"],
"track" : ["TRCK", "TRK"],
"genre" : ["TCON", "TCO"],
"picture" : ["APIC", "PIC"],
"lyrics" : ["USLT", "ULT"]
};

Yours:
var ID3v2_ALIAS = exports.ID3v2_ALIAS = {
"title" : ["TIT2", "TT2"],
"artist" : ["TPE1", "TP1"],
"album" : ["TALB", "TAL"],
"year" : ["TYER", "TYE"],
"comment": ["COMM", "COM"],
"track" : ["TRCK", "TRK"],
"genre" : ["TCON", "TCO"],
"picture": ["APIC", "PIC"],
"lyrics" : ["USLT", "ULT"]
};

If you did in fact based your work on the JavaScript ID3 Reader library, please be reminded that it is (some parts of it) copyrighted by Opera Software ASA, under the MIT/BSD license and it requires proper attribution to the authors.

Thank you.

Correct attribution needed

I've noticed the huge similarities between your library and my JavaScript ID3 Reader library (https://github.com/aadsm/JavaScript-ID3-Reader).
In fact they are so similar that it leads me to believe that node-id3 is a copy of my repository with some name changes and no reference to the authors at all.

Take these two functions as examples:
readFrames:
Mine: https://github.com/aadsm/JavaScript-ID3-Reader/blob/master/src/id3v2.js :
Yours: https://github.com/Tim-Smart/node-id3/blob/master/lib/id3/id3v2.js

readUTF16String (this one even has the exact same variable names):
Mine: https://github.com/aadsm/JavaScript-ID3-Reader/blob/master/src/stringutils.js :
Yours: https://github.com/Tim-Smart/node-id3/blob/master/lib/id3/common.js

Another piece of evidence:

My shorcuts structure:
var _shortcuts = {
"title" : ["TIT2", "TT2"],
"artist" : ["TPE1", "TP1"],
"album" : ["TALB", "TAL"],
"year" : ["TYER", "TYE"],
"comment" : ["COMM", "COM"],
"track" : ["TRCK", "TRK"],
"genre" : ["TCON", "TCO"],
"picture" : ["APIC", "PIC"],
"lyrics" : ["USLT", "ULT"]
};

Yours:
var ID3v2_ALIAS = exports.ID3v2_ALIAS = {
"title" : ["TIT2", "TT2"],
"artist" : ["TPE1", "TP1"],
"album" : ["TALB", "TAL"],
"year" : ["TYER", "TYE"],
"comment": ["COMM", "COM"],
"track" : ["TRCK", "TRK"],
"genre" : ["TCON", "TCO"],
"picture": ["APIC", "PIC"],
"lyrics" : ["USLT", "ULT"]
};

If you did in fact based your work on the JavaScript ID3 Reader library, please be reminded that it is (some parts of it) copyrighted by Opera Software ASA, under the MIT/BSD license and it requires proper attribution to the authors.

Thank you.