a-tarasyuk / eslint-plugin-resub

ReSub specific linting rules for ESLint

---

👉 Buy Me a Coffee ☕

eslint-plugin-resub's Issues

OverrideCallsSuper is too aggressive

Currently, overrideCallsSuper test for any function, that is called like the Lifecycle method, eg. 'componentDidMount'.

Now I want to create a React.Component, or React.PureComponent, beacuse there is no State.
The Problem here is, that all Lifecycle Methods are typed as possibly undefined:

    interface ComponentLifecycle<P, S, SS = any> extends NewLifecycle<P, S, SS>, DeprecatedLifecycle<P, S> {
        componentDidMount?(): void;
        shouldComponentUpdate?(nextProps: Readonly<P>, nextState: Readonly<S>, nextContext: any): boolean;
        componentWillUnmount?(): void;
        componentDidCatch?(error: Error, errorInfo: ErrorInfo): void;
    }

This leads to Type errors, if on tries to use them by e.g. calling super.componentDidMount().

Suggestion:
Aply rule only to Classes, that extend ComponentBase.