The datetime-scopes from 907th

View Code? Open in Web Editor NEW

A plugin for ActiveRecord which adds very helpful methods for querying records over time ranges (weeks/days/months/years), and it also respects time-zones!

License: MIT License

Ruby 100.00%

datetime-scopes's People

Stargazers

Watchers

datetime-scopes's Issues

Usage of prepositions in scope names

Hi,

As I see, there are some date and time related scopes like these ones:

created_on_day(t)
created_on_month(t)
created_on_year(t)
...
created_on_or_before(t)
created_on_or_before_day(t)
created_on_or_before_month(t)
created_on_or_before_year(t)
created_on_or_after(t)
created_on_or_after_day(t)
created_on_or_after_month(t)
created_on_or_after_year(t)

Problem with scope names is that preposition "on" should be used with days and dates only. The better way to name these scopes, IMO would be:

created_on_day(t)
created_in_month(t)
created_in_year(t)
...
created_at_or_before(t)
created_on_or_before_day(t)
created_in_or_before_month(t)
created_in_or_before_year(t)
created_at_or_after(t)
created_on_or_after_day(t)
created_in_or_after_month(t)
created_in_or_after_year(t)

Anyway, it'd be better to ask native speaker to review scope names.

Recommend Projects