7sat / dynamicshop3 Goto Github PK

When you click "add all" on the 2nd page of a shop, the items go to the 1st page

The hook for slimefun (It is like the MMOitem or itemadder)
check nbt and CustomModelDate of item
link: https://github.com/Slimefun/Slimefun4/blob/master/README.md#floppy_disk-download-slimefun-4

Minecraft version
1.18

Plugin version
3.65

Describe the bug
Not a bug,just a suggestion .let the icon support player-head or custommodeldata.The menu can be made more beautiful.

Or make the shop's close-button can open my custom menu which made by other plugins
To Reproduce
Null

Expected behavior

Hello i want to ask about the linking shops

How does they work?

IF i combine a with b
and i sell at A (a decreases)
will B increase?

If yes okey ignore this, if no could we add this? Its a perfect way to give "bad shops" like finishing shop better prices

It would be better if you could have one permission to generally be able to open the "Start Page" (/shop) instead of letting the players open the main shop menu and then having a permission per Shop...

After heavy usage of an item shop, it can "bug out", causing you to be unable to buy/sell items from the menu until reopening the trade window. This is shown in the clicking on an item and it turns to a black glass pane.

No errors are shown if this happens.

https://i.imgur.com/7qLbWFE.gif

I would be absolutely awesome if it was possible to be able to set a sales tax per item instead of one global one :)

Minecraft version
1.18.1

Plugin version
3.5.0

Describe the bug
When you edit an item in the Shop, but instead of saving it, close it, it opens the item palette instead of closing and going back to the Shop you were before

To Reproduce
/\

Expected behavior
/\

As I said in the title, I create the sign shop according to the config but it does not function on right click. All that happens is the shop title goes green and [ds] disappears.

Using latest version (2.11.8) with Paper. Let me know if you need any more info.

Is it possible to improve the lang customisation for DynamicShop? For example, I am currently unable to remove lore from items such as the exit button. I am also unable to customise some buttons fully, such as the page change button (can only change the "Page" part of the name, making the page number colour inconsistent).

SpigotMC.org is being extremely slow right now so my server cannot start with this plugin installed. Please check for updates on another thread, not the main one.

The comment # Shop name can not contain formatting codes, '/' and ' ' is duplicated in the Shop.yml file

Please add nbt tag

I would like to make improvements to recent changes to colors of arrows, we are able to change them, but this is not how we wanted to get it changed.

Explanation:

Lets say we got diamonds in our shop which median is 100 and stock is 100. Tax are 0%. This will be without arrows which is correct. But, when we will buy lets say 10 diamonds, the prices will change and arrows will appear. Arrows colors will appear kinda wrong, let me explain why.

Buy for 110 - (this will appear as RED arrow) - which is right, its red beacuse this item is more expensive than normal.
Sell for 110 - (this will appear as RED arrow) - this is not right, its red because its.. more profitable to sell? Dont think so :P The arrow should be GREEN for sure

Then, we will sell 20 diamonds to shop, so we will get prices like this -

Buy for 90 - (This will appear as GREEN arrow) - which is RIGHT! Its green, because you will save 10 money for this than normal.
Sell for 90 - (This will appear as GREEN arrow) - which is NOT right, its green because of what? .. you can sell less? doesnt make sence. This arrow should be definitely RED.

I hope you understand it :) (Sorry for my bad english tho)

PS. This plugin should be premium, its really good, easy to use and set up, players are really enjoying price values rising and going down, so they will make more profitable shoping when .. you know, items get cheaper or more expensive :)

The Log files are empty.

Minecraft version
1.19 Paper

Plugin version
DynamicShop Premium v3.110.6

Describe the bug
Shop restocking is not working properly. It stops working on its own entirely, possibly upon restart (uncertain).
Turning stock stabiliziation off and back on fixes it temporarily (at least on short interval, uncertain about longer interval).
Could apply to stock fluctuation as well?
Prices on our server have been crashing hard and it is quite tedious to have to retoggle price recovery each day.

To Reproduce
Turn stock stabilization on.
Restart server.
= Stock no longer recovers.

Expected behavior
Stock stabilization continues normally, even after restart, as on older version.

I have the same issue:
https://pastebin.com/iku26CxN
This is the first install of the plugin and it fails when trying to open a shop.
Config.yml(Default): https://pastebin.com/tfwShV7c
Shop.yml(Default): https://pastebin.com/CquG6mgk

About 10% of the time that players open the shop menu, I get this error. Nothing wrong happens however the console spam is a lot. Reporting here as IllegalStack doesn't do this with other gui plugins.
stacktrace

Hi,

This plugin is broken in the latest paper version. You cannot use this plugin at all with the latest version as you can take items from the shop menu out like a normal chest.

Reproduce:

1. Install GemsEconomy and SSDynamicShop
2. Set currency in GemsEconomy
3. Buy something you can't afford
4. ...
5. Profit! (Incorrect currency displayed)

Versions:
Gemsconomy: 4.8.3
SSDynamicShop: 2.10.5

When I do /shop, an internal error occurs and I'm unable to perform the command. No GUI pops up. Plugin seems to be unusable. Is there something I'm missing here?

Pastebin link to my latest.log, showing the error : https://pastebin.com/sDwBegTg

Let me know if you need anything else to troubleshoot this, cheers.

when setting these ingame it will put &f in front of it making icons and actions unusable

Minecraft version
1.18.1

Plugin version
3.5.0

Describe the bug
When you add an item with the item palette to a Page in a Shop, the item goes to the 1st page of the Shop instead of the page you selected.
So basically issue #61 but with single items...

To Reproduce
/\

Expected behavior
/\

Currently, DynamicShop allows purchasing of items. However, I also wish to sell 'commands' (for example, selling items from other plugins that are gained using commands; selling mcMMO experience; selling XP; etc). Currently, I am needing to use a separate plugin for this.

Could you add API for getting stocks and prices. I want to log those and display them in graphs on my website.

Stuff such as
List<ItemStack> shopItems = DynaShopAPI.getItems(); int price = DynaShopAPI.getPrice(ItemStack item); int stock = DynaShopAPI.getStock(ItemStack item); int median= DynaShopAPI.getMedian(ItemStack item);
etc.

Thanks in advance!

Hello, I'm the developer for the SellStick plugin on Spigot.

Some users requested that I hook SellStick in with DynamicShop, such that when they use a SellStick item, the transaction will go through the DynamicShop.

I looked through the API, and noticed that there was a way to get the SellPrice for an item, but not a way to sell an item.

In other words, I would like to be able to call a method with a similar signature to this:

    /**
     * Sells an item via DynamicShop and returns the sellPrice
     *
     * @param itemStack The itemStack to sell/
     * @returns the price the itemstack was sold for.
     */
    public static double sellItem(@NonNull ItemStack itemStack) {
                 // Checks to see if this item exists in any shops
                          // if exists,
                                   //sell item
                                   //return sell price
                         // else
                                  // throw some Exception, or return -1
    }

Even better would be if the method accepted an array of ItemStack objects so a chest, for example, could be sold in one cal to the API. But either would be fine.

If I have some time I may try to understand the plugin a bit better and submit a PR.

Thanks for the consideration.

Items in offhand contribute to money, but aren't sold when using quick sell. This means that people can sell items without the items being taken away, and are able to very easily earn tons of money with no effort.

Hi, I would love a feature where you can have a "Wand" to right click a chest and sell all of it's contents (that exists in d-s) to dynamic shop.
Or use the Quick sell feature to bind to an item in config, that could sell everything form a chest when you right or left click it.(Can be optional in config)

It is best to use /ds to let other players open the store
I want to get an entity interactive command that says [DShop] You can't run this command in console

it seems to me that it will be better if you change the colors of the percentage increase in price (decrease in price) "⬆%" . if the price is higher than the established one, then it is profitable to sell to the store (green interest), but not profitable to buy (red).
if the price of the product is lower than the established one, then it is profitable to buy (green) but not profitable to sell (red).
or help me compile the plugin (in which I will change it myself) (if so, I will send the errors that occur when trying to compile)

As the image shows below. The plugin is generating a load of log fyml files but they arent even put in the "Log" folder and they are blank as well.

I changed 'SELLPRICE' to something, but it shows 'Sell'.

Hey there! Doing this with dynamic stock will allow anyone to get whatever amount of money they want.

1. Get a good amount of money. Like really, you'll need alot
2. Find an item with a good price:stock ratio. We want something like an expensive sword. If it's less than ~100 in stock, buy all of them. This is sad, but one time investment for exploiting the bug
   2.1) I.e we used sword with 100 as median and 5000$ as price
3. Buy them all until stock = 1
4. Sell one sword
5. Buy one sword
6. Go to step 4. Repeat until enough of money. If you gain nothing, try a more expensive item.

Less expensive, less effective Proof-Of-Concept (also a ready to work exploit, btw). Works on default config if you have enough time to buy all cobblestone by selling dirt: https://youtu.be/PhLXbXTJo-8

If an item has very little stock (5 median, tax 0%, buy and sell price the same) and you buy one, then sell it. You will make money

SERIOUS GAME ECONOMY BREAKING ISSUE ......(PUGIN IS NOT USABLE)......

This plugin has been broken for several months with CMI Vault economy which I posted previously in discord, and am posting again here.

This issue appears related to issue #2

I have recently discovered a major disconnect between CMI-Vault Economy and DShop. (I have been running DShop and CMI on my dev server for 9mo w/o issue until recently. (I suspect over the past few months is when things broke)

Example 1)

• Player starts with $0 balance
• Use /cmi money give 10000
  -- Player types /bal (balance is $10,000 great)
• Next player goes to a DShop and tries to buy something (DShop says you have insufficient balance $0)

Example 2)

• Player starts with $0 balance
• Player goes to DShop and sells a ton of stuff
  -- Player has $1,000 in the shop
• Player goes to another DShop and can buy items with his $1000
• Player types /bal (balance is $0)

Hi, I'm getting lag spikes from this plugin: https://spark.lucko.me/#pU0sSpVpYk. I believe it is when the user flat file gets large.

1. There is a report that yml data is lost when the capacity of the server computer is full.
2. Directly modifying the shop yml is extremely dangerous. If the plug-in fails to read data from the file, the entire contents of the file are lost.

Put armour in the shop, for a price, plus a sell price.

A player buys the armour, decides to sell it, no durability taken off, can not sell it, does not read the armour as being the same item?

Hi I am trying to add database functionality into the plugin and wanted to compile/build the project using maven like you did.

But when I tried I am getting this error.

[ERROR] Failed to execute goal on project DynamicShop: Could not resolve dependencies for project me.sat7:DynamicShop:jar:2.11.8: Failed to collect dependencies at me.clip:placeholderapi:jar:2.9.2:

Could you help me out here, cause I think the git repo might be missing a settings.xml or smth else to not get this error on compiling your code.

Minecraft version
1.19.3

Plugin version
3.9.0

Describe the bug

To Reproduce
Add an item with lore

Expected behavior
Keeps the lore

Would also be nice if we could have more customization like adjusting the format, where it displays the item lore first, and have everything after, as well as changing around the GUI. Also possible to add player heads support from minecraftheads? Thanks!

It would be really nice if the "Item Palette" could be sorted to for example only display Blocks, Food or Armor

This would make the "Add All" Function a lot more useful

Hello, first of all i'm really interested in the good developpement of the plugin, good idea with good features, but sadly my server is on 1.13.2 and based on my console, the usage of the oak_sign is hardcoded, but it didn't exist in 1.13.2 so it crash.
Is it possible to put the material in the config, or at least using generic material and checking the version, thx for all.

When you first set an Icon for something in the Main Shop Menu and then link a Shop to it, the item Icon goes back to the default (Emerald)
This can be a bit annoying when setting up Shops

I am the developer of the plugin Reserve, a modern economy API with modern economy features in mind. As I am now ready to publicly push the API, I'm currently looking for developers to add support for it.

Link: https://github.com/TheNewEconomy/Reserve

Advantages over Vault:

• Multi-currency support
• Async support using Java's completeable futures
• Optional Extended API to allow third party plugins to add new currencies

Current Plugins that support Reserve:

• Towny
• ChestShop3
• MineBay

Current Providers/Planned Providers:

• The New Economy
• Towny Eco

Thanks in advance,
creatorfromhell

See the above title - currently, adding skull data to the StartPage.yml does not change the button item (however, it does work when editing items within a shop).

Below is the text I tried to use in StartPage.yml:

  icon: PLAYER_HEAD
  itemStack:
    ==: ItemMeta
    meta-type: SKULL
    internal: H4sIAAAAAAAA/+NiYOBgYPJMYVAxNzJOsTA1N9c1SEox1jVOTDbXTTJITtE1MTGyMLYwTzIxMkhmAAAapQSXLwAAAA==
    skull-owner:
      ==: PlayerProfile
      uniqueId: 723d8577-0bd3-3ac7-b0cd-4428387b420c
      name: Enqie
      properties:
      - name: textures
        value: ewogICJ0aW1lc3RhbXAiIDogMTY1MTU4MDYwNTE2OCwKICAicHJvZmlsZUlkIiA6ICJkNmZlODBhOWMyNjA0YjRlOGY0NTRhYjBhZWIzOGNhNyIsCiAgInByb2ZpbGVOYW1lIiA6ICJFbnFpZSIsCiAgInNpZ25hdHVyZVJlcXVpcmVkIiA6IHRydWUsCiAgInRleHR1cmVzIiA6IHsKICAgICJTS0lOIiA6IHsKICAgICAgInVybCIgOiAiaHR0cDovL3RleHR1cmVzLm1pbmVjcmFmdC5uZXQvdGV4dHVyZS80ZmYxMzNhY2FkYjQ2NDUyYWUxZjczNDAyNWU0ZjNmZGRjZTYxMzg1ZTU2NjRkNzI5N2FhOTY1NTdlZGMzYzVlIiwKICAgICAgIm1ldGFkYXRhIiA6IHsKICAgICAgICAibW9kZWwiIDogInNsaW0iCiAgICAgIH0KICAgIH0sCiAgICAiQ0FQRSIgOiB7CiAgICAgICJ1cmwiIDogImh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvMjM0MGMwZTAzZGQyNGExMWIxNWE4YjMzYzJhN2U5ZTMyYWJiMjA1MWIyNDgxZDBiYTdkZWZkNjM1Y2E3YTkzMyIKICAgIH0KICB9Cn0=

When i click a item to buy or sell and press the close button it vanish, and the only way to exit shop is to close window.

The logging the plugin currently does is a bit useless and weird...it doesn't even show if the item was bought or sold, how much was sold/bought, and you have no possibility to find out if a player is for example selling a ton of duped items...you would have to manually check every log file all the time to find out such things.

It could be improved by showing if the item was bought or sold.
It could also log how much was bought or sold (e.g. 64)

Also, it would be extremely helpful (for smaller servers at least, big servers would probably have too much console spam then...) to see the player's purchases live in the console, without needing to manually check the log file (With a config option to disable/enable).

I also think that some logging it does is unnecessary:
-The coordinates of the player where he purchased the item...what use does that have?
-That vault was used...what use does that have?
-The date of the transaction, because the file itself already has the date on it.
Maybe could have its own config options to decide what you want to log and what not? An example to show what I mean:

Currently, logs look like this:
04-03-2022-23-24-16,MELON_SLICE,-64,147.24,vault,PLAYER_NAME
This could be changed to:
23-24-16,MELON_SLICE,AMOUNT,PLAYER_NAME
if the server owner wants to :)

The live console log could be very simple and could look something like this:
PLAYER_NAME bought/sold ITEM AMOUNT as you already have the time of the message in the console...

I want to switch a shop page but that's not a feature. Also the way the config is managed it's hardly possible to do it manually.

Thanks in advance