4slimbu / limbook-api Goto Github PK

An issue occured where all tests passed using sqlite but failed on production.
Friend.is_friend == 1 in one query passed for sqlite but failed for postgres due to boolean field constraint.

To prevent such issues. Production and Test environ should be as similar as possible

If you look at the permission testing for any route, you can see that its testing permission from the token. We need to mock permission so that we can see against which permission we are testing.

I am seeing payload.get('sub') in a lot of places. Its time to extract it to its own method that returns the user_id and throws 401 otherwise.

• Right now resource is returning all items. We need to return around 10 items (the no. of items to return need to be configured from the config).
• use the query parameter to achieve this

Functions to generate post, comment and react for testing or automation purpose is generating post_id and user_id using rand_int which cannot be linked to Post or User object. If it can be linked to Post or User object, then it can be really helpful in seeding purpose.

As of now model.py has all the Models. It can be divided into smaller models for each package.

When I right click the test directory and run tests, it doesn't find test. However, If I right click the test file and run test, it works.

Not sure but may be:

• migrations and seeds should be inside limbook_api directory
• packages like posts, comments etc can be organized into package directory or modules

Use pivot table between user model to achieve the result.

• May be use redis or memcache

Always returns bad request

For each user there should be an activity log:
e.g:
Table schema:
id, user_id, activity, created_at
Activity can be json like:
{ activity: "commented", "post_id": 1, "post_title": "my post"}

• post_title is useful in case of delete where post is unavailable.
  enum: commented, reacted, created, updated, deleted

• User should be able to react and reply to comments
• The reply to comments should be only one level nested

• Post should have visibility: private, friends, public

As of now tests have redundant functions and variables. A base test class can be created to organize those things.

Right now other than model, everything is function based.
Transform the code to OOP

• User should be able to send private message to other user
• There should be two copies of message for sender and receiver
• User should be able to delete their copy of message
• User should also be able to delete message they sent from receiver copy
• May integrate AI reply

• Can implement third party service like Pusher
• Better, if can implement own web-socket server to handle push notification
• User should receive notification when someone interact with their post or send them message

Instead of saving images locally, saving it on s3 is a better choice

sqlalchemy.exc.ProgrammingError: (psycopg2.errors.UndefinedTable) relation "image" does not exist

[SQL:
CREATE TABLE post_image (
post_id INTEGER NOT NULL,
image_id INTEGER NOT NULL,
PRIMARY KEY (post_id, image_id),
FOREIGN KEY(image_id) REFERENCES image (id),
FOREIGN KEY(post_id) REFERENCES post (id) ON DELETE cascade
)

The api end point should be:
/v1/api-endpoint
instead of just: /api-endpoint

It's better if later have to support multiple versions.

User should be able to send friend message to other users.

Post not found after making request in test.

Instance <Post at 0x7fc0ec09f090> is not bound to a Session; attribute refresh operation cannot proceed (Background on this error at: http://sqlalche.me/e/bhk3

As of now, we are checking the file extension to allow only certain file type to be uploaded. We can do much better.

Right now there is no image manger to handle file upload. We need to create one that has easy api to create file of different sizes and retrieve them. e.g:

Save

image = Image->add(image)
image->save(app.config.get('image_sizes'))

Retrieve

image = Image->query->get_using_id(image_id)

We need scheduler to do background tasks like:

• clean up posts, notifications, or chat messages
• send emails and may be run bot users (if that's included in future)

Suggestion:

• Should be two scheduler, one to run urgent tasks other to run general background tasks.