42bv / jarb-final-form

Validating forms through JaRB, with react-final-form.

About

JaRB JaRB aims to improve database usage in Java enterprise applications. With JaRB you can get the validation rules from the database into Java. With this project you can get those rules into your react-final-form powered forms as well.

Installation

npm install @42.nl/jarb-final-form --save

Documentation

See the documentation

jarb-final-form's Issues

Multiple select required field valid when value is empty array

When a multiple select field is required, an empty array as value is valid, while the array should contain at least 1 item.

Expose utilities to make querying the constraint based on a validator easier.

isRequired('Hero.name')
hasMinimumLength('Hero.name')

etc etc.

Validation rules not updating when validators / asyncValidators change.

Boolean validation considers false wrong.

The boolean required validation requires the boolean to be of value true.

This is strange in the following situation: lets say we have a dropdown which shows three options and their values:

1. "Do you agree", undefined
2. "Yes", true
3. "No" false

When you have a required boolean we currently only consider the option "Yes" valid. This is strange because "No" is perfectly valid. The only invalid choose is "Do you agree".

Historically a boolean required was considered sort of a "agree" choice which the user had to answer true too. We must change this behavior.

One caveat is that for a checkbox we would not accept the undefined value as valid. This means that the user must set all checkboxes too false manually by default. But this way we support al usecases.

Date value never passes required check

As explained in 42BV/ui#636, when the value is of type Date, the required validator always returns an error.

Required validation for strings should not allow blank strings

Strings such as " " which consists only of whitespace should not be allowed.

Crash when setting a Java collection type as validator in JarbCheckboxMultipleSelect

Background

I have a JarbCheckboxMultipleSelect which has the following props:

<JarbCheckboxMultipleSelect
  name="nestedObjects"
  label="Geneste Objecten"
  optionForValue={someValue => someValue.description}
  options={getPossibleValuesBasedOnOtherValues(form.getState().values)}
  jarb={{
    validator: 'TheEntity.nestedObjects',
    label: 'Geneste objecten'
  }}
/>

The Java class for the root-level entity looks as following:

package nl._42.customer.project.the.package.to;

import java.util.List;
import java.util.UUID;

import javax.persistence.CascadeType;
import javax.persistence.Entity;
import javax.persistence.FetchType;
import javax.persistence.JoinColumn;
import javax.persistence.OneToMany;

import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import nl._42.customer.project.the.package.to.TheNestedEntity;

/**
 * A class to demonstrate the issue with Jarb
 */
@Entity
@Getter
@Setter
@EqualsAndHashCode(callSuper = false)
@ToString(callSuper = true)
public class TheEntity extends EntityWithCode {

    private UUID someRelatedId;

    private String description;

    @OneToMany(fetch = FetchType.EAGER, cascade = CascadeType.ALL, orphanRemoval = true)
    @JoinColumn(name = "the_entity_id", updatable = false, nullable = false)
    private List<TheNestedEntity> nestedObjects;
}

This results in the /constraints endpoint giving the following response for the field nestedObjects:

"nestedObjects": {
   "javaType":"nl._42.customer.project.the.package.to.TheEntity",
   "required":false,
   "maximumLength":2147483647,
   "fractionLength":0,
   "radix":10,
   "name":"nestedObjects"
}

Expected behaviour

I expect that it is indicated whether or not it is required to pick at least one of the values using the checkboxes

Actual behaviour

The following error is logged and the application stops working:

utils.js:35 Uncaught TypeError: Cannot read property 'length' of undefined
    at Object.mostSpecificInputTypeFor (utils.js:35)
    at JarbField.getEnhancedValidate (JarbField.js:91)
    at JarbField.render (JarbField.js:184)
    at finishClassComponent (react-dom.development.js:17485)
    at updateClassComponent (react-dom.development.js:17435)
    at beginWork (react-dom.development.js:19073)
    at HTMLUnknownElement.callCallback (react-dom.development.js:3945)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:3994)
    at invokeGuardedCallback (react-dom.development.js:4056)
    at beginWork$1 (react-dom.development.js:23964)
    at performUnitOfWork (react-dom.development.js:22776)
    at workLoopSync (react-dom.development.js:22707)
    at renderRootSync (react-dom.development.js:22670)
    at performSyncWorkOnRoot (react-dom.development.js:22293)
    at react-dom.development.js:11327
    at unstable_runWithPriority (scheduler.development.js:646)
    at runWithPriority$1 (react-dom.development.js:11276)
    at flushSyncCallbackQueueImpl (react-dom.development.js:11322)
    at flushSyncCallbackQueue (react-dom.development.js:11309)
    at discreteUpdates$1 (react-dom.development.js:22420)
    at discreteUpdates (react-dom.development.js:3756)
    at dispatchDiscreteEvent (react-dom.development.js:5889)