2011scape / game Goto Github PK

Current Behavior

• Not implemented.

Expected Behavior

• Players with 51 agility can squeeze through the pipe that leads to Moss giants in varrock sewers. It can be used from either direction.

This should use the Quest varp/varbit system properly. Ideally the system checks the state of the varbits and acts accordingly.

Current Behavior

After changing from resizable to fixed clicking on prayer icons does nothing

Expected Behavior

Prayers should activate

Steps to Reproduce the Problem

1. Start in resizable mode
2. Change to fixed mode
3. Attempt to activate a prayer

Using this to keep track of issues found while experimenting with pre-existing instance code:

• Overlay and Underlays are not present in the instanced area
• Ground height data is not copied over
• Objects flicker often while moving around the instance
  • Seems to be related to Chunk.sendUpdates. I think this runs every time the player moves.
  • Increasing the height value passed to UpdateZoneFullFollowsMessage results in 2 versions of the instance appearing where only the version with the higher height flickers (video 1)
  • The non-flickering version is created by UpdateZonePartialFollowsMessage
• Teleing to the instance area after creating it results in a black screen. Does not happen when already in the instance area. (video 2)
  • Teleing out of the black screen results in the UpdateZoneFullFollowsMessage version of the instance appearing wherever you arrive
  • Related to RebuildRegionMessage.
    • Encoder and Message classes already exist
    • We don't currently have a packet structure defined for this.

Video 1 (Flickering)

Video 2 (Teleing after creating instance)

Current Behavior

Imps never teleport

Expected Behavior

Imps should teleport every ~75 seconds, with a 10% chance on each hit

• Imp Catcher
• Doric's Quest
• The Knight's Sword
• Cook's Assistant
• The Restless Ghost
• Rune Mysteries
• The Blood Pact
• Vampyre Slayer
• Shield of Arrav
• Prince Ali Rescue
• Unstable Foundations
• Pirate's Treasure
• Myths of the White Lands
• Demon Slayer
• Swept Away
• Gunnar's Groud
• Goblin Diplomacy
• Ernest the Chicken

Stats, health and prayer points should restore or decrease if they are not at their actual level.

I will attach the LoginDecoder process from RedRune666 for a reference.

Prioritizing Hero's guild to improve player travel. Not being able to recharge skills necklace and glories has been making travel extremely time consuming and expensive.

Summoning Potion, antifire, antipoison and energy potion functionality need to be added.

• Add slayer points shop
• Add ability to skip slayer tasks with points
• Add more slayer tasks

Reference to Pull Request: #486

This issue addresses all climbable objects across the world (contain climb right click options).
More specifically:

• Stairs
• Ladders
• Trapdoors

Current Behavior

Switching from fixed mode to resizeable or vice-versa can sometimes makes the clicking events in the quest tab (quests) be gone forever for the player until a relogin happens.

Expected Behavior

Switching between gameframes wasn't supposed to break the clicking events of the quest tab.

Steps to Reproduce the Problem

1. Open the settings (Wrench icon)
   2.Swap between fixed/resizeable modes (Do multiple times, cause its inconsistent to happen, but it happens)
   3.Then open ques tab and try to click on the quest components, nothing will happen untill a logout/relogin.

Shortcuts need to be added to the traversable world to maintain true emulation.

Current Behavior

• there be vampyre

Expected Behavior

• to be vampire

Steps to Reproduce the Problem

1. Login the game.
2. Engage with quest content.
3. Decide to do Vampire Slayer.
4. Witness uses of vampyre

Followup issue after #40 is merged

Current Behavior

After lighting a log, the character sometimes doesn't move.

Expected Behavior

The character should move to the first available tile in the directions west, east, south, north.

Steps to Reproduce the Problem

1. Move to the spot in the screenshot
2. Light a fire
3. The character doesn't move

The cause seems to be that the two unblocked directions (east and south) both return true on world.collision::isClipped. See the Player.findWesternTile() function. That shouldn't matter for moving after lighting a fire though.

The root of the issue is unknown at the moment, but it seems to be triggered when players move from one region to the next or teleports.

• Description of the Issue:
  After a player is teleported to a location, there are instances where other players in the vicinity cannot see the teleported player until a relog occurs. This behavior is notably observed when the teleportation happens while the observing player is moving away from the target location, and upon returning, the teleported player is invisible to them.

• Steps to Reproduce:

  1. Player A initiates teleportation of Player B to their location.
  2. During the teleportation delay, Player A moves away from the initial location.
  3. Player A returns to the original spot post-teleportation.
  4. Player B is visible to Player A, but Player A is invisible to Player B.

• Expected Behavior:
  Both players should be able to see each other post-teleportation, regardless of concurrent movements during the teleportation delay.

• Actual Behavior:
  Player B becomes invisible to Player A until Player B relogs or potentially performs another significant action.

• Possible Root Cause:

  • There might be a state desynchronization issue due to asynchronous task executions and the player state locking mechanism during teleportation.
  • The visibility checks or position updates for other players may not process players in a 'locked' state.
  • Delays within the teleportation task queue might desynchronize the players' states from the game world's perspective.

Needs a return
https://github.com/2011Scape/game/pull/504/files#diff-f4590da14e2f7e8f686cde1a30fccb64b9d33e7b7011b5b5b23f9abc510d49e4R55

  if (currentStage == LostCity.ENTRANA_DUNGEON) { //TRUE
        player.queue{
            monkDialogue(this)
        }
        //ADD RETURN
    }
    if (currentStage > LostCity.ENTRANA_DUNGEON) {
        dungeonEntrance(player)
    }
    else { //TRUE ALSO
        player.message("Nothing interesting happens.")
    }

Examples: Lumbridge chicken house, houses south of the castle in Falador.
Are the closed and open door objects mixed up?