1plam / fleetjourney Goto Github PK

Description

Due to the current unavailability of checking if the employee and trip exist, an EF Core exception is thrown whenever non-existent details are provided. This issue occurs because there is no proper check in place. Attempts to use AnyAsync, ContainsAsync, and Where methods have been unsuccessful. The proposed solution is to create a self-implemented wrapper-extensions method.

The issue occurs specifically in the Create and Update methods within the TripRepository class.

Repository File

• TripRepository.cs

Steps to Reproduce

1. Perform the Create or Update operation with non-existent employee or trip details.
2. Observe the EF Core exception that is thrown.

Code Snippet:

public async Task<bool> CreateAsync(Trip trip, CancellationToken cancellationToken)
{
    await _applicationDbContext.Trips.AddAsync(trip, cancellationToken);
    int result = await _applicationDbContext.SaveChangesAsync(cancellationToken);

    return result > 0;
}

public async Task<Trip?> UpdateAsync(Trip trip, CancellationToken cancellationToken)
{
    _applicationDbContext.Trips.Update(trip);
    await _applicationDbContext.SaveChangesAsync(cancellationToken);

    return trip;
}

Expected Behavior

The CreateAsync and UpdateAsync methods should include proper checks to verify the existence of the employee and trip. If the employee or trip is not found, appropriate error handling should be implemented, such as returning false or throwing an exception.

Proposed Solution

To address this issue, a self-implemented wrapper-extensions method should be created to check if the employee and trip exist before proceeding with the Create and Update operations.

Description:

When running the application, an unhandled exception is thrown, indicating that some services are not able to be constructed. The exception occurs while validating the service descriptors for various handlers and repositories. It appears that the issue arises from the inability to resolve the required dependencies, specifically the IRepository interface, which is not being injected into the corresponding APIs.

Steps to Reproduce:

1. Build and run the application.
2. Observe the unhandled exception being thrown.

Expected Behavior:
The application should start successfully without any exceptions related to service construction/validation and direct injection of IRepository.

Actual Behavior:
The application throws an unhandled exception due to the inability to construct certain handlers and resolve dependencies.

Root Cause:
The root cause of the exception is the missing injection of the IRepository interface into the APIs mentioned above. This causes an issue of unavailability to inject needed handlers without injecting each repository to Mediator.

Proposed Solution:
To resolve the exception and ensure proper dependency injection, the step of injection each repository in to each API has to be followed:

builder.Services.AddApplicationService(typeof(IRepository<,>));

While the proposed solution of injecting each repository into the APIs may resolve the exception and ensure proper dependency injection, it is not an ideal approach. Injecting multiple repositories directly into the APIs can lead to tight coupling and violation of the SRP.