110y / bootes Goto Github PK

View Code? Open in Web Editor NEW

36.0 36.0 2.0 782 KB

Bootes - xDS Control-Plane Kubernetes Controller-

License: MIT License

Dockerfile 0.49% Go 92.76% Makefile 6.75%

bootes's People

Contributors

Stargazers

Watchers

Forkers

tomoyamachi

bootes's Issues

Cache envtest instance for each test

CI does not run on PR from forked repository

like this: #94
Have to add events (pull_request) to CI manifest.

Use ConfigMap instead placing env vars in deployment in kpt package

Make OpenTelemetly Span more verbosely

Attributes
SpanKind
Event
etc...

Complete Envoy command args (node/cluster) via MutatingWebHook

Use ubuntu-20.04 in CI

kpt: README and setters description

Update to V3 API

Validate resources via AdmissionWebHook

e.g. Validate invalid Listener which has a non existing Cluster

Update controller-runtime to v0.6.0

Filter imported envoy package

related #47 , this imports all package however importing only required packages only is desirable.

kpt: failed to execute preStop hook

preStop:
  exec:
    command:
    - sh
    - -c
    - sleep 5

preStop executes sh -c sleep 5, however distroless image does not have such commands.

Provide REST API by using HTTPGateway

https://github.com/envoyproxy/go-control-plane/blob/master/pkg/server/v2/gateway.go
Might not be needed? 🤷‍♂️

Document: Installation

Route config has not been updated on StreamRequest

internal/xds/cache/cache.go.UpdateAllResources

Feature like Istio/EnvoyFilter

Tune memory usage spikes

Complete envoy.yaml via MutatingWebHook

Use security context in kpt deployment

Adopt to GCP Cloud Trace

Investigate weird time consumption between traces

Use dependabot

Can not update error state Envoy plane

Adjust controller concurrency

Implement more meaningful healthz/readyz

call gRPC endpoint
call kubernetes api

Update k8s.io/api & apimachinery & client-go

Graceful Restart

Consideration

inconsistency envoy configuration after deploying the controller...?

Do not requeue with invalid configuration

It is not recoverable in controller side.

Use kube-rbac-proxy

Automate Docker image publishing

Can not use typed_config like `envoy.config.filter.http.lua.v2.Lua`

Introduce WIP bot

Enable Linter

Update protobuf to 1.4.2

With current implementation, when I update protobuf with simply go get github.com/golang/protobuf caught errors like below:

--- FAIL: TestGetListener (0.15s)
    --- FAIL: TestGetListener/should_get_listener (0.02s)
panic: cannot handle unexported field at {*v1.Listener}.Spec.Config.FilterChains[0].Filters[0].ConfigType.(*envoy_api_v2_listener.Filter_TypedConfig).TypedConfig.state:
        "google.golang.org/protobuf/types/known/anypb".Any
consider using a custom Comparer; if you control the implementation of type, you can also consider using an Exporter, AllowUnexported, or cmpopts.IgnoreUnexported [recovered]
        panic: cannot handle unexported field at {*v1.Listener}.Spec.Config.FilterChains[0].Filters[0].ConfigType.(*envoy_api_v2_listener.Filter_TypedConfig).TypedConfig.state:
        "google.golang.org/protobuf/types/known/anypb".Any
consider using a custom Comparer; if you control the implementation of type, you can also consider using an Exporter, AllowUnexported, or cmpopts.IgnoreUnexported

goroutine 720 [running]:
testing.tRunner.func1.1(0x276cbe0, 0xc001cf6ff0)
        /path/to/sdk/go1.14.2/src/testing/testing.go:940 +0x421
testing.tRunner.func1(0xc0015b10e0)
        /path/to/sdk/go1.14.2/src/testing/testing.go:943 +0x600
panic(0x276cbe0, 0xc001cf6ff0)
        /path/to/sdk/go1.14.2/src/runtime/panic.go:975 +0x3e3
github.com/google/go-cmp/cmp.validator.apply(0xc0017a41e0, 0x299b5a0, 0xc000b55180, 0x1b9, 0x299b5a0, 0xc0017706e0, 0x1b9)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/options.go:241 +0x61f
github.com/google/go-cmp/cmp.(*state).tryOptions(0xc0017a41e0, 0x2fa15a0, 0x299b5a0, 0x299b5a0, 0xc000b55180, 0x1b9, 0x299b5a0, 0xc0017706e0, 0x1b9, 0x1)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:279 +0x15a
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f55a00, 0xc001e36b00)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:234 +0x3dd
github.com/google/go-cmp/cmp.(*state).compareStruct(0xc0017a41e0, 0x2fa15a0, 0x29d85c0, 0x29d85c0, 0xc000b55180, 0x199, 0x29d85c0, 0xc0017706e0, 0x199)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:400 +0x571
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f55940, 0xc000572ec0)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:262 +0x1a94
github.com/google/go-cmp/cmp.(*state).comparePtr(0xc0017a41e0, 0x2fa15a0, 0x2972fa0, 0x2972fa0, 0xc0016e4030, 0x196, 0x2972fa0, 0xc00091c5a8, 0x196)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:552 +0x6db
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f55a00, 0xc001e36a00)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:268 +0x1922
github.com/google/go-cmp/cmp.(*state).compareStruct(0xc0017a41e0, 0x2fa15a0, 0x2883160, 0x2883160, 0xc0016e4030, 0x199, 0x2883160, 0xc00091c5a8, 0x199)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:400 +0x571
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f55940, 0xc000572e80)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:262 +0x1a94
github.com/google/go-cmp/cmp.(*state).comparePtr(0xc0017a41e0, 0x2fa15a0, 0x27eb220, 0x27eb220, 0xc0016e4030, 0x16, 0x27eb220, 0xc00091c5a8, 0x16)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:552 +0x6db
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f55a80, 0xc000572e40)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:268 +0x1922
github.com/google/go-cmp/cmp.(*state).compareInterface(0xc0017a41e0, 0x2fa15a0, 0x284e420, 0x284e420, 0xc0015d8810, 0x194, 0x284e420, 0xc001764a90, 0x194)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:565 +0x5ea
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f55a00, 0xc001e36900)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:270 +0x1820
github.com/google/go-cmp/cmp.(*state).compareStruct(0xc0017a41e0, 0x2fa15a0, 0x29bce80, 0x29bce80, 0xc0015d8800, 0x199, 0x29bce80, 0xc001764a80, 0x199)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:400 +0x571
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f55940, 0xc000572e00)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:262 +0x1a94
github.com/google/go-cmp/cmp.(*state).comparePtr(0xc0017a41e0, 0x2fa15a0, 0x2ad94e0, 0x2ad94e0, 0xc0016e4048, 0x196, 0x2ad94e0, 0xc00091c5b0, 0x196)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:552 +0x6db
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f559c0, 0xc00008b080)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:268 +0x1922
github.com/google/go-cmp/cmp.(*state).statelessCompare(0xc0017a41e0, 0x2f559c0, 0xc00008b080, 0x0, 0x42d070)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:205 +0xf9
github.com/google/go-cmp/cmp.(*state).compareSlice.func2(0x0, 0x0, 0x0, 0x466a3c8)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:466 +0x105
github.com/google/go-cmp/cmp/internal/diff.Difference(0x1, 0x1, 0xc0017ad928, 0x1, 0x1, 0xc001af69d8)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/internal/diff/diff.go:221 +0x231
github.com/google/go-cmp/cmp.(*state).compareSlice(0xc0017a41e0, 0x2fa15a0, 0x26f8fc0, 0x26f8fc0, 0xc0014d2d30, 0x197, 0x26f8fc0, 0xc0013fa940, 0x197)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:465 +0x839
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f55a00, 0xc001e36800)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:264 +0x13dd
github.com/google/go-cmp/cmp.(*state).compareStruct(0xc0017a41e0, 0x2fa15a0, 0x2afa3c0, 0x2afa3c0, 0xc0014d2d20, 0x199, 0x2afa3c0, 0xc0013fa930, 0x199)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:400 +0x571
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f55940, 0xc000572d80)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:262 +0x1a94
github.com/google/go-cmp/cmp.(*state).comparePtr(0xc0017a41e0, 0x2fa15a0, 0x2affa60, 0x2affa60, 0xc0016e4040, 0x196, 0x2affa60, 0xc00091c5b8, 0x196)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:552 +0x6db
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f559c0, 0xc00008b020)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:268 +0x1922
github.com/google/go-cmp/cmp.(*state).statelessCompare(0xc0017a41e0, 0x2f559c0, 0xc00008b020, 0x0, 0xc0017ae490)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:205 +0xf9
github.com/google/go-cmp/cmp.(*state).compareSlice.func2(0x0, 0x0, 0x0, 0x466a3c8)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:466 +0x105
github.com/google/go-cmp/cmp/internal/diff.Difference(0x1, 0x1, 0xc0017ae6e0, 0x1, 0x1, 0xc001af6980)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/internal/diff/diff.go:221 +0x231
github.com/google/go-cmp/cmp.(*state).compareSlice(0xc0017a41e0, 0x2fa15a0, 0x26f9000, 0x26f9000, 0xc0015b0eb8, 0x197, 0x26f9000, 0xc00170c5b8, 0x197)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:465 +0x839
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f55a00, 0xc0018f9f00)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:264 +0x13dd
github.com/google/go-cmp/cmp.(*state).compareStruct(0xc0017a41e0, 0x2fa15a0, 0x2b8ec00, 0x2b8ec00, 0xc0015b0ea0, 0x199, 0x2b8ec00, 0xc00170c5a0, 0x199)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:400 +0x571
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f55940, 0xc000572ac0)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:262 +0x1a94
github.com/google/go-cmp/cmp.(*state).comparePtr(0xc0017a41e0, 0x2fa15a0, 0x2b81e00, 0x2b81e00, 0xc0011093e0, 0x196, 0x2b81e00, 0xc00057ab20, 0x196)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:552 +0x6db
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f55a00, 0xc0018f9d00)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:268 +0x1922
github.com/google/go-cmp/cmp.(*state).compareStruct(0xc0017a41e0, 0x2fa15a0, 0x28d1c80, 0x28d1c80, 0xc0011093d8, 0x199, 0x28d1c80, 0xc00057ab18, 0x199)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:400 +0x571
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f55a00, 0xc000d50a00)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:262 +0x1a94
github.com/google/go-cmp/cmp.(*state).compareStruct(0xc0017a41e0, 0x2fa15a0, 0x2943920, 0x2943920, 0xc0011092c0, 0x199, 0x2943920, 0xc00057aa00, 0x199)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:400 +0x571
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f55940, 0xc001764b80)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:262 +0x1a94
github.com/google/go-cmp/cmp.(*state).comparePtr(0xc0017a41e0, 0x2fa15a0, 0x2b95ea0, 0x2b95ea0, 0xc0011092c0, 0x16, 0x2b95ea0, 0xc00057aa00, 0x16)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:552 +0x6db
github.com/google/go-cmp/cmp.(*state).compareAny(0xc0017a41e0, 0x2f44a00, 0xc001764b40)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:268 +0x1922
github.com/google/go-cmp/cmp.Equal(0x2b95ea0, 0xc0011092c0, 0x2b95ea0, 0xc00057aa00, 0xc0017b2180, 0x2, 0x2, 0x0)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:112 +0x2e4
github.com/google/go-cmp/cmp.Diff(0x2b95ea0, 0xc0011092c0, 0x2b95ea0, 0xc00057aa00, 0x0, 0x0, 0x0, 0xc00057aa00, 0x0)
        /path/to/go/pkg/mod/github.com/google/[email protected]/cmp/compare.go:132 +0x1ce
github.com/110y/bootes/internal/k8s/store_test.TestGetListener.func1(0xc0015b10e0)
        /path/to/go/src/github.com/110y/bootes/internal/k8s/store/store_test.go:705 +0x1d0
testing.tRunner(0xc0015b10e0, 0xc000b55220)
        /path/to/sdk/go1.14.2/src/testing/testing.go:991 +0x1ec
created by testing.(*T).Run
        /path/to/sdk/go1.14.2/src/testing/testing.go:1042 +0x661
FAIL    github.com/110y/bootes/internal/k8s/store       7.315s
?

Use Replicaset.Namespace as Envoy node cluster name

ref: Lyft's case: https://docs.google.com/document/d/1X9fFzqBZzrSmx2d0NkmjDW2tc8ysbLQS9LaRQRxdJZU/edit#heading=h.15nsmgmjaaml

Make OnRequest callback response only bootstrap request

Admin Console

like envoy Admin console

kpt: run as non root

Make UpdateXXX parallel in XXXReconciler

Use kubernetes-sigs/controller-runtime/pkg/log/zap instead raw zap

https://github.com/kubernetes-sigs/controller-runtime/tree/master/pkg/log/zap

Use Bazel

To make skaffold reload server more faster.

Automate update go-control-plane (envoy proto)

ref: #82

Add Liveness/Readiness Probe

make ListenerReconciler validate invalid Listener and publish event

Treat error_details in DiscoveryRequest

Reconsider default SVC type

ClusterIP

Make log timestamp key configurable

Some logging services like Datadog treat timestamp key in logs implicitly. It might conflict those service features.

ref: https://docs.datadoghq.com/logs/processing/processors/?tab=ui#log-date-remapper

Fix unexpected N + 1 cache update

Use google.golang.org/protobuf/encoding/protojson instead

github.com/golang/protobuf/jsonpb is deprecated.

https://godoc.org/github.com/golang/protobuf/jsonpb

Add license

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.