1000memories / tmquiltview Goto Github PK

Steps to reproduce

1. Open TMQuiltViewDemo project from HEAD
2. Remove self.quiltView.backgroundColor = [UIColor blackColor]; from viewDidLoad
3. Attempt to scroll the quilt view by dragging anywhere outside of the TMQuiltViewCell (in the margin area)

Expected

Underlying scroll view scrolls.

Actual

No scrolling behaviour occurs.

is it?

In original demo project

Change number of cell

- (NSInteger)quiltViewNumberOfCells:(TMQuiltView *)TMQuiltView {
    return 3; // [self.images count];
}

Change the height of cell

- (CGFloat)quiltView:(TMQuiltView *)quiltView heightForCellAtIndexPath:(NSIndexPath *)indexPath {
    return 100; //[self imageAtIndexPath:indexPath].size.height / [self quiltViewNumberOfColumns:quiltView];
}

After scroll to top to so that first two cell hidden then release scrolling, the second cell is disappeared.

Love this library! Want to use it for an app I am building, but can you update it to be more compliant with ARC and iOS 7? Thanks!

Hi, it a very good component,
how can we add infinite scroll in TMQuiltView

Modify TMDemoQuiltViewController to have only one cell:

const NSInteger kNumberOfCells = 1;

Run the demo project and scroll up the view until you completely hide the photo in the upper margin. It seems as if the photo doesn't come back down.

After adding UILabel to the TMQuiltViewCell view, text getting blurred on right list of the view.

the first one, each append datas, the view will calculate cell's frame from index 0.
the second, drag up the scroll view and make the last cell out of visible view , then move up your fingers you'll find all of cells is remove from supperview.

Why don't call in my controller

• (void)quiltView:(TMQuiltView *)quiltView didSelectCellAtIndexPath:(NSIndexPath *)indexPath ?

Trying to insert a new Cell with NSFetchedResulltController doesn't seems to reload the cells. New cell doesn't appear event if I put a reloadData after it. It appears when I restarted the app, so the insertion in Core Data works. I'm using the last TMQuiltView.m.

Hello i want to display the image in a uiimageview when the user click on an image. How do i know which cell index was clicked? Mant thanks :)

for this TMQuiltView load images must get the image height,but if the load images come from network server,how to load it ?

dealloc code releases _reusableViewsDictionary first, but then cleanupColumns code path will re-create the dictionary and leak all objects in it. The fix is to move cleanupColumns to the beginning of dealloc.

• (void)dealloc {
  [_indexPaths release], _indexPaths = nil;
  [_reusableViewsDictionary release], _reusableViewsDictionary = nil;
  [_rowsToInsert release], _rowsToInsert = nil;
  [_rowsToDelete release], _rowsToDelete = nil;

  [self cleanupColumns]; <== leaks _reusableViewsDictionary

  [self removeGestureRecognizer:self.tapGestureRecognizer];
  [_tapGestureRecognizer release], _tapGestureRecognizer = nil;

  [super dealloc];
  }

TMQuiltViewDelegate have protocol: - (CGFloat)heightForCellAtIndexPath:(NSIndexPath *)indexPath;. And it result a performance issue if the height need a calculation according to cell content. The currently implementation simply request the method every time it layoutSubView(though rectForCellAtIndex).

Like UITableView, it should call once for each indexPath and cache it. Prevent re-calculation during scroll. The cache should be clear after the user call follow method:

- (void)beginUpdates;
- (void)resetView;