0xtechnoir / blockchain-developer-bootcamp-final-project Goto Github PK

Hi @bnaylor1989 , I'm a mentor of the consensy bootcamp responsible for grading your project.
Congratulations, your Final Project passed! We'll be approving it on the course itself in a week or two, but here's your feedback in the meanwhile:

Front End

• Great to see your front-end handling the MFT mintage, as well as detecting both account and network changes. Additional kudos for suggesting to the user to change the network to rinkby and prompting metamask to do so.
• Great that your contract was deployed to Rinkeby. Did you use truffle for the deployments? By your readme, I'd assume so - but just confirming ;-)
• Really nice to see the FE deployed to Netlify. Did you have any previous experience with it? If not, how was the process?

Unit Testing

• Good structure for your tests, and using the features from the test framework (before, describe, it, etc) to organize your set of unit tests.
• test coverage is awesome. keep up the great work. The close to 100% test coverage the better"

Smart Contract

• Good choice for leveraging on OpenZeppelin's library, and having your contract using inheritance to implement the ERC721 functionalities, reentrancy checks, access controls, etc.
• Good job also adding the require statements and modifiers to validate against access controls and other conditions that should be met before proceeding with the functions' execution.
• Great usage of access controls to allow only owner pausing the contract, and again, adding require statements to check for necessary conditions before the function executes.
• I noted you inherit your contract from ReentrancyGuard, but I couldn't find any usage of the ""nonReentrant"" modifier. Was that intentional?
• As a best practice, one improvent for your mint function is to apply the Checks-Effects-Interactions pattern
• Great that you used OpenZeppelin library to leverage on controls for ownability and the basic NFT functionality. Always good to use battle-tested libraries ;-)"

General Feedback

• I really liked how you added the links on your FE so the user can navigate to etherscan or opensea to check the transaction/nft.
• Nice front-end and project. Kudos to all the unit test coverage and implementing an MVP project that is kinda complex (lots of features in the contract), instead of only doing basic NFT mintage. Huge Congrats!!!"