030 / bcbsn

Send a build status to Bitbucket using the Bitbucket Cloud Build Status Notifier (BCBSN).

bcbsn's Issues

Would it be possible to overwrite the build status of a commit?

bcbsn should accept only the http status code 201

When initially creating the build badge Bitbucket will return a 201 every subsequent change of the build status will return a 200. We will have to update the code to both accept a 200 and a 201.

changelog.md

cli - cobra

golangci badge

Use go modules instead of dep

As of go 1.11 we can use the built-in go modules instead of using dep for dependency management.

docker

access_token: x509: certificate signed by unknown authority

Hi when I try to run with the latest version I get the next error

$ docker run utrecht/golang-bitbucket-cloud-build-status-notifier:1.0.1 -keyString dg6DvhHhjT5gYQZCPE:MYPASSWORD -buildState SUCCESSFUL -gitCommit d5d24e56325d0ad938141ee1556cbce4a3d6f926 -owner owner -repositoryName MYCOMPANY-upgrade-service -buildNumber 13 -buildURL http://jenkins.MYCOMPANY.io:8080/job/archive_builds/job/upgrade-service/job/jenkinsfile-test/20/

2019/03/26 08:44:09 Post https://bitbucket.org/site/oauth2/access_token: x509: certificate signed by unknown authority

license

Do the artifacts really work on osx and windows?

It seems that the different artifacts were all built on linux.

Add a working example snippet

Currently we are missing a working snippet in how to use this plugin, this makes it hard for people to start using this plugin.

Readme out-of-date

The actual parameters used by bcbsn are not up-to-date anymore i.e. -keyString is replaced by -clientId and -clientSecret.

Use a nonprivileged user

Currently we run the image as root, this is not necesary and we should create a nonprivileged user and use that instead.

See this blog for some inspiration.

forbidden does not return non-0

Exit code should be non-0 if forbidden.

overwrite existing build status

https://developer.atlassian.com/server/bitbucket/how-tos/updating-build-status-for-commits/

Updating build results

Bitbucket Server stores one build result for each key per commit, so you can update a previous build result by sending a request with:

the same commit hash; and
the same key attribute.

Return human friendly logging

A couple of lines of JSON is returned when the bcbsn exits. This could be more concise and human friendly.

cii best practices badge

artifact should not be stored in root dir

https://askubuntu.com/a/1157/561376

That depends, really. If the application has a makefile, or for example for python apps if the application uses distutils (e.g., has a setup.py file), or a similar build/install system, you should install it into /usr/local/. This is often the default behavior. From what I understand, /usr/local/ has a hierarchy that is similar to /usr/. However, directories like /usr/bin/ and /usr/lib/ are usually reserved for packages install via apt. So a program expecting to get "installed" into /usr/ should work fine in /usr/local/.

proper integration test

Execute the integration test by using a real token and let build fail if there are issues.

No Healthcheck found

explain how the oauth credentials should be created

No callback uri defined for the OAuth client.

docker-test

https://github.com/ory/dockertest

https://github.com/testcontainers/testcontainers-go

badges

Incorrect artifacts in releases section

Require signed commits

Ensure Content trust for Docker is Enabled

https://docs.docker.com/engine/security/trust/content_trust/

sonar

readme does not indicate that oauth token requires repository write permissions

panic: runtime error: index out of range

If -keyString is omitted, then a panic: runtime error: index out of range is returned. This error message could be improved, e.g. -keyString parameter seems to be omitted.