wojtekmaj / react-lifecycle-methods-diagram Goto Github PK

Motivation

I realize that the phrase "New props" is in the original tweet of Dan Abramov, but "new props" is vague and misleading. Further, it tends to reinforce the misconception mentioned in Brian Vaughn's blog post that the "Updating" swimlane is triggered only when the props "change" or are "different" ( "new" props suggests "different" from "old" props). As the blog post says "these lifecycles are called any time a parent component rerenders, regardless of whether the props are 'different' from before".

Proposal

Change the wording to say "parent rerenders" or something similar.

Aside

I'm not trying to be picky. Dan's diagram and your project have been infinitely helpful in aiding my understanding, yet I've continuously seen beginner, intermediate, and even some advanced React developers tripped up by this confusion. It's a small change, but if you agree, I can help out and do the PR as well.

useTranslation() gets called way too much. Between 350 and 450 times per screen. (it depends on the screen). Because it updates the state in a useEffect(), it gets re-rendered and called a few times.

It should be called way less often (below 35 times per screen).
You can easily see this by placing a console.log() in the main body of the useTranslation() function.

I would love to make a PR for Vietnamese translation since React community in Vietnam are quite big.
Let me know what you think @wojtekmaj

zh-Hans language is not displayed, but in i18n/languages.json There are already. eg: https://projects.wojtekmaj.pl/react-lifecycle-methods-diagram/

Currently, in the available languages dropdown Hindi (India) is missing. Add support for the Hindi language.

Update the reference links of official and updated React Documentation.

It was cool to be able to switch (choose) the language

Hello,

The below URL is not working

https://projects.wojtekmaj.pl/react-lifecycle-methods-diagram/

@wojtekmaj
Urdu is currently missing from the available languages dropdown. I have added Urdu language support.

Hello @wojtekmaj ,

I really appreciate this diagram and wanted to thank you for your work.

I just released a <custom-element> version 🚀
https://github.com/AndyOGo/custom-element-reactions-diagram

https://andyogo.github.io/custom-element-reactions-diagram/

If you are interested, you may link to it:)

Best Regards,
Andy

Something like 'React lifecycle methods'.

When sharing the online version with other people if I don't tell them beforehand what's the link about, it's not so easy to understand what's the diagram about at first glance.

It would be nice to show where the callbacks in hooks are fired.

componentWillReceiveProps() / UNSAFE_componentWillReceiveProps()
static getDerivedStateFromProps()
shouldComponentUpdate()
componentWillUpdate() / UNSAFE_componentWillUpdate()
render()
getSnapshotBeforeUpdate()
componentDidUpdate()

https://reactjs.org/docs/react-component.html

As reported in #2, wording is confusing.

"Show less common lifecycles" means "Show me also those lifecycles which are less common" and NOT "Show me less lifecycles".

For the purposes of bookmarking, it would be really great if the option to "Show less common lifecycles" was in the route.

like
shouldComponentUpdate(nextProps, nextState)
shouldComponentUpdate(nextProps, nextState)

Should we change label getDerivedStateFromProps to static getDerivedStateFromProps cause getDerivedStateFromProps is a static method?

I started to wonder, does React set all the refs to null before it calls componentWillUnmount or after?

However the diagram does not tell? Which one is it?

The language drop-down menu shows Argentina flag for Arabic language. The reason is probably because of the value used for Arabic option is AR, which is ISO for Argentina flag emoji.
Suggested solution is to replace the language code to become AE or SA .

When checking the checkbox do display the less common lifecycles, a bug happens and changes the name of some of the states to render. You can see this in the print below

Hi @wojtekmaj , I created Japanese translation for the diagram. Could you give me the permission to push to this repo?
Regards.

Macedonian language is missing and all of the docs are leading to the old documentation so I would like to update that.

"Chinese(Taiwan)" is is incorrect. "Chinese(Traditional)" is right! Chinese language, only the difference between simplified Chinese and traditional Chinese, there is no difference between regions.

You should avoid possible political problems.

@wojtekmaj

specifically here:
http://projects.wojtekmaj.pl/react-lifecycle-methods-diagram/

environment: macOS 10.14.5

I saw that the Chinese flag 🇨🇳was specifically filtered out in the code and turned into the earth icon🌏 ,I feel this is very unfriendly，please remove the relevant filtering code immediately.