Rare error
2019.09.20 09:54:59.878 1 FadeForm ERROR System.ObjectDisposedException: Auf das verworfene Objekt kann nicht zugegriffen werden.
Objektname: "Menu".
bei System.Windows.Forms.Control.CreateHandle()
bei System.Windows.Forms.Form.CreateHandle()
bei System.Windows.Forms.Control.get_Handle()
bei SystemTrayMenu.FadeForm.ShowInactiveTopmost(Form frm) in D:\Seafile\Markus\C#Projects\systemtraymenu\Helper\FadeForm.cs:Zeile 166.

related to this also
$exception | {"Dieser BackgroundWorker ist derzeit ausgelastet und kann nicht mehrere Aufgaben gleichzeitig ausführen."} | System.InvalidOperationException

• Version: 0.9.1.251

This has already worked once,

Try e.g. to deactivate and then press a item which not actives other form e.g. a background script

use template from here
https://gist.githubusercontent.com/PurpleBooth/109311bb0361f32d87a2/raw/8254b53ab8dcb18afc64287aaddd9e5b6059f880/README-Template.md

fill informations, update here in my comments
afterwards we release it in file ReadMe

Project Title

One Paragraph of project description goes here

Getting Started

These instructions will get you a copy of the project up and running on your local machine for development and testing purposes. See deployment for notes on how to deploy the project on a live system.

Prerequisites

What things you need to install the software and how to install them

Give examples

Installing

A step by step series of examples that tell you how to get a development env running

Say what the step will be

Give the example

And repeat

until finished

End with an example of getting some data out of the system or using it for a little demo

Running the tests

Explain how to run the automated tests for this system

Break down into end to end tests

Explain what these tests test and why

Give an example

And coding style tests

Explain what these tests test and why

Give an example

Deployment

Add additional notes about how to deploy this on a live system

Built With

• Dropwizard - The web framework used
• Maven - Dependency Management
• ROME - Used to generate RSS Feeds

Contributing

Please read CONTRIBUTING.md for details on our code of conduct, and the process for submitting pull requests to us.

Versioning

We use SemVer for versioning. For the versions available, see the tags on this repository.

Authors

• Billie Thompson - Initial work - PurpleBooth

See also the list of contributors who participated in this project.

License

This project is licensed under the MIT License - see the LICENSE.md file for details

Acknowledgments

• Hat tip to anyone whose code was used
• Inspiration
• etc

We should create an update process
Do we need an installer therefore? There is an installer and updater in when using the visual studio publish

Setup and update process should be like e.g. Notepad++
At least we need a function, check for updates now

https://www.howtogeek.com/howto/12383/change-a-file-types-icon-in-windows-7/

only one icon possible per filetype
except: exe, ico, ink, url (expecially game url)

... are there more?

When you delete a file by right click in the STM, an immediate update would be nice.

-fix warnings which are left in code
-refactor that code is better understandable
-adjust to 80 characters, max 200 lines per class

Sometimes nothing happens after double clicking on the notify icon => document when, and also why

Further idea: Maybe a double click should open the root folder (not sure, think about that)

Description, Steps to reproduce, Expected behavior, Screenshots
Prepare a folder with the following contents:

• dolls
• dollar
• lol

Do the following steps:

• Type 'd' it will select 'dolls'.
• Within a second type 'o' it will still select 'dolls'
• Within a second type 'l' it will still select 'dolls'
• Within a second type 'l' it will still select 'lol' as 'l' was pressed a second time.
  At this point Windows explorer search will select 'dolls'.

What is the intention by STM? @Hofknecht
I was expecting "same" explorer behavior which means it should continue selecting 'dolls'?

Issue relates to KeyPress() at SystemTrayMenuHandler.cs

In rare cases windows exporer shows the icon, STM does not.
Find more cases and analyze.
E.g. single item in my special music folder AnnenMayKantereit

Description, Steps to reproduce, Expected behavior, Screenshots
when i make a right click on shortcut to drive C: or D: i get an exception, see screenshot

message is shown interally (not throwing any exception to STM, so nothing in logfile) in
int nResult = _oContextMenu.QueryContextMenu(
pMenu,
0,
CMD_FIRST,
CMD_LAST,
CMF.EXPLORE |
CMF.NORMAL |
((Control.ModifierKeys & Keys.Shift) != 0 ? CMF.EXTENDEDVERBS : 0));

problem is solved when right click on other folder or shortcut, then exception not more happens (until restart).
Can the code solution be that we call it with fake/stub data (like in the manual workaround)?
What is the root cause for the error message?

• OS: Microsoft Windows 10 Pro
• Version: 0.9.1.251

When application crashed we ask user to send error as email

Missing informations about

• licence (after we added it)
• mail Tanja
• add other colleges

Is your feature request related to a problem? Please describe.
When working on certain projects one maybe would like to hide some folders or files.

Describe the solution you'd like
Option to filter entries to hide them from the list.

Describe alternatives you've considered
(Maybe additionally for later) support of .gitignore or similar as a default filter list that can be activated.

Additional context

In old versions there were problems with 4k, but we adjusted code.
We should test again at 4k or other scalings and check if there are any problems.

Found here a possiblity
https://www.codeproject.com/articles/2939/network-shares-and-unc-paths?fid=9166&df=90&mpp=25&prof=True&sort=Position&view=Normal&spc=Relaxed&fr=81

Addional:
Whats about mapped drive's actual path?
https://stackoverflow.com/questions/2067075/how-do-i-determine-a-mapped-drives-actual-path

We should have a certificate for the exe from http://www.cacert.org/
(This will also prevent the screen at first start)

User mentioned there is a flag in windows which should be respected regarding fading
=> Can we read this flag, how is it called?
=> Should we create an extra option in the contextmenu?
=> Or if too many options we should create an extra settings menu.

Possibility to open menu on mouse position (e.g. also by shortcut)

-Be aware of the Problem e.g. user expects appearing on first screen but it appears on second screen

Can we open the menu by option (context menu)?
Do we want this regarding to our philosophy?
Maybe link this to the taskbar orientation task

We maybe want to add a search at the top, fulltext search, only show these files others not or in gray, or sort
big change we need to think about this Change Requests
-are there more simple ideas
-can we use ctrl + f or such things

We should add contextmenu item.
Maybe extra dialogue, but then we can directly add a settings menu
or
selectable in the contextmenu like the languages

Can we read this dark mode also from windows?

Should we make it possible for the user to set MenuDefines e.g. from a xml?
=> This was also an idea before, but we want it as easy as possible for the user.

Do we need a bigger solution e.g. folder 'styles' & e.g. extra menu to select and/ or to preview it
It depends on how many styles we have and how complexe they are. Maybe only 4 values which are fix in code and only normal and dark so context menu enough?

When the user moves the mouse over an item in STM, he can open the contextmenu of this item by right click.
To close that contextmenu he has to press ESC, but the user often does not know that.
So he might click somewhere else on the desktop and this closes the STM.

Solution 1:
Explain that in a FAQ (Therefore create a FAQ, do we have other topics there?)

Solution 2:
Think about other possibilities e.g. tell the user the hint instead of hiding it in a FAQ
e.g. extra x somewhere user can click

-When click shutdowntimer.exe, app not starting
-no exception in logfile

chinese characters => no icon
If an itemname contains e.g. chinese characters there is an exception.
Check if also the icon is not shown, is the exception handling also ok?, is then the disposing of the menu ok?

Test if there are more problems with special characters

More possiblities for Change folder
That should be as easy as possible for the user.

Solution 1:
contextmenu item 'Create Link' This creates a shortcut with cmd line parameter.
user can then switch by shortcuts

Solution 2:
Drag Drop a folder on the STM-icon to set it as root folder.

Solution 3:
Windows Explorer Context Menu Extension to change folder to STM Folder

-> wrong use: user should put shortcuts into the selected folder instead of changing the folder very often?
Think about the topics

Is your feature request related to a problem? Please describe.
When there are several files and you have a scrollbar. Search an item which only exists once. Scroll down and search again.

Describe the solution you'd like
Scroll again to the item exactly like windows explorer

Additional context
see also video

We created a dotnetframework.yml, this builds and sends mail when build fails
(was replaced by azure-pipelines.yml)

TODO:

• Version and Release process, e.g. release to project website
• here a release process https://medium.com/@two06/building-tooling-with-github-actions-59401648e61d
• related to fixcop, should we set severity level to error, so that *.yml throws a fail mail?
• i think we decided against but think again if versioning ok, we set it still manaully https://stackoverflow.com/questions/3387108/details-of-assembly-version/3387167#3387167

We have to review the code.
Can we refer to other projects?
E.g. Windows code api, clearence log, icon pack
Check also code register hotkey e.g. also from hitcountermanager

Think about:
IsAnyMenuActive

English spelling e.g. aN update

Bob told he want to have the files like on the desktop, there he move a file on a shortcut to open the file with the application (which is opened by the shortctu)

We had a form with DragDrop Hint to explain the user how to group out the icon into systemtraymenu.
Should we show the form at the first start or by an extra contextmenuitem? Should we addionally show the Windows option menu where the user can also set up this?

Or should the icon always stay ungrouped in the systemtraymenu?
We tought there was a possibility to handle this by code, but it does not seem like that, check again => dropbox is always able to show the icon ungrouped

see comments below

issue1:
better colors for selected and hover ones and was too bright

issue2:
selected folder other color than hover (as hover still too bright?)

issue3:
no more yellow, is strange

issue4:
grey color when inactive

issue5:
RootFolder when not selected should not be in hover color, maybe also white
RootFolder when selected should not be in selected color, maybe only hover

idea
when key used disable mouse enter
when mouse move enable mouse enter
=> problem enable is too fast, we miss logic

we only get mouse move when on app
we cannot seperate between enter&move with and without mouse move
e.g. waiting for several move events or miss first enter event has problems e.g. first next selected item by mouse will be missed
can we wait short period to disable logic? probably no because then shortly wait on any item will cause the mouse again to enter and this will be strange again then?
we always not know how long the menu needs to open so always wrong idea in this way!
how can we differ 1. enter+mousemove 2. enter+mousemove (we only know keypressed before x ms?)

So if your program wants to detect whether the mouse has moved,
you need to add a check in your WM_MOUSEMOVE that the mouse position is different
from the position reported by the previous WM_MOUSEMOVE message.

Is your feature request related to a problem? Please describe.
when e.g. connected over remote desktop and host system has other dpi other applications like teams or outlook assign their layout directly, stm shown like in screenshot

restart solves the problem

Describe the solution you'd like
restart solves the problem, there is a event for it

Additional context
when log out and log in that problem not happens, so normally only possible over remote desktop probably

Description, Steps to reproduce, Expected behavior, Screenshots
e.g. when register a hotkey -> could not register hotkey (let the dialog open) -> right click contextmenu and e.g. restart

• Version >= 0.9.1.244

Make the repo public

-after license
-after code buity

Description, Steps to reproduce, Expected behavior, Screenshots
The files Desktop.ini and Thumbs.db will be shown when an intermediate shortcut (lnk) points to an UNC or mapped network location.

issue1 (orig):
when changing by mouse and keyboard a left key was not possible (make sure it was not also because of the empty folder)
not more sure, fixed then by others?

issue2:
opened by key, menu appears on mouse, mouse opens next menu ... not intended => maybe when opened by key and mouse not yet moved not allow the submenu enter
SOLVED

issue3:
current hover by mouse is always same as selecteditembykey, can be switched smoothly
TODO NOW

Is your feature request related to a problem? Please describe.
We need a license, i did press none when initialize repo
see here step by step, probably GNU
https://help.github.com/en/articles/adding-a-license-to-a-repository

-also for [Feature] certificate #7

Hidden Folders should not be shown or at least a bit transparent
If possible read from windows option if they are shown, if yes show transparent

Missing handling of other taskbar orientiations.
(or at least a hint that this is not supported, but now i think we should support it)

Think about how to solve

In the past we had the problem that antivirus, norton or avast deleted the systemtraymenu.exe.
Should be fixed since we wrote a mail to both of them.
We need to check if there are more.

It should be fixed, when we solve [Feature] Certificate (exe) #7

Description, Steps to reproduce, Expected behavior, Screenshots
0.9.1.238 did not see this, in 0.9.1.243 i regocnized a behavior that autostart was disabled but when click on it there was still a X for not active. After e.g. select language it gets activated. but did not test if just refresh or if it was really not activated before
we refresh the contextmenu by restart
check rev 238 -> 243

• Version [e.g. 0.9.1.243]

For the user it was not visible that he had no permissions, only folder empty was shown

Show name of the ink, not the target path
Drive was shown without text

Show Hidden Folders Transparent, see screenshot, should be the same like in windows explorer

(Hint: Hidden Folders only showed, when flag active to show them in windows from #1 )

We need a code review tool to improve the code style.
Goal should be perfect readable code.

2020.03.11 22:26:23.997 1 Program ERROR System.ArgumentOutOfRangeException: Der Index lag außerhalb des Bereichs. Er darf nicht negativ und kleiner als die Sammlung sein.
Parametername: index
bei System.Collections.ArrayList.get_Item(Int32 index)
bei System.Windows.Forms.DataGridViewSelectedRowCollection.get_Item(Int32 index)
bei SystemTrayMenu.Handler.KeyboardInput.SelectByKey(Keys keys, String keyInput, Boolean KeepSelection) in D:\Seafile\Markus\C#Projects\systemtraymenu\Handler\KeyboardInput.cs:Zeile 277.
bei SystemTrayMenu.Handler.KeyboardInput.CmdKeyProcessed(Keys keys) in D:\Seafile\Markus\C#Projects\systemtraymenu\Handler\KeyboardInput.cs:Zeile 84.
bei SystemTrayMenu.Menu.ProcessCmdKey(Message& msg, Keys keys) in D:\Seafile\Markus\C#Projects\systemtraymenu\Controls\Menu.cs:Zeile 314.
bei System.Windows.Forms.Control.PreProcessMessage(Message& msg)
bei System.Windows.Forms.Control.PreProcessControlMessageInternal(Control target, Message& msg)
bei System.Windows.Forms.Application.ThreadContext.PreTranslateMessage(MSG& msg)

Clipboard is filled when doubleclicking on root folder
Open the STM and doubleclick on the root folder over the label at the top. Afterwards the name of the root folder is copied to clipboard.

Something should happen when pressing Ctrl+F,
kind of windows explorer search or windows start menu search or any other special search
see also #22

(Would be good if we can press stm shortcut, then Ctrl+F, then e.g. 'sys*.sln', then enter ... but sounds that we need to reimplement kind of windows search, so indicie files is probably not a option (to much efford? needs many system resources?), think about it)