Coder Social home page Coder Social logo

Comments (4)

vladar avatar vladar commented on June 12, 2024 1

Yeah, we have a prettify step to get rid of those redundant fragments. But looks like it doesn't work as expected in 0.5.0. In theory, it shouldn't break anything but I'll check it.

Thanks for reporting! 👍

from gatsby-graphql-toolkit.

kdichev avatar kdichev commented on June 12, 2024

In my case the issue is that I have a query complexity limit from api and those fragments push the query over it

from gatsby-graphql-toolkit.

vladar avatar vladar commented on June 12, 2024

I think the problem is with nested ids. The prettify step basically removes duplicates of ID fragment. But in your case after we add remoteTypeName: __typename to sys field it becomes different from the ID fragment:

fragment AccordionListItemId on AccordionListItem {
  remoteTypeName: __typename
  sys {
    id
  }
}

I think in v0.5.0 this is what've changed:

fragment PageContentAccordionList__itemsCollection__0__items__0 on AccordionListItem {
  remoteTypeName: __typename
  sys {
+   remoteTypeName: __typename
    id
  }
}

Now, this fragment is not a subset of the ID fragment anymore hence not removed. Just out of curiosity - what happens if you add this to the ID fragment (not suggesting as a fix, just want to confirm my hypothesis):

fragment AccordionListItemId on AccordionListItem {
  __typename
  sys {
+   __typename
    id
  }
}

from gatsby-graphql-toolkit.

vladar avatar vladar commented on June 12, 2024

Should be fixed in 0.6.0

from gatsby-graphql-toolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.