Coder Social home page Coder Social logo

Comments (16)

ihadeed avatar ihadeed commented on July 23, 2024 3

@karlvd thanks for the feedback. I will use the repo you provided to do some testing and fix this.

from ionic-super-tabs.

ihadeed avatar ihadeed commented on July 23, 2024 2

Fixed in 2.3.3

from ionic-super-tabs.

karlvd avatar karlvd commented on July 23, 2024 1

Fantastic work, thank you!

@mforloni works for me

Create an object to pass on as rootParams

this.rootParams = {
   myVar: 'someValue'
};

Add it to the super-tab element
<super-tab [root]="'SomePage'" [rootParams]="rootParams" title="Title" id="myTab"></super-tab>

Pick it up in the constructor on the tab page
this.myVar = navParams.get('myVar');

from ionic-super-tabs.

palbaladejo avatar palbaladejo commented on July 23, 2024

Yes, I have the same issue. It is loaded, but no displayed at the template.

Thanks @karlvd, downgrading to 2.1.0 solved the issue for now.

from ionic-super-tabs.

Anujmoglix avatar Anujmoglix commented on July 23, 2024

same issue for me . @palbaladejo how you downgrade it ? share command

from ionic-super-tabs.

karlvd avatar karlvd commented on July 23, 2024

@palbaladejo to downgrade, just update your package.json to
"ionic2-super-tabs": "2.1.0"

run
npm install

from ionic-super-tabs.

Anujmoglix avatar Anujmoglix commented on July 23, 2024

thanks

from ionic-super-tabs.

karlvd avatar karlvd commented on July 23, 2024

@ihadeed I have done a few more tests related to this issue and updated the repo to cover more scenarios
repo

The page for the second tab contains various scenarios for loading data, my conclusions so far:

  • Any data set in ionViewDidLoad() doesn´t bind to the template, including just assigning a value to a var, the event fires but the data can´t be accessed by the template
  • Data such as assigning a value to a var works using ngOnInit() instead of ionViewDidLoad()
  • Calling a provider from ngOnInit() fires the success callback but any data set in it is not accessible by the template
  • Based on this, the problem is not related to http, rather something related to scope and binding
ionViewDidLoad() {
    console.log('load tab2');
    this.anything3 = 'Anthing set in ionViewDidLoad()';
    // Any data set here is not accessible
    this.stuff1 = {
      stuff: ['x', 'y', 'z']
    }

    this.stuffProvider.getStuff().subscribe((response) => {
      // Any data set here is not accesible
      this.stuff2 = {
        stuff: response.data
      };
      // This fires correctly
      console.log('provider success 1');
      // This log is printed
      console.log(this.stuff2);
    }, (error) => {
      console.log('provider error 1 : ' + error);
    });

  }

  ngOnInit() {
    this.anything4 = 'Anthing set in ngOnInit()';
    // Any data set here is accessible
    this.stuff3 = {
      stuff: ['x', 'y', 'z']
    };

    this.stuffProvider.getStuff().subscribe((response) => {
      // Any data set here is not accesible
      this.stuff4 = {
        stuff: response.data
      };
      // Not even this
      this.stuff5 = {
        stuff: ['x', 'y', 'z']
      };
      // This fires correctly
      console.log('provider success 2');

    }, (error) => {
      console.log('provider error 2 : ' + error);
    });
  }

from ionic-super-tabs.

ihadeed avatar ihadeed commented on July 23, 2024

Could you please update to [email protected] and let me know if this issue is fixed?

from ionic-super-tabs.

karlvd avatar karlvd commented on July 23, 2024

Same result unfortunately :(

from ionic-super-tabs.

mforloni avatar mforloni commented on July 23, 2024

I have the same problem! please, fix it on time :(

from ionic-super-tabs.

mforloni avatar mforloni commented on July 23, 2024

rootParams not work!! How can I pass parameters to tabs?

from ionic-super-tabs.

Anujmoglix avatar Anujmoglix commented on July 23, 2024

In my app performance is still not good :(

from ionic-super-tabs.

mforloni avatar mforloni commented on July 23, 2024

@karlvd I have a big problem.
After the fix, the component work but I can change the content on the tab only at the first loading and when I don't change the tab. Why?
Example, if I open one new tab and then I return on the previous tab and I change its content (ex. one icon) this not display the modify.
Can you help me?
first
second

from ionic-super-tabs.

kodeine avatar kodeine commented on July 23, 2024

#61 i guess its related to this?

from ionic-super-tabs.

ihadeed avatar ihadeed commented on July 23, 2024

@kodeine no I don't think they're related. This issue here is fixed.

from ionic-super-tabs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.