Coder Social home page Coder Social logo

Comments (4)

AlCalzone avatar AlCalzone commented on September 28, 2024

Hard to see in the UI, but apparently physically impossible devices are tested (Outbound right position & tilt, combined with Outbound Bottom position & tilt):
Image

Test procedure:

Set OutRightPosition to 50 (51 %)

Set VerticalSlatsAnlgePosition to 50 (open)

Set HorizontalSlatsAnlgePosition to 99 (closed, down inside)
The label is missing from the UI. The entities are called "Outbound Bottom Vertical Slats Angle" and "Outbound Right Vertical Slats Angle". However, the first (position up/down) should have horizontal slats. It appears that both tilt sliders for the outbound bottom and outbound right both control the vertical angle, and none controls the horizontal one.
Image

Start Level Change down for Out Bottom Position, then stop
The arrow buttons set a value of 0 instead of starting the down movement:
Image
The middle button stops down movement correctly.

Start Level Change down for Horizontal Slats Angle, then stop
Not possible

from certification-backlog.

marcelveldt avatar marcelveldt commented on September 28, 2024

Checked the code - the wrong value is being called when setting open/close cover.

For the horizontal tilt: we should map the right titlt property value to the position property value.
so horizontal position = vertical tilt and vertical position = horizontal tilt.
https://github.com/home-assistant/core/blob/dev/homeassistant/components/zwave_js/cover.py#L214

from certification-backlog.

marcelveldt avatar marcelveldt commented on September 28, 2024

What is basically missing is separate controls for the tilt feature. Atm this only allows setting the value, not send a command like "start titling".

Possible workaround: Create separate entities for the position and title ? That way we can have all required actions present for both position and tilt.

  • start move/tilt up
  • start move/tilt down
  • stop move/tilt
  • set position/tilt value

Worst case scenario we create the additional entity for the tilt feature only (and keep the current combined one).

from certification-backlog.

AlCalzone avatar AlCalzone commented on September 28, 2024

For certification (as a short-term workaround):

  • Create separate entities for position only and tilt only, don't combine them
  • Solve #32 aswell

Longer term:

  • Make sure the correct position + tilt values are combined. E.g. vertical position + horizontal slats tilt
  • Add a way to open/close tilt separately from position. Start/Stop, not set position.
  • Consider bidirectional tilt, where 50% is open, 0/100% is closed to one side.

Window covering parameters indicate which is which (propertyKey of the value).

Relevant:
home-assistant/architecture#912
home-assistant/architecture#979

from certification-backlog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.