Coder Social home page Coder Social logo

Comments (7)

zth avatar zth commented on May 29, 2024 1

@a-sane out in 2.0.0 🎉

from relay-compiler-language-js-flow-uncommented.

zth avatar zth commented on May 29, 2024

Hey! I don't maintain this anymore, but I believe Relay now ships its own Flow types, no?
https://github.com/facebook/relay/blob/b065ae242fd24387dc14195f00d693615c2e7b81/gulpfile.js#L256-L268

from relay-compiler-language-js-flow-uncommented.

a-sane avatar a-sane commented on May 29, 2024

In last relay version (9.1.0) generated flow types in __generated__ folders still commented and WebStorm/IDEA do not properly support flow types inside of comments.
Also your plugin still mentioned in actual docs: https://relay.dev/docs/en/type-emission#language-plugins
So it seems in that case I should create issue in relay repo about their docs :)
Thank you!

from relay-compiler-language-js-flow-uncommented.

zth avatar zth commented on May 29, 2024

If you're interested in having this work, it's probably pretty easy to solve and I'd be happy to merge a PR for it! @a-sane would you be interested in doing a PR?

from relay-compiler-language-js-flow-uncommented.

a-sane avatar a-sane commented on May 29, 2024

@zth sure, i think this should fix the issue:
#2
I checked on my project, and it seems to be working well

from relay-compiler-language-js-flow-uncommented.

zth avatar zth commented on May 29, 2024

@a-sane excellent, thank you! I will release a new version ASAP. Thanks for fixing this 😄

from relay-compiler-language-js-flow-uncommented.

a-sane avatar a-sane commented on May 29, 2024

@a-sane amazing, thank you!

from relay-compiler-language-js-flow-uncommented.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.