Coder Social home page Coder Social logo

Comments (8)

babarot avatar babarot commented on September 26, 2024

Thank you for your report.

I have a question about the dependency expressed with the pipe |. Does this represent the order in which plugins are installed or loaded (or both)?

I think it's both. Because this feature is from vim-plug.

nice tag in zplug certainly can represent the dependency of the plugins, but under normal circumstances, it should be used as the feature for loading after compinit (ref. #26). However, because I wasn't keen on treating nice tag as a special thing, I generalized it and then implemented. As a result, nice tag can also be used as representaion of dependency.

In short:

  • The pipe should be used for dependency of the plugins
  • Provided that it is necessary to decide specifications (installation/loading dependencies, or both)
  • nice tag should be used for loading after compinit (More flexibly, can also be used as dependency management)

from zplug.

NigoroJr avatar NigoroJr commented on September 26, 2024

Thanks, that makes sense. But then, would that mean the case above is a bug? The expected output of running it is:

plugin a
plugin b

because plugin a should be loaded before plugin b, right?

from zplug.

babarot avatar babarot commented on September 26, 2024

That is a bug just like you said.

from zplug.

babarot avatar babarot commented on September 26, 2024

In haste, we should fix that bug. Then, there is also a need to make sure the specifications.

from zplug.

NigoroJr avatar NigoroJr commented on September 26, 2024

Yes, I was reading the source code for a while trying to figure out how the dependencies are set, but wasn't quite sure what is causing this 😢 It seems like the on tag is not set when plugin b is checked for its dependency but that's about as far as I got.

from zplug.

babarot avatar babarot commented on September 26, 2024

To tell the truth, the mechanism of managing dependencies is most complex section in zplug. Because the processes connected by a pipe is run in a subshell, all processing need to be run in the process.
https://github.com/b4b4r07/zplug/blob/feature/notifier/zplug#L1796-L1815

It seems like the on tag is not set when plugin b is checked for its dependency but that's about as far as I got.

Okay, I'll seek it.

from zplug.

babarot avatar babarot commented on September 26, 2024

That is a bug just like you said.

Fixed.

from zplug.

NigoroJr avatar NigoroJr commented on September 26, 2024

Works perfectly now, thank you!

from zplug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.