Coder Social home page Coder Social logo

Comments (10)

mgedmin avatar mgedmin commented on May 29, 2024

The third solution is probably not much of a solution, unless everyone who makes releases remembers to
build and upload py26, py27 wheels to PyPI at release time, passing --python-tag=py26/py27 as appropriate for each python bdist_wheel command.

from zodb.

jamadden avatar jamadden commented on May 29, 2024

I'm responsible for the use of zodbpickle under 2.7 (it was already dynamically computed and used under Py3), so I'm happy to help resolve this. I guess I should finally try to read and understand PEP 426 :)

I added it for Python 2.7 because cPickle is broken in 2.7. cPickle works fine under 2.6, though (which is why jimfulton hadn't encountered the issue before). Now, zodbpickle claims to be an implementation of the Python 2.7 pickle modules, but it is also tested on Python 2.6. When the use of zodpickle under 2.7 was merged, I did a quick review of the differences between the 2.6 and 2.7 pickle modules, and didn't find anything that looked like a compatibility issue to me.

If that holds true, then I would support option one, using zodbpickle under Python 2.6. Although it's an additional dependency (for that one implementation), it would simplify the test matrix, and it seems reasonable and consistent to use the same pickle implementation under all platforms.

from zodb.

mgedmin avatar mgedmin commented on May 29, 2024

Oh snap I don't have PyPI rights for ZODB (and discovered this in the middle of ./fullrelease for 4.2.0b2). @jimfulton, @tseaver: please?

from zodb.

tseaver avatar tseaver commented on May 29, 2024

https://pypi.python.org/pypi/ZODB/4.2.0#change-history

from zodb.

mgedmin avatar mgedmin commented on May 29, 2024

Welp, 4.2.0 doesn't fix this :(

Back to the drawing board (I want to understand why before attempting a different fix).

from zodb.

mgedmin avatar mgedmin commented on May 29, 2024

I cannot reproduce using the STEPS TO REPRODUCE anymore, but I can reproduce using zodbbrowser's tox.ini on Linux.

from zodb.

jamadden avatar jamadden commented on May 29, 2024

RE: using zodbpickle everywhere: Although the pickle format wouldn't change, the exceptions that get raised would (from cPickle.PicklingError to zodbpickle.fastpickle.PicklingError, represented as _pickle.PicklingError) . This could be a minor compatibility concern (we ran into this in one of our test suites after jumping to ZODB 4.2.0).

from zodb.

mgedmin avatar mgedmin commented on May 29, 2024

I did a tox -r and now can't reproduce on Linux any more.

I can reproduce on Windows, even after wiping the Jenkins workspace.

from zodb.

mgedmin avatar mgedmin commented on May 29, 2024

Filed a pip bug: pypa/pip#2870

from zodb.

mgedmin avatar mgedmin commented on May 29, 2024

My problem was that I was building ZODB wheels with wheel 0.23.0, which did not support environment markers and thus created wrong metadata in the .whl file.

Upgrading to wheel 0.24.0 fixed everything.

from zodb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.