Adding pool on the fly about node-open-mining-portal

[mooleshacat]

If you use PM2 to run your pool this isn't much of a problem as the restart happens immediately (unless of course the new configuration contains an error)

npm install -g pm2@latest
pm2 install pm2-logrotate
pm2 startup (it may ask you to c/p a command)
pm2 start --name pool node -- init.js
pm2 save

pm2 restart pool - restart pool
pm2 logs pool - watch pool logs
pm2 start pool - start pool
pm2 stop pool - stop pool
pm2 del pool - delete pool

A good miner software I imagine will save the last share it submitted if it failed because of the connection and try to re-submit the share. I also think good software would try to re-submit any share that failed to submit for any reason. I am not sure if the underlying software and stratum protocol would support this though.

The only time I ever had issues with miners being disconnected is when I manually stop it and start it with time in between.

Usually when I use pm2 restart pool it does it so fast that there is 0 effect on the miners (no dropped shares due to jobid, lost connections, etc)

One thing I would add to this idea, is the ability to test the configuration before you deploy it - a command to check all configs are good (main, and individual coin configs) as well as fail-safe methods so if one coin's config is screwed it only affects that one single coin and the rest can still function.

All that being said though, dynamic reloading of configuration as well as config testing and fail-safe would be amazing.

[zone117x]

This would be a great feature. It can be implemented once we get the frontend developed, and the admin page of the frontend developed :)

[mculp]

This is huge! I have to disconnect my entire network to add a coin right now!

[iangcarroll]

+1

[mineoncloud]

forever restart init.js disconnect all ppl ? Or its enough fast for do the job ?

[mculp]

yes it disconnects all workers
On Apr 12, 2014 10:59 AM, "bayo31" [email protected] wrote:

forever restart init.js disconnect all ppl ? Or its enough fast for do the
job ?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-40284174
.

[LiveChains]

We tryed adding pools on the fly by adding there configs but with the coins off started the portal and from there it throws an errer about the coins RPC Responce, but did seem to load up and allow pople to mine there coins, to actually add the coin for starting we jsut started the new coin (configs already loaded rememer) and waited for it to pool.

Been trying out lots of crazy ideas with this since a customer asked for it.

Devs need a pat on the back such a breeeeze to work with

[nicoschtein]

I have almost finished this feature.
I also was pointed to https://www.bountysource.com/issues/1588495-adding-pool-on-the-fly so if anyone would like to contribute feel free to do so, if not, after i have polished the code i will submit PR.

For now, i have this working:

• Add new file pool_configs/new_pool_name.json
• Send node scripts/cli.js reloadpool new_pool_name
• New stratum instance is spawned, supporting clustering if enabled.
• New workers are auth'ed and can start mining

What needs to be polished:

• Profit switching to use new coin
• Payouts to new coin.

[nicoschtein]

UPDATE

For now, i have this working:

• Add new file pool_configs/new_pool_name.json
• Send node scripts/cli.js reloadpool new_pool_name
• New stratum instance is spawned, supporting clustering if enabled.
• New workers are auth'ed and can start mining
• Profit switching to use new coin (new)

What needs to be polished:

• Payouts to new coin.

Also a bounty was met, that was quick, Thanks mineoncloud
All other backers still welcome to donate 👍

[nicoschtein]

UPDATE

For now, i have this working:

• Add new file pool_configs/new_pool_name.json
• Send node scripts/cli.js reloadpool new_pool_name
• New stratum instance is spawned, supporting clustering if enabled.
• New workers are auth'ed and can start mining
• Profit switching to use new coin
• Payouts to new coin. (new)

What needs to be added:

• Update frontend to show new coin stats

All other backers still welcome to donate 👍

[icecube45]

Looking forward to it!
-icecube45 ($50 Backer)

[iangcarroll]

Nice.—
Sent from Mailbox

On Thu, May 15, 2014 at 1:01 AM, icecube45 [email protected]
wrote:

Looking forward to it!

-icecube45 ($50 Backer)

Reply to this email directly or view it on GitHub:
#5 (comment)

[mineoncloud]

Ping me when all done and when we can start test !!!

Mineoncloud.

[nicoschtein]

Should be ready to test now. Will submit PR.
I need to rebase my branch before I can submit PR... Won't take that long...

[nicoschtein]

@miningpoolhub @mineoncloud @icecube45 PR #211 is up.
Please test, it should work fine, but do it with test pools just in case...

[nicoschtein]

Has anyone tested #211 already?

[mineoncloud]

I go test today ! But one thing is to add this function in admin tabs too .

[nicoschtein]

Sure, as soon as this is confirmed to work, I can try to call cli from admin section.
On May 19, 2014, at 1:22 PM, mineoncloud [email protected] wrote:

I go test today ! But one thing is to add this function in admin tabs too .

—
Reply to this email directly or view it on GitHub.

[mineoncloud]

Just add first pool with this functions report =
block count = ok
payout for fees = ok
stats = ok for now
payout for worker waiting confirm but all look good.
Also any error in log for now.

[mineoncloud]

All work well on my side right now !! Add , payout , fees ( I just dont test multipool switch because dont use it atm ) !! I have also try disable pool ( turn enabled to false + reload it ) and it work.

[nicoschtein]

So? Does this work for the others too?

[nicoschtein]

Can this be merged already?
It will be easier for me so I can rebase to master with this merged.
Will also help with #214

[scorpio18]

This function is not working for me :(

[nicoschtein]

What is wrong ?
I assume you have pulled my PR to test this, since this has not been merged yet... It won't work in a normal installation...

On May 27, 2014, at 6:02 PM, scorpio18 [email protected] wrote:

This function is not working for me :(

—
Reply to this email directly or view it on GitHub.

[scorpio18]

so that why is not working , i have seen on my nomp folder and i tried on my nomp pool :) Sry

[nicoschtein]

Ok that explains it, don't worry!

I'm waiting for repo owner to merge this, or other users to report any errors, I thinks it works fine.
As soon as this is confirmed to work and merged I will start with the other issue for removing and restarting a pool after modifying it.

On May 27, 2014, at 6:32 PM, scorpio18 [email protected] wrote:

so that why is not working , i have seen on my nomp folder and i tried on my nomp pool :) Sry

—
Reply to this email directly or view it on GitHub.

[nicoschtein]

@miningpoolhub @zone117x @mineoncloud So, can we merge #211 or let me know what's needed so I can continue working on CLI?

[mineoncloud]

For me its good ! Why this is not yet merged ??

[mrzeta]

make it - -

[nicoschtein]

@mrzeta I did not understand what you meant..
@mineoncloud I think that since repo owner did not merge this #211 at the time, it has now outdated code in it....... for some reason another PR got merged before this one.
Please @zone117x let me know if and what is needed for the rebase. Thanks!

[sigwo]

When starting pool on the fly, the public key was not added to the drop down list to convert public key to importable key for the added pool.

[splicer9]

I concur with sigwo. Coin is not added to key page.
All other functions seem to work fine for me.

[gr33k]

Hey @zone117x you alive still? what's the status of this?
Thank you @nicoschtein and others for contributions and @zone117x for this awesome mining pool...however I'm disappointed that development has stopped :(