Compiler warnings: format-truncation about zlog

[zma]

I pushed a quick fix. It is not perfect--the buffer for local time may be longer than the buffer.

But at least it avoids the warning messages.

$ gcc-8 -Wall example.c zlog.c -o example -lpthread
$ gcc-8 --version
gcc-8 (Ubuntu 8.3.0-6ubuntu1~18.04) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[pmembrey]

Confirmed that it avoids the warning for me too. Would be good to look at a more robust fix for a future version maybe but this is already an improvement :)

[pmembrey]

Did some quick tests - looks good. Thanks for taking care of this so quickly! :)

[zma]

Thanks for the confirmation.

So far, I would like to find some time to do some more revisions first to handle the cases when the strftime() returns 0 if the buffer is not large enough ( https://www.systutorials.com/docs/linux/man/3-strftime/ ) although it is rare. If strftime() fails, the library can fall back to the ! ZLOG_REAL_WORLD_TIME case.

[jwaggy]

Could you use ctime_r() for the datetime formatting which is guaranteed to be 26 bytes or less?

[zma]

@jwaggy ctime_r() sounds a better solution. Would you like to send some pull request?

[pmembrey]

This was fixed in master as of 44c5d8a but current master fails to compile with the same error. Looks like a regression....

[pmembrey]

Looks like it was introduced in this commit: 93e66a8

[zma]

I may take a little time and implement @jwaggy’s suggestion to fix this problem.

[zma]

The warnings should now be taken care of.