URL.decode on a URL without a path or ending slash fails to "get" about zio-http

[aappddeevv]

Good catch. The query parameters follow a '?' per the http spec so my example that I typed in by hand may have been mistyped or the machine generated URL from a commercial server (not mine) that was being used was bad...let me check.

[aappddeevv]

Typo in my example on my part...fixed the text above.

Maybe the issue is that the rendering of the URL in the the layer that translates it to the execution engine (e.g. netty) does not handle Path.empty correctly.

[jdegoes]

/bounty $50

[algora-pbc]

💎 $50 bounty created by jdegoes
🙋 If you start working on this, comment /attempt #2238 to notify everyone
👉 To claim this bounty, submit a pull request that includes the text /claim #2238 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to zio/zio-http!

Attempt	Started	Solution
🟢 @abcpro1	Jun 19, 2023	#2271

[Vivek7038]

can you suggest me the fix i should do , i can instatly fix . what should be the url?
just want some clarity on these

[vigoo]

Seems like java.net.URI's parser which this relies on cannot parse this properly - it treats everything after the scheme as the authority. So if we want to fix this we need to write our own URL parser.

[de-laz]

@vigoo @aappddeevv I don't really have enough context on this issue but shouldn't the given example be val url = URL.decode("https://blah.com?m=1&k=4") instead of val url = URL.decode("https://blah.com&m=1&k=4")? The domain and parameters are separated by an "&" instead of "?", not sure if that's important.

[aappddeevv]

I'm concerned that there may be other factors that affected the issue I had and the resolution, this small scala-cli program seems to give the error I would expect given that the query params are invalid, but it shows that the call goes out as expected although it does not work if I use https but that seems to be another matter.

//> using dep dev.zio::zio-http:3.0.0-RC2
//> using scala 3.3.0

import zio.*
import zio.http.*

val program = for {
  res <- Client.request("http://www.google.com?blah=hah&hah=blah")
  data <- res.body.asString
  _ <- Console.printLine(data)
} yield ()

object Main extends ZIOAppDefault:
  def run =
    program
      .provide(
        Client.default,
      )

[vigoo]

@de-laz good catch :) with the fixed string decoding/encoding this works:

          val url = "https://blah.com?m=1&k=4"
          assertTrue(URL.decode(url).map(_.encode) == Right(url))

The above example sends the expected HTTP request to google.

and it responds with a 404 with some HTML body.

The URL is good with https too.
First when testing with https it seemed like I always get a io.netty.channel.AbstractChannel$AnnotatedNoRouteToHostException but sometimes it worked. Digging into this, I noticed that it depends on which host the DnsResolver picks.

If I always pick the first one it always works with both http and https (the scheme has nothing to do with the dns resolving phase of course). If I pick the last one which is an IPv6 address, it fails.

Is this the same error you got?
Maybe we should filter IPv6 addresses in the DNS resolver?

[abcpro1]

/attempt #2238

[algora-pbc]

💡 @abcpro1 submitted a pull request that claims the bounty. You can visit your org dashboard to reward.

[algora-pbc]

🎉🎈 @abcpro1 has been awarded $50! 🎈🎊