Comments (7)
This being said, the template variadic list is a neat idea.
If you think that it would be a useful addition we could still implement the new method without using the C++20 requires
.
I think that we can implement the check on the template parameters by simply using std::enable_if
, which is from C++11 so we don't need to update the standard.
What do you think?
from cxxgraph.
In this way, I think is good!
from cxxgraph.
I don't think forcing users to upgrade their version of the C++ standard is necessarily a good thing.
Supporting new features from the standard is fine as long as it's hidden in the library - but if it's in the headers it becomes a far more troublesome problem.
Having the maximum amount of backwards compatibility is a good thing. Most library implementers should strive for that.
This being said, the template variadic list is a neat idea.
from cxxgraph.
I think we should discuss and consider the possibility of distributing a standard hpp/cpp library, as the drawbacks of header-only are starting to manifest in this library.
from cxxgraph.
This SO article goes over some of the basic points: https://softwareengineering.stackexchange.com/questions/305618/are-header-only-libraries-more-efficient
I do think the low administrative costs of a header-only library make it attractive to keep.
from cxxgraph.
I think we should discuss and consider the possibility of distributing a standard hpp/cpp library, as the drawbacks of header-only are starting to manifest in this library.
I think we can open a discussion in discussion section.
from cxxgraph.
I do think the low administrative costs of a header-only library make it attractive to keep.
I Agree with @nrkramer
from cxxgraph.
Related Issues (20)
- Add `CXXGraph::Node` storage to `CXXGraph::Graph` to support trivial graphs and friends HOT 10
- For Node<T> move constructor, T copy constructor is called when the move constructor is not defined but the move assignment operator is defined. HOT 1
- Unable to build test "GraphTest" after PullRequest #344 HOT 3
- addEdge() method does not copy the weight HOT 4
- some test fails if test_exe ran from current directory other than build/test HOT 8
- Segmentation fault while running benchmark_exe HOT 3
- Use of cached adjacency matrix in all algorithms HOT 1
- Implement matrices used in network dynamics HOT 2
- Break out algorithms in Graph.hpp into Algorithms/ folder HOT 2
- Use Adjacency Matrix to populate the nodeSet. HOT 7
- Inclusion of "sink nodes" in adjacency map HOT 1
- bug on a floyd warshall test
- Introduce Bron-Kerbosch Algorithm
- Introduce Graph Coloring Algorithm
- Introduce Welsh Powell Algorithm HOT 4
- Build a Docusaurus Documentation HOT 9
- [BUG] Illegal Instruction SIGILL in addEgdes_1 HOT 2
- How to best improve results of an algorithm (get nodes and order in path) HOT 4
- Problems in compilation From CodeQL
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cxxgraph.